* [asoc:topic/max9867 2/4] sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared; did you mean 'complete'?
@ 2018-03-01 19:45 kbuild test robot
2018-03-01 20:01 ` Ladislav Michl
0 siblings, 1 reply; 5+ messages in thread
From: kbuild test robot @ 2018-03-01 19:45 UTC (permalink / raw)
To: Ladislav Michl; +Cc: alsa-devel, Mark Brown, kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2318 bytes --]
tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/max9867
head: 79e139744508105bd749300f364563934bff23f2
commit: 8b9c716aada77e72e2fe82320aba5a95b75ca400 [2/4] ASoC: max9867: Improve error logging
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
git checkout 8b9c716aada77e72e2fe82320aba5a95b75ca400
# save the attached .config to linux build tree
make ARCH=i386
All errors (new ones prefixed by >>):
sound/soc/codecs/max9867.c: In function 'max9867_set_dai_sysclk':
>> sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared (first use in this function); did you mean 'complete'?
dev_err(component->dev,
^~~~~~~~~
complete
sound/soc/codecs/max9867.c:294:11: note: each undeclared identifier is reported only once for each function it appears in
vim +294 sound/soc/codecs/max9867.c
275
276 static int max9867_set_dai_sysclk(struct snd_soc_dai *codec_dai,
277 int clk_id, unsigned int freq, int dir)
278 {
279 struct snd_soc_codec *codec = codec_dai->codec;
280 struct max9867_priv *max9867 = snd_soc_codec_get_drvdata(codec);
281 int value = 0;
282
283 /* Set the prescaler based on the master clock frequency*/
284 if (freq >= 10000000 && freq <= 20000000) {
285 value |= MAX9867_PSCLK_10_20;
286 max9867->pclk = freq;
287 } else if (freq >= 20000000 && freq <= 40000000) {
288 value |= MAX9867_PSCLK_20_40;
289 max9867->pclk = freq/2;
290 } else if (freq >= 40000000 && freq <= 60000000) {
291 value |= MAX9867_PSCLK_40_60;
292 max9867->pclk = freq/4;
293 } else {
> 294 dev_err(component->dev,
295 "Invalid clock frequency %uHz (required 10-60MHz)\n",
296 freq);
297 return -EINVAL;
298 }
299 value = value << MAX9867_PSCLK_SHIFT;
300 max9867->sysclk = freq;
301 /* exact integer mode is not supported */
302 value &= ~MAX9867_FREQ_MASK;
303 regmap_update_bits(max9867->regmap, MAX9867_SYSCLK,
304 MAX9867_PSCLK_MASK, value);
305 return 0;
306 }
307
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 63077 bytes --]
[-- Attachment #3: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [asoc:topic/max9867 2/4] sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared; did you mean 'complete'?
2018-03-01 19:45 [asoc:topic/max9867 2/4] sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared; did you mean 'complete'? kbuild test robot
@ 2018-03-01 20:01 ` Ladislav Michl
2018-03-01 20:04 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Ladislav Michl @ 2018-03-01 20:01 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, kbuild test robot, kbuild-all
Mark,
On Fri, Mar 02, 2018 at 03:45:16AM +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git topic/max9867
> head: 79e139744508105bd749300f364563934bff23f2
> commit: 8b9c716aada77e72e2fe82320aba5a95b75ca400 [2/4] ASoC: max9867: Improve error logging
> config: i386-allmodconfig (attached as .config)
> compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
> reproduce:
> git checkout 8b9c716aada77e72e2fe82320aba5a95b75ca400
> # save the attached .config to linux build tree
> make ARCH=i386
>
> All errors (new ones prefixed by >>):
>
> sound/soc/codecs/max9867.c: In function 'max9867_set_dai_sysclk':
> >> sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared (first use in this function); did you mean 'complete'?
> dev_err(component->dev,
> ^~~~~~~~~
> complete
> sound/soc/codecs/max9867.c:294:11: note: each undeclared identifier is reported only once for each function it appears in
your topic/max9867 seems to be 4.16-rc1 based, while patch was tested
in today's -next. Fixing it for 4.16-rc1 would mean it fails to compile
once you merge topic branches.
What am I supposed to do here?
Thank you,
ladis
> vim +294 sound/soc/codecs/max9867.c
>
> 275
> 276 static int max9867_set_dai_sysclk(struct snd_soc_dai *codec_dai,
> 277 int clk_id, unsigned int freq, int dir)
> 278 {
> 279 struct snd_soc_codec *codec = codec_dai->codec;
> 280 struct max9867_priv *max9867 = snd_soc_codec_get_drvdata(codec);
> 281 int value = 0;
> 282
> 283 /* Set the prescaler based on the master clock frequency*/
> 284 if (freq >= 10000000 && freq <= 20000000) {
> 285 value |= MAX9867_PSCLK_10_20;
> 286 max9867->pclk = freq;
> 287 } else if (freq >= 20000000 && freq <= 40000000) {
> 288 value |= MAX9867_PSCLK_20_40;
> 289 max9867->pclk = freq/2;
> 290 } else if (freq >= 40000000 && freq <= 60000000) {
> 291 value |= MAX9867_PSCLK_40_60;
> 292 max9867->pclk = freq/4;
> 293 } else {
> > 294 dev_err(component->dev,
> 295 "Invalid clock frequency %uHz (required 10-60MHz)\n",
> 296 freq);
> 297 return -EINVAL;
> 298 }
> 299 value = value << MAX9867_PSCLK_SHIFT;
> 300 max9867->sysclk = freq;
> 301 /* exact integer mode is not supported */
> 302 value &= ~MAX9867_FREQ_MASK;
> 303 regmap_update_bits(max9867->regmap, MAX9867_SYSCLK,
> 304 MAX9867_PSCLK_MASK, value);
> 305 return 0;
> 306 }
> 307
>
> ---
> 0-DAY kernel test infrastructure Open Source Technology Center
> https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [asoc:topic/max9867 2/4] sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared; did you mean 'complete'?
2018-03-01 20:01 ` Ladislav Michl
@ 2018-03-01 20:04 ` Mark Brown
2018-03-01 21:34 ` Ladislav Michl
0 siblings, 1 reply; 5+ messages in thread
From: Mark Brown @ 2018-03-01 20:04 UTC (permalink / raw)
To: Ladislav Michl; +Cc: alsa-devel, kbuild test robot, kbuild-all
[-- Attachment #1.1: Type: text/plain, Size: 530 bytes --]
On Thu, Mar 01, 2018 at 09:01:56PM +0100, Ladislav Michl wrote:
> On Fri, Mar 02, 2018 at 03:45:16AM +0800, kbuild test robot wrote:
> > sound/soc/codecs/max9867.c:294:11: note: each undeclared identifier is reported only once for each function it appears in
> your topic/max9867 seems to be 4.16-rc1 based, while patch was tested
> in today's -next. Fixing it for 4.16-rc1 would mean it fails to compile
> once you merge topic branches.
> What am I supposed to do here?
Which other commits in my tree does this depend on?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [asoc:topic/max9867 2/4] sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared; did you mean 'complete'?
2018-03-01 20:04 ` Mark Brown
@ 2018-03-01 21:34 ` Ladislav Michl
2018-03-01 21:36 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Ladislav Michl @ 2018-03-01 21:34 UTC (permalink / raw)
To: Mark Brown; +Cc: alsa-devel, kbuild test robot, kbuild-all
On Thu, Mar 01, 2018 at 08:04:30PM +0000, Mark Brown wrote:
> On Thu, Mar 01, 2018 at 09:01:56PM +0100, Ladislav Michl wrote:
> > On Fri, Mar 02, 2018 at 03:45:16AM +0800, kbuild test robot wrote:
>
> > > sound/soc/codecs/max9867.c:294:11: note: each undeclared identifier is reported only once for each function it appears in
>
> > your topic/max9867 seems to be 4.16-rc1 based, while patch was tested
> > in today's -next. Fixing it for 4.16-rc1 would mean it fails to compile
> > once you merge topic branches.
>
> > What am I supposed to do here?
>
> Which other commits in my tree does this depend on?
91880a6b6ba3 ("ASoC: wm9867: replace codec to component")
Note, we have naming problem here...
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [asoc:topic/max9867 2/4] sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared; did you mean 'complete'?
2018-03-01 21:34 ` Ladislav Michl
@ 2018-03-01 21:36 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2018-03-01 21:36 UTC (permalink / raw)
To: Ladislav Michl; +Cc: alsa-devel, kbuild test robot, kbuild-all
[-- Attachment #1.1: Type: text/plain, Size: 323 bytes --]
On Thu, Mar 01, 2018 at 10:34:37PM +0100, Ladislav Michl wrote:
> On Thu, Mar 01, 2018 at 08:04:30PM +0000, Mark Brown wrote:
> > Which other commits in my tree does this depend on?
> 91880a6b6ba3 ("ASoC: wm9867: replace codec to component")
> Note, we have naming problem here...
Ah, I see. Like I say, please resend.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-01 21:36 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-01 19:45 [asoc:topic/max9867 2/4] sound/soc/codecs/max9867.c:294:11: error: 'component' undeclared; did you mean 'complete'? kbuild test robot
2018-03-01 20:01 ` Ladislav Michl
2018-03-01 20:04 ` Mark Brown
2018-03-01 21:34 ` Ladislav Michl
2018-03-01 21:36 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.