* [PATCH] staging: vc04_services: bcm2835-audio: Format multiline comment
@ 2018-03-01 20:29 Nishka Dasgupta
2018-03-02 6:23 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Nishka Dasgupta @ 2018-03-01 20:29 UTC (permalink / raw)
To: gregkh, outreachy-kernel, eric, stefan.wahren, f.fainelli, rjui,
sbranden, bcm-kernel-feedback-list
Cc: Nishka Dasgupta
Move closing "*/" of multiline comment to new line. Issue found with
checkpatch.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
index 7f4871c1..0630040 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
@@ -279,7 +279,7 @@ static int snd_bcm2835_pcm_prepare(struct snd_pcm_substream *substream)
/* notify the vchiq that it should enter spdif passthrough mode by
* setting channels=0 (see
- * https://github.com/raspberrypi/linux/issues/528)
+ * https://github.com/raspberrypi/linux/issues/528)
*/
if (chip->spdif_status & IEC958_AES0_NONAUDIO)
channels = 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vc04_services: bcm2835-audio: Format multiline comment
2018-03-01 20:29 [PATCH] staging: vc04_services: bcm2835-audio: Format multiline comment Nishka Dasgupta
@ 2018-03-02 6:23 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2018-03-02 6:23 UTC (permalink / raw)
To: Nishka Dasgupta
Cc: outreachy-kernel, eric, stefan.wahren, f.fainelli, rjui, sbranden,
bcm-kernel-feedback-list
On Fri, Mar 02, 2018 at 01:59:45AM +0530, Nishka Dasgupta wrote:
> Move closing "*/" of multiline comment to new line. Issue found with
> checkpatch.
That is not what this patch does :(
Please remember to get the descriptions correct for what the actual
change does.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] staging: vc04_services: bcm2835-audio Format multiline comment
@ 2018-03-03 18:54 Nishka Dasgupta
0 siblings, 0 replies; 3+ messages in thread
From: Nishka Dasgupta @ 2018-03-03 18:54 UTC (permalink / raw)
To: outreachy-kernel, gregkh, eric, stefan.wahren, f.fainelli, rjui,
sbranden, bcm-kernel-feedback-list
Cc: Nishka Dasgupta
Format multiline comment by moving '*/' to a new line. Issue found with
checkpatch.
Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
index 22214ee..0630040 100644
--- a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
+++ b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-pcm.c
@@ -279,7 +279,8 @@ static int snd_bcm2835_pcm_prepare(struct snd_pcm_substream *substream)
/* notify the vchiq that it should enter spdif passthrough mode by
* setting channels=0 (see
- * https://github.com/raspberrypi/linux/issues/528) */
+ * https://github.com/raspberrypi/linux/issues/528)
+ */
if (chip->spdif_status & IEC958_AES0_NONAUDIO)
channels = 0;
else
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-03 18:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-01 20:29 [PATCH] staging: vc04_services: bcm2835-audio: Format multiline comment Nishka Dasgupta
2018-03-02 6:23 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2018-03-03 18:54 [PATCH] staging: vc04_services: bcm2835-audio " Nishka Dasgupta
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.