Re: v4.16-rc0: missing includes in framebuffers break N900 compilation

From: Pavel Machek <pavel@ucw.cz>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org, ivo.g.dimitrov.75@gmail.com,
	khilman@kernel.org, tony@atomide.com, arvind.yadav.cs@gmail.com,
	aaro.koskinen@iki.fi,
	"kernel list" <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org, sre@kernel.org,
	martijn@brixit.nl,
	"Filip Matijević" <filip.matijevic.pz@gmail.com>,
	b.zolnierkie@samsung.com, abcloriens@gmail.com,
	sakari.ailus@linux.intel.com, pali.rohar@gmail.com,
	clayton@craftyguy.net, linux-omap@vger.kernel.org,
	patrikbachan@gmail.com,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	serge@hallyn.com
Subject: Re: v4.16-rc0: missing includes in framebuffers break N900 compilation
Date: Fri, 02 Mar 2018 09:12:53 +0000	[thread overview]
Message-ID: <20180302091253.GB15948@amd> (raw)
In-Reply-To: <46d9fddf-7e6d-b157-0745-6366ccd57a41@ti.com>

[-- Attachment #1: Type: text/plain, Size: 2490 bytes --]

On Mon 2018-02-26 16:05:53, Tomi Valkeinen wrote:
> v4.16-rc1 has a fix (b9058afcd6c7).

Yep, thanks. I was bisecting sound problem on N900, so this hit me...

     	       	   	     	   	      	       	    Pavel

> On 26/02/18 15:00, Pavel Machek wrote:
> > I needed this to get -rc0 to compile.
> > 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > 
> > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/dss.c b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> > index 48c6500..990f1c9 100644
> > --- a/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> > +++ b/drivers/video/fbdev/omap2/omapfb/dss/dss.c
> > @@ -38,6 +38,7 @@
> >  #include <linux/regmap.h>
> >  #include <linux/of.h>
> >  #include <linux/regulator/consumer.h>
> > +#include <linux/pinctrl/consumer.h>
> >  #include <linux/suspend.h>
> >  #include <linux/component.h>
> >  
> > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
> > index 9a13c35..4862b12 100644
> > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
> > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_phy.c
> > @@ -12,6 +12,7 @@
> >  #include <linux/err.h>
> >  #include <linux/io.h>
> >  #include <linux/platform_device.h>
> > +#include <linux/seq_file.h>
> >  #include <linux/slab.h>
> >  #include <video/omapfb_dss.h>
> >  
> > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> > index eac3665..39014e2 100644
> > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> > @@ -15,6 +15,7 @@
> >  #include <linux/err.h>
> >  #include <linux/io.h>
> >  #include <linux/platform_device.h>
> > +#include <linux/seq_file.h>
> >  #include <linux/clk.h>
> >  
> >  #include <video/omapfb_dss.h>
> > diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
> > index 705373e..e93e7a7 100644
> > --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
> > +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_wp.c
> > @@ -15,6 +15,7 @@
> >  #include <linux/io.h>
> >  #include <linux/platform_device.h>
> >  #include <video/omapfb_dss.h>
> > +#include <linux/seq_file.h>
> >  
> >  #include "dss.h"
> >  #include "hdmi.h"
> > 
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]