From: Pavel Machek <pavel@ucw.cz>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
"ext Tony Lindgren" <tony@atomide.com>,
"Mickuláš Qwertz" <abcloriens@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
"Martijn Braam" <martijn@brixit.nl>,
"Filip Matijević" <filip.matijevic.pz@gmail.com>,
"Patrik Bachan" <patrikbachan@gmail.com>,
"Ivajlo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Kevin Hilman" <khilman@kernel.org>,
serge@hallyn.com, "Mark Brown" <broonie@kernel.org>,
Linux-OMAP <linux-omap@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"Peter Ujfalusi" <peter.ujfalusi@ti.com>,
"Daniel Baluta" <daniel.baluta@gmail.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"kernel list" <linux-kernel@vger.kernel.org>,
"Andrew F . Davis" <afd@ti.com>,
"Thorsten Leemhuis" <regressions@leemhuis.info>,
clayton@craftyguy.net,
"Sakari Ailus" <sakari.ailus@linux.intel.com>
Subject: Re: regression v4.16 on Nokia N900: sound does not work
Date: Fri, 2 Mar 2018 13:14:42 +0100 [thread overview]
Message-ID: <20180302121442.GB28931@amd> (raw)
In-Reply-To: <CACRpkda-VLsMVqYx3Y6+3JtLJERhmeJZF5g4Gd9ecvgR1Nnr0A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 693 bytes --]
Hi!
> >> Ok, so this code looks pretty crazy to me: I tried removing the
> >> "of_find_spi_gpio" part, and audio started working.
> >
> > Hmm. Looks like audio is working w/o any changes, too. Not sure why
> > festival hung on me before.
>
> Does it mean that mainline is working find for you or
> do we need to look deeper into the problem in the OF
> lookup?
It now works for me.
(But take a look at the patch I sent -- I believe you are still
overwriting return values in a bad way, and code is quite confusing).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [alsa-devel] regression v4.16 on Nokia N900: sound does not work
Date: Fri, 2 Mar 2018 13:14:42 +0100 [thread overview]
Message-ID: <20180302121442.GB28931@amd> (raw)
In-Reply-To: <CACRpkda-VLsMVqYx3Y6+3JtLJERhmeJZF5g4Gd9ecvgR1Nnr0A@mail.gmail.com>
Hi!
> >> Ok, so this code looks pretty crazy to me: I tried removing the
> >> "of_find_spi_gpio" part, and audio started working.
> >
> > Hmm. Looks like audio is working w/o any changes, too. Not sure why
> > festival hung on me before.
>
> Does it mean that mainline is working find for you or
> do we need to look deeper into the problem in the OF
> lookup?
It now works for me.
(But take a look at the patch I sent -- I believe you are still
overwriting return values in a bad way, and code is quite confusing).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180302/c97368ff/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Daniel Baluta" <daniel.baluta@gmail.com>,
"Thorsten Leemhuis" <regressions@leemhuis.info>,
"Peter Ujfalusi" <peter.ujfalusi@ti.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
"Ivajlo Dimitrov" <ivo.g.dimitrov.75@gmail.com>,
"Kevin Hilman" <khilman@kernel.org>,
"ext Tony Lindgren" <tony@atomide.com>,
"Aaro Koskinen" <aaro.koskinen@iki.fi>,
"kernel list" <linux-kernel@vger.kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Martijn Braam" <martijn@brixit.nl>,
"Filip Matijević" <filip.matijevic.pz@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
"Mickuláš Qwertz" <abcloriens@gmail.com>,
"Sakari Ailus" <sakari.ailus@linux.intel.com>,
"Pali Rohár" <pali.rohar@gmail.com>,
clayton@craftyguy.net, Linux-OMAP <linux-omap@vger.kernel.org>,
"Andrew F . Davis" <afd@ti.com>,
"Patrik Bachan" <patrikbachan@gmail.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
serge@hallyn.com
Subject: Re: [alsa-devel] regression v4.16 on Nokia N900: sound does not work
Date: Fri, 2 Mar 2018 13:14:42 +0100 [thread overview]
Message-ID: <20180302121442.GB28931@amd> (raw)
In-Reply-To: <CACRpkda-VLsMVqYx3Y6+3JtLJERhmeJZF5g4Gd9ecvgR1Nnr0A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 693 bytes --]
Hi!
> >> Ok, so this code looks pretty crazy to me: I tried removing the
> >> "of_find_spi_gpio" part, and audio started working.
> >
> > Hmm. Looks like audio is working w/o any changes, too. Not sure why
> > festival hung on me before.
>
> Does it mean that mainline is working find for you or
> do we need to look deeper into the problem in the OF
> lookup?
It now works for me.
(But take a look at the patch I sent -- I believe you are still
overwriting return values in a bad way, and code is quite confusing).
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-03-02 12:14 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-24 21:46 regression v4.16 on Nokia N900:/dev/input/event6 aka AV Jack support disappeared Pavel Machek
2018-02-24 21:46 ` Pavel Machek
2018-02-24 21:46 ` Pavel Machek
2018-02-26 9:47 ` Thorsten Leemhuis
2018-02-26 9:47 ` Thorsten Leemhuis
2018-02-26 13:13 ` regression v4.16 on Nokia N900: sound does not work Pavel Machek
2018-02-26 13:13 ` Pavel Machek
2018-02-26 13:13 ` Pavel Machek
2018-02-26 14:02 ` Daniel Baluta
2018-02-26 14:02 ` [alsa-devel] " Daniel Baluta
2018-02-26 14:02 ` Daniel Baluta
2018-02-26 23:13 ` Pavel Machek
2018-02-26 23:13 ` [alsa-devel] " Pavel Machek
2018-02-26 23:13 ` Pavel Machek
2018-02-26 23:30 ` Pavel Machek
2018-02-26 23:30 ` Pavel Machek
2018-02-27 8:43 ` Linus Walleij
2018-02-27 8:43 ` [alsa-devel] " Linus Walleij
2018-02-27 8:43 ` Linus Walleij
2018-03-02 9:10 ` Pavel Machek
2018-03-02 9:10 ` [alsa-devel] " Pavel Machek
2018-03-02 9:10 ` Pavel Machek
2018-03-02 9:33 ` Linus Walleij
2018-03-02 9:33 ` [alsa-devel] " Linus Walleij
2018-03-02 9:33 ` Linus Walleij
2018-03-02 10:31 ` Pavel Machek
2018-03-02 10:31 ` [alsa-devel] " Pavel Machek
2018-03-02 10:31 ` Pavel Machek
2018-03-02 12:07 ` Linus Walleij
2018-03-02 12:07 ` [alsa-devel] " Linus Walleij
2018-03-02 12:07 ` Linus Walleij
2018-03-02 12:14 ` Pavel Machek [this message]
2018-03-02 12:14 ` Pavel Machek
2018-03-02 12:14 ` Pavel Machek
2018-03-02 12:33 ` Linus Walleij
2018-03-02 12:33 ` [alsa-devel] " Linus Walleij
2018-03-02 12:33 ` Linus Walleij
2018-03-02 11:10 ` Pavel Machek
2018-03-02 11:10 ` Pavel Machek
2018-03-02 11:10 ` Pavel Machek
2018-03-02 11:21 ` Pavel Machek
2018-03-02 11:21 ` [alsa-devel] " Pavel Machek
2018-03-02 11:21 ` Pavel Machek
2018-03-02 14:22 ` Andrew F. Davis
2018-03-02 14:22 ` [alsa-devel] " Andrew F. Davis
2018-03-02 14:22 ` Andrew F. Davis
2018-03-02 16:53 ` Pavel Machek
2018-03-02 16:53 ` [alsa-devel] " Pavel Machek
2018-03-02 16:53 ` Pavel Machek
2018-03-02 17:08 ` Russell King - ARM Linux
2018-03-02 17:08 ` [alsa-devel] " Russell King - ARM Linux
2018-03-02 17:08 ` Russell King - ARM Linux
2018-03-02 17:18 ` Andrew F. Davis
2018-03-02 17:18 ` [alsa-devel] " Andrew F. Davis
2018-03-02 17:18 ` Andrew F. Davis
2018-02-26 15:43 ` regression v4.16 on Nokia N900:/dev/input/event6 aka AV Jack support disappeared Andrew F. Davis
2018-02-26 15:43 ` Andrew F. Davis
2018-02-26 15:43 ` Andrew F. Davis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302121442.GB28931@amd \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@iki.fi \
--cc=abcloriens@gmail.com \
--cc=afd@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=clayton@craftyguy.net \
--cc=daniel.baluta@gmail.com \
--cc=filip.matijevic.pz@gmail.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=martijn@brixit.nl \
--cc=patrikbachan@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=regressions@leemhuis.info \
--cc=sakari.ailus@linux.intel.com \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.