From: "Michael S. Tsirkin" <mst@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com,
liliang.opensource@gmail.com, yang.zhang.wz@gmail.com,
quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com
Subject: [virtio-dev] Re: [PATCH v3 2/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT
Date: Fri, 2 Mar 2018 20:37:49 +0200 [thread overview]
Message-ID: <20180302203557-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1519980450-3404-3-git-send-email-wei.w.wang@intel.com>
On Fri, Mar 02, 2018 at 04:47:29PM +0800, Wei Wang wrote:
> diff --git a/include/sysemu/balloon.h b/include/sysemu/balloon.h
> index af49e19..16a2aae 100644
> --- a/include/sysemu/balloon.h
> +++ b/include/sysemu/balloon.h
...
> +typedef void (QEMUBalloonFreePageStart)(void *opaque);
> +typedef void (QEMUBalloonFreePageStop)(void *opaque);
So I think the rule is that no bitmap sync must happen
between these two, otherwise a hint might arrive and
override the sync output.
Should be documented I think.
--
MST
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Wei Wang <wei.w.wang@intel.com>
Cc: qemu-devel@nongnu.org, virtio-dev@lists.oasis-open.org,
quintela@redhat.com, dgilbert@redhat.com, pbonzini@redhat.com,
liliang.opensource@gmail.com, yang.zhang.wz@gmail.com,
quan.xu0@gmail.com, nilal@redhat.com, riel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v3 2/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT
Date: Fri, 2 Mar 2018 20:37:49 +0200 [thread overview]
Message-ID: <20180302203557-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1519980450-3404-3-git-send-email-wei.w.wang@intel.com>
On Fri, Mar 02, 2018 at 04:47:29PM +0800, Wei Wang wrote:
> diff --git a/include/sysemu/balloon.h b/include/sysemu/balloon.h
> index af49e19..16a2aae 100644
> --- a/include/sysemu/balloon.h
> +++ b/include/sysemu/balloon.h
...
> +typedef void (QEMUBalloonFreePageStart)(void *opaque);
> +typedef void (QEMUBalloonFreePageStop)(void *opaque);
So I think the rule is that no bitmap sync must happen
between these two, otherwise a hint might arrive and
override the sync output.
Should be documented I think.
--
MST
next prev parent reply other threads:[~2018-03-02 18:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 8:47 [virtio-dev] [PATCH v3 0/3] virtio-balloon: free page hint reporting support Wei Wang
2018-03-02 8:47 ` [Qemu-devel] " Wei Wang
2018-03-02 8:47 ` [virtio-dev] [PATCH v3 1/3] migration: API to clear bits of guest free pages from the dirty bitmap Wei Wang
2018-03-02 8:47 ` [Qemu-devel] " Wei Wang
2018-03-07 12:23 ` Dr. David Alan Gilbert
2018-03-07 12:57 ` [virtio-dev] " Wei Wang
2018-03-07 12:57 ` [Qemu-devel] " Wei Wang
2018-03-02 8:47 ` [virtio-dev] [PATCH v3 2/3] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT Wei Wang
2018-03-02 8:47 ` [Qemu-devel] " Wei Wang
2018-03-02 18:27 ` [virtio-dev] " Michael S. Tsirkin
2018-03-02 18:27 ` [Qemu-devel] " Michael S. Tsirkin
2018-03-02 18:37 ` Michael S. Tsirkin [this message]
2018-03-02 18:37 ` Michael S. Tsirkin
2018-03-05 3:36 ` [virtio-dev] " Wei Wang
2018-03-05 3:36 ` [Qemu-devel] " Wei Wang
2018-03-05 14:09 ` [virtio-dev] " Michael S. Tsirkin
2018-03-05 14:09 ` [Qemu-devel] " Michael S. Tsirkin
2018-03-06 1:54 ` [virtio-dev] " Wei Wang
2018-03-06 1:54 ` [Qemu-devel] " Wei Wang
2018-03-06 2:38 ` [virtio-dev] " Michael S. Tsirkin
2018-03-06 2:38 ` [Qemu-devel] " Michael S. Tsirkin
2018-03-07 13:09 ` [virtio-dev] " Wei Wang
2018-03-07 13:09 ` [Qemu-devel] " Wei Wang
2018-03-02 8:47 ` [virtio-dev] [PATCH v3 3/3] migration: use the free page hint feature from balloon Wei Wang
2018-03-02 8:47 ` [Qemu-devel] " Wei Wang
2018-03-07 12:32 ` Dr. David Alan Gilbert
2018-03-07 12:57 ` [virtio-dev] " Wei Wang
2018-03-07 12:57 ` [Qemu-devel] " Wei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302203557-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dgilbert@redhat.com \
--cc=liliang.opensource@gmail.com \
--cc=nilal@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quan.xu0@gmail.com \
--cc=quintela@redhat.com \
--cc=riel@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=wei.w.wang@intel.com \
--cc=yang.zhang.wz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.