From: Jonathan Cameron <jic23@kernel.org>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
daniel.baluta@nxp.com, kernel-janitors@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] iio: dummy: Add correct tabs and spaces to Kconfig
Date: Sat, 03 Mar 2018 15:21:03 +0000 [thread overview]
Message-ID: <20180303152103.5b7061af@archlinux> (raw)
In-Reply-To: <fc453a92429d06d769aa71072c5c0cbaa1c8d57a.1519738995.git.rodrigosiqueiramelo@gmail.com>
On Tue, 27 Feb 2018 10:46:51 -0300
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> wrote:
> Kconfig from iio/dummy does not follow the coding style recommendations.
> According to the coding-style, Lines under a config definition are
> indented with one tab, while help text is indented an additional two
> spaces. This patch adds the proper tabulation and space.
>
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/dummy/Kconfig | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/iio/dummy/Kconfig b/drivers/iio/dummy/Kconfig
> index 5a29fbd3c531..85e13b2e35bf 100644
> --- a/drivers/iio/dummy/Kconfig
> +++ b/drivers/iio/dummy/Kconfig
> @@ -9,20 +9,20 @@ config IIO_DUMMY_EVGEN
> tristate
>
> config IIO_SIMPLE_DUMMY
> - tristate "An example driver with no hardware requirements"
> - depends on IIO_SW_DEVICE
> - help
> - Driver intended mainly as documentation for how to write
> - a driver. May also be useful for testing userspace code
> - without hardware.
> + tristate "An example driver with no hardware requirements"
> + depends on IIO_SW_DEVICE
> + help
> + Driver intended mainly as documentation for how to write
> + a driver. May also be useful for testing userspace code
> + without hardware.
>
> if IIO_SIMPLE_DUMMY
>
> config IIO_SIMPLE_DUMMY_EVENTS
> - bool "Event generation support"
> - select IIO_DUMMY_EVGEN
> - help
> - Add some dummy events to the simple dummy driver.
> + bool "Event generation support"
> + select IIO_DUMMY_EVGEN
> + help
> + Add some dummy events to the simple dummy driver.
>
> config IIO_SIMPLE_DUMMY_BUFFER
> bool "Buffered capture support"
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
daniel.baluta@nxp.com, kernel-janitors@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] iio: dummy: Add correct tabs and spaces to Kconfig
Date: Sat, 3 Mar 2018 15:21:03 +0000 [thread overview]
Message-ID: <20180303152103.5b7061af@archlinux> (raw)
In-Reply-To: <fc453a92429d06d769aa71072c5c0cbaa1c8d57a.1519738995.git.rodrigosiqueiramelo@gmail.com>
On Tue, 27 Feb 2018 10:46:51 -0300
Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com> wrote:
> Kconfig from iio/dummy does not follow the coding style recommendations.
> According to the coding-style, Lines under a config definition are
> indented with one tab, while help text is indented an additional two
> spaces. This patch adds the proper tabulation and space.
>
> Signed-off-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/dummy/Kconfig | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/iio/dummy/Kconfig b/drivers/iio/dummy/Kconfig
> index 5a29fbd3c531..85e13b2e35bf 100644
> --- a/drivers/iio/dummy/Kconfig
> +++ b/drivers/iio/dummy/Kconfig
> @@ -9,20 +9,20 @@ config IIO_DUMMY_EVGEN
> tristate
>
> config IIO_SIMPLE_DUMMY
> - tristate "An example driver with no hardware requirements"
> - depends on IIO_SW_DEVICE
> - help
> - Driver intended mainly as documentation for how to write
> - a driver. May also be useful for testing userspace code
> - without hardware.
> + tristate "An example driver with no hardware requirements"
> + depends on IIO_SW_DEVICE
> + help
> + Driver intended mainly as documentation for how to write
> + a driver. May also be useful for testing userspace code
> + without hardware.
>
> if IIO_SIMPLE_DUMMY
>
> config IIO_SIMPLE_DUMMY_EVENTS
> - bool "Event generation support"
> - select IIO_DUMMY_EVGEN
> - help
> - Add some dummy events to the simple dummy driver.
> + bool "Event generation support"
> + select IIO_DUMMY_EVGEN
> + help
> + Add some dummy events to the simple dummy driver.
>
> config IIO_SIMPLE_DUMMY_BUFFER
> bool "Buffered capture support"
next prev parent reply other threads:[~2018-03-03 15:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-27 13:46 [PATCH v2 0/2] iio:dummy: Rework Kconfig Rodrigo Siqueira
2018-02-27 13:46 ` Rodrigo Siqueira
2018-02-27 13:46 ` [PATCH v2 1/2] iio: dummy: Add correct tabs and spaces to Kconfig Rodrigo Siqueira
2018-02-27 13:46 ` Rodrigo Siqueira
2018-03-03 15:21 ` Jonathan Cameron [this message]
2018-03-03 15:21 ` Jonathan Cameron
2018-02-27 13:47 ` [PATCH v2 2/2] iio:dummy: Add extra paragraphs on Kconfig Rodrigo Siqueira
2018-02-27 13:47 ` Rodrigo Siqueira
2018-03-03 15:21 ` Jonathan Cameron
2018-03-03 15:21 ` Jonathan Cameron
2018-02-27 14:26 ` [PATCH v2 0/2] iio:dummy: Rework Kconfig Daniel Baluta
2018-02-27 14:26 ` Daniel Baluta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180303152103.5b7061af@archlinux \
--to=jic23@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=rodrigosiqueiramelo@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.