[PATCH] staging: vt6655: Fix style violation for line ending in '('

[PATCH] staging: vt6655: Fix style violation for line ending in '('

[Rinkle Jain]

Replace line ending with '(' with function parameters to resolve
style issue found by checkpath.

Signed-off-by: Rinkle Jain <rinklejain96@gmail.com>
---
 drivers/staging/vt6655/baseband.h | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h
index b8ee33dcb352..432b348c81e1 100644
--- a/drivers/staging/vt6655/baseband.h
+++ b/drivers/staging/vt6655/baseband.h
@@ -47,11 +47,10 @@
 #define TOP_RATE_1M         0x00100000
 
 unsigned int
-BBuGetFrameTime(
-	unsigned char byPreambleType,
-	unsigned char byPktType,
-	unsigned int cbFrameLength,
-	unsigned short wRate
+BBuGetFrameTime(unsigned char byPreambleType,
+		unsigned char byPktType,
+		unsigned int cbFrameLength,
+		unsigned short wRate
 );
 
 void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length,
-- 
2.14.3

Re: [Outreachy kernel] [PATCH] staging: vt6655: Fix style violation for line ending in '('

[Julia Lawall]

On Sat, 3 Mar 2018, Rinkle Jain wrote:

> Replace line ending with '(' with function parameters to resolve
> style issue found by checkpath.
>
> Signed-off-by: Rinkle Jain <rinklejain96@gmail.com>
> ---
>  drivers/staging/vt6655/baseband.h | 9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h
> index b8ee33dcb352..432b348c81e1 100644
> --- a/drivers/staging/vt6655/baseband.h
> +++ b/drivers/staging/vt6655/baseband.h
> @@ -47,11 +47,10 @@
>  #define TOP_RATE_1M         0x00100000
>
>  unsigned int
> -BBuGetFrameTime(
> -	unsigned char byPreambleType,
> -	unsigned char byPktType,
> -	unsigned int cbFrameLength,
> -	unsigned short wRate
> +BBuGetFrameTime(unsigned char byPreambleType,
> +		unsigned char byPktType,
> +		unsigned int cbFrameLength,
> +		unsigned short wRate
>  );

I think that the code could still be improved, to use more of the
horizontal space and not leave the ); on a line by itself.  Look around in
the kernel outside staging at .h files to see how other function
prototype declarations look.

julia

>
>  void vnt_get_phy_field(struct vnt_private *priv, u32 frame_length,
> --
> 2.14.3
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180303152244.GA9913%40tic-tac.
> For more options, visit https://groups.google.com/d/optout.
>