* [PATCH] staging: ipx: Replace printk() with appropriate pr_*() macro
@ 2018-03-04 8:59 ` Arushi Singhal
0 siblings, 0 replies; 5+ messages in thread
From: Arushi Singhal @ 2018-03-04 8:59 UTC (permalink / raw)
To: gregkh; +Cc: netdev, devel, linux-kernel, outreachy-kernel
Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
Replace printks having a log level with the appropriate pr_*() macros.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/staging/ipx/af_ipx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ipx/af_ipx.c b/drivers/staging/ipx/af_ipx.c
index d21a9d1..27f4461 100644
--- a/drivers/staging/ipx/af_ipx.c
+++ b/drivers/staging/ipx/af_ipx.c
@@ -744,7 +744,7 @@ static void ipxitf_discover_netnum(struct ipx_interface *intrfc,
intrfc->if_netnum = cb->ipx_source_net;
ipxitf_add_local_route(intrfc);
} else {
- printk(KERN_WARNING "IPX: Network number collision "
+ pr_warn("IPX: Network number collision "
"%lx\n %s %s and %s %s\n",
(unsigned long) ntohl(cb->ipx_source_net),
ipx_device_name(i),
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] staging: ipx: Replace printk() with appropriate pr_*() macro
@ 2018-03-04 8:59 ` Arushi Singhal
0 siblings, 0 replies; 5+ messages in thread
From: Arushi Singhal @ 2018-03-04 8:59 UTC (permalink / raw)
To: gregkh; +Cc: devel, netdev, linux-kernel, outreachy-kernel
Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
Replace printks having a log level with the appropriate pr_*() macros.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/staging/ipx/af_ipx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ipx/af_ipx.c b/drivers/staging/ipx/af_ipx.c
index d21a9d1..27f4461 100644
--- a/drivers/staging/ipx/af_ipx.c
+++ b/drivers/staging/ipx/af_ipx.c
@@ -744,7 +744,7 @@ static void ipxitf_discover_netnum(struct ipx_interface *intrfc,
intrfc->if_netnum = cb->ipx_source_net;
ipxitf_add_local_route(intrfc);
} else {
- printk(KERN_WARNING "IPX: Network number collision "
+ pr_warn("IPX: Network number collision "
"%lx\n %s %s and %s %s\n",
(unsigned long) ntohl(cb->ipx_source_net),
ipx_device_name(i),
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] staging: ipx: Replace printk() with appropriate pr_*() macro
@ 2018-03-04 8:59 ` Arushi Singhal
0 siblings, 0 replies; 5+ messages in thread
From: Arushi Singhal @ 2018-03-04 8:59 UTC (permalink / raw)
To: gregkh; +Cc: devel, netdev, linux-kernel, outreachy-kernel
Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
Replace printks having a log level with the appropriate pr_*() macros.
Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
---
drivers/staging/ipx/af_ipx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ipx/af_ipx.c b/drivers/staging/ipx/af_ipx.c
index d21a9d1..27f4461 100644
--- a/drivers/staging/ipx/af_ipx.c
+++ b/drivers/staging/ipx/af_ipx.c
@@ -744,7 +744,7 @@ static void ipxitf_discover_netnum(struct ipx_interface *intrfc,
intrfc->if_netnum = cb->ipx_source_net;
ipxitf_add_local_route(intrfc);
} else {
- printk(KERN_WARNING "IPX: Network number collision "
+ pr_warn("IPX: Network number collision "
"%lx\n %s %s and %s %s\n",
(unsigned long) ntohl(cb->ipx_source_net),
ipx_device_name(i),
--
2.7.4
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] staging: ipx: Replace printk() with appropriate pr_*() macro
2018-03-04 8:59 ` Arushi Singhal
@ 2018-03-04 13:29 ` Greg KH
-1 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2018-03-04 13:29 UTC (permalink / raw)
To: Arushi Singhal; +Cc: devel, netdev, linux-kernel, outreachy-kernel
On Sun, Mar 04, 2018 at 02:29:35PM +0530, Arushi Singhal wrote:
> Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
> Replace printks having a log level with the appropriate pr_*() macros.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/ipx/af_ipx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ipx/af_ipx.c b/drivers/staging/ipx/af_ipx.c
> index d21a9d1..27f4461 100644
> --- a/drivers/staging/ipx/af_ipx.c
> +++ b/drivers/staging/ipx/af_ipx.c
> @@ -744,7 +744,7 @@ static void ipxitf_discover_netnum(struct ipx_interface *intrfc,
> intrfc->if_netnum = cb->ipx_source_net;
> ipxitf_add_local_route(intrfc);
> } else {
> - printk(KERN_WARNING "IPX: Network number collision "
> + pr_warn("IPX: Network number collision "
It is a driver, so it would be best to use dev_warn() or even better
yet, net_warn(). Please try to make that change instead.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread* [Outreachy kernel] Re: [PATCH] staging: ipx: Replace printk() with appropriate pr_*() macro
@ 2018-03-04 13:29 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2018-03-04 13:29 UTC (permalink / raw)
To: Arushi Singhal; +Cc: devel, netdev, linux-kernel, outreachy-kernel
On Sun, Mar 04, 2018 at 02:29:35PM +0530, Arushi Singhal wrote:
> Using pr_<loglevel>() is more concise than printk(KERN_<LOGLEVEL>).
> Replace printks having a log level with the appropriate pr_*() macros.
>
> Signed-off-by: Arushi Singhal <arushisinghal19971997@gmail.com>
> ---
> drivers/staging/ipx/af_ipx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/ipx/af_ipx.c b/drivers/staging/ipx/af_ipx.c
> index d21a9d1..27f4461 100644
> --- a/drivers/staging/ipx/af_ipx.c
> +++ b/drivers/staging/ipx/af_ipx.c
> @@ -744,7 +744,7 @@ static void ipxitf_discover_netnum(struct ipx_interface *intrfc,
> intrfc->if_netnum = cb->ipx_source_net;
> ipxitf_add_local_route(intrfc);
> } else {
> - printk(KERN_WARNING "IPX: Network number collision "
> + pr_warn("IPX: Network number collision "
It is a driver, so it would be best to use dev_warn() or even better
yet, net_warn(). Please try to make that change instead.
thanks,
greg k-h
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
To post to this group, send email to outreachy-kernel@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180304132901.GA4222%40kroah.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-04 13:39 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-04 8:59 [PATCH] staging: ipx: Replace printk() with appropriate pr_*() macro Arushi Singhal
2018-03-04 8:59 ` Arushi Singhal
2018-03-04 8:59 ` Arushi Singhal
2018-03-04 13:29 ` Greg KH
2018-03-04 13:29 ` [Outreachy kernel] " Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.