All of lore.kernel.org
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] scripts/kallsyms: filter arm64's __efistub_ symbols
Date: Mon, 5 Mar 2018 12:43:27 +0000	[thread overview]
Message-ID: <20180305124327.GE8571@arm.com> (raw)
In-Reply-To: <20180301171901.1134-1-ard.biesheuvel@linaro.org>

On Thu, Mar 01, 2018 at 05:19:01PM +0000, Ard Biesheuvel wrote:
> On arm64, the EFI stub and the kernel proper are essentially the same
> binary, although the EFI stub executes at a different virtual address
> as the kernel. For this reason, the EFI stub is restricted in the
> symbols it can link to, which is ensured by prefixing all EFI stub
> symbols with __efistub_ (and emitting __efistub_ prefixed aliases for
> routines that may be shared between the core kernel and the stub)
> 
> These symbols are leaking into kallsyms, polluting the namespace, so
> let's filter them explicitly.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  scripts/kallsyms.c | 1 +
>  1 file changed, 1 insertion(+)

Thanks, I'll take this via arm64.

Will

> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 9ee9bf7fd1a2..1dd24c5b9b47 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -221,6 +221,7 @@ static int symbol_valid(struct sym_entry *s)
>  
>  	static char *special_prefixes[] = {
>  		"__crc_",		/* modversions */
> +		"__efistub_",		/* arm64 EFI stub namespace */
>  		NULL };
>  
>  	static char *special_suffixes[] = {
> -- 
> 2.11.0
> 

WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, catalin.marinas@arm.com
Subject: Re: [PATCH] scripts/kallsyms: filter arm64's __efistub_ symbols
Date: Mon, 5 Mar 2018 12:43:27 +0000	[thread overview]
Message-ID: <20180305124327.GE8571@arm.com> (raw)
In-Reply-To: <20180301171901.1134-1-ard.biesheuvel@linaro.org>

On Thu, Mar 01, 2018 at 05:19:01PM +0000, Ard Biesheuvel wrote:
> On arm64, the EFI stub and the kernel proper are essentially the same
> binary, although the EFI stub executes at a different virtual address
> as the kernel. For this reason, the EFI stub is restricted in the
> symbols it can link to, which is ensured by prefixing all EFI stub
> symbols with __efistub_ (and emitting __efistub_ prefixed aliases for
> routines that may be shared between the core kernel and the stub)
> 
> These symbols are leaking into kallsyms, polluting the namespace, so
> let's filter them explicitly.
> 
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  scripts/kallsyms.c | 1 +
>  1 file changed, 1 insertion(+)

Thanks, I'll take this via arm64.

Will

> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 9ee9bf7fd1a2..1dd24c5b9b47 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -221,6 +221,7 @@ static int symbol_valid(struct sym_entry *s)
>  
>  	static char *special_prefixes[] = {
>  		"__crc_",		/* modversions */
> +		"__efistub_",		/* arm64 EFI stub namespace */
>  		NULL };
>  
>  	static char *special_suffixes[] = {
> -- 
> 2.11.0
> 

  reply	other threads:[~2018-03-05 12:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-01 17:19 [PATCH] scripts/kallsyms: filter arm64's __efistub_ symbols Ard Biesheuvel
2018-03-01 17:19 ` Ard Biesheuvel
2018-03-05 12:43 ` Will Deacon [this message]
2018-03-05 12:43   ` Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180305124327.GE8571@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.