All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
	Alexander Usyskin <alexander.usyskin@intel.com>,
	linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] tpm: tpm-interface: fix tpm_transmit/_cmd  kdoc
Date: Mon, 5 Mar 2018 20:09:44 +0200	[thread overview]
Message-ID: <20180305180944.GC6220@linux.intel.com> (raw)
In-Reply-To: <20180305124826.5160-1-tomas.winkler@intel.com>

On Mon, Mar 05, 2018 at 02:48:25PM +0200, Tomas Winkler wrote:
> Fix tmp_ -> tpm_ typo and add reference to 'space' parameter
> in kdoc for tpm_transmit and tpm_transmit_cmd functions.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  drivers/char/tpm/tpm-interface.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
> index 64dbec078c1b..cafec634181a 100644
> --- a/drivers/char/tpm/tpm-interface.c
> +++ b/drivers/char/tpm/tpm-interface.c
> @@ -399,9 +399,10 @@ static void tpm_relinquish_locality(struct tpm_chip *chip)
>  }
>  
>  /**
> - * tmp_transmit - Internal kernel interface to transmit TPM commands.
> + * tpm_transmit - Internal kernel interface to transmit TPM commands.
>   *
>   * @chip: TPM chip to use
> + * @space: tpm space
>   * @buf: TPM command buffer
>   * @bufsiz: length of the TPM command buffer
>   * @flags: tpm transmit flags - bitmap
> @@ -549,10 +550,11 @@ ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space,
>  }
>  
>  /**
> - * tmp_transmit_cmd - send a tpm command to the device
> + * tpm_transmit_cmd - send a tpm command to the device
>   *    The function extracts tpm out header return code
>   *
>   * @chip: TPM chip to use
> + * @space: tpm space
>   * @buf: TPM command buffer
>   * @bufsiz: length of the buffer
>   * @min_rsp_body_length: minimum expected length of response body
> -- 
> 2.14.3
> 

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 1/2] tpm: tpm-interface: fix tpm_transmit/_cmd  kdoc
Date: Mon, 5 Mar 2018 20:09:44 +0200	[thread overview]
Message-ID: <20180305180944.GC6220@linux.intel.com> (raw)
In-Reply-To: <20180305124826.5160-1-tomas.winkler@intel.com>

On Mon, Mar 05, 2018 at 02:48:25PM +0200, Tomas Winkler wrote:
> Fix tmp_ -> tpm_ typo and add reference to 'space' parameter
> in kdoc for tpm_transmit and tpm_transmit_cmd functions.
> 
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> ---
>  drivers/char/tpm/tpm-interface.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/char/tpm/tpm-interface.c b/drivers/char/tpm/tpm-interface.c
> index 64dbec078c1b..cafec634181a 100644
> --- a/drivers/char/tpm/tpm-interface.c
> +++ b/drivers/char/tpm/tpm-interface.c
> @@ -399,9 +399,10 @@ static void tpm_relinquish_locality(struct tpm_chip *chip)
>  }
>  
>  /**
> - * tmp_transmit - Internal kernel interface to transmit TPM commands.
> + * tpm_transmit - Internal kernel interface to transmit TPM commands.
>   *
>   * @chip: TPM chip to use
> + * @space: tpm space
>   * @buf: TPM command buffer
>   * @bufsiz: length of the TPM command buffer
>   * @flags: tpm transmit flags - bitmap
> @@ -549,10 +550,11 @@ ssize_t tpm_transmit(struct tpm_chip *chip, struct tpm_space *space,
>  }
>  
>  /**
> - * tmp_transmit_cmd - send a tpm command to the device
> + * tpm_transmit_cmd - send a tpm command to the device
>   *    The function extracts tpm out header return code
>   *
>   * @chip: TPM chip to use
> + * @space: tpm space
>   * @buf: TPM command buffer
>   * @bufsiz: length of the buffer
>   * @min_rsp_body_length: minimum expected length of response body
> -- 
> 2.14.3
> 

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>

/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-03-05 18:09 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05 12:48 [PATCH 1/2] tpm: tpm-interface: fix tpm_transmit/_cmd kdoc Tomas Winkler
2018-03-05 12:48 ` Tomas Winkler
2018-03-05 12:48 ` [PATCH 2/2] tpm: fix buffer type in tpm_transimt/_cmd Tomas Winkler
2018-03-05 12:48   ` Tomas Winkler
2018-03-05 18:10   ` Jarkko Sakkinen
2018-03-05 18:10     ` Jarkko Sakkinen
2018-03-05 18:12   ` Jarkko Sakkinen
2018-03-05 18:12     ` Jarkko Sakkinen
2018-03-05 18:09 ` Jarkko Sakkinen [this message]
2018-03-05 18:09   ` [PATCH 1/2] tpm: tpm-interface: fix tpm_transmit/_cmd kdoc Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180305180944.GC6220@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=alexander.usyskin@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.