From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-trivial@nongnu.org,
"Peter Maydell" <peter.maydell@linaro.org>,
"Michael Walle" <michael@walle.cc>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Yongbok Kim" <yongbok.kim@mips.com>,
"Marek Vasut" <marex@denx.de>, "Alexander Graf" <agraf@suse.de>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Marcel Apfelbaum" <marcel@redhat.com>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Richard Henderson" <rth@twiddle.net>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"open list:ARM" <qemu-arm@nongnu.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Chris Wulff" <crwulff@gmail.com>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Paul Burton" <paul.burton@mips.com>,
"open list:New World" <qemu-ppc@nongnu.org>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-trivial] [Qemu-devel] [RFC PATCH v2 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h"
Date: Mon, 5 Mar 2018 18:57:54 +0000 [thread overview]
Message-ID: <20180305185754.GE17368@redhat.com> (raw)
In-Reply-To: <20180305112732.26471-3-f4bug@amsat.org>
On Mon, Mar 05, 2018 at 08:27:04AM -0300, Philippe Mathieu-Daudé wrote:
> These files were including "qemu/cutils.h" to use the byte-based size
> definitions, now available in "qemu/cunits.h".
I know I'm "complaining" about bike-shed colour here....
Feels like just calling it units.h is sufficient - all our .h code is
C code so don't need reminding of it by filename, particularly since
we're avoiding system header clash by using the qemu/ prefix on #includes.
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Regardless of whether you rename it or not though,
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, "Michael Walle" <michael@walle.cc>,
"Yongbok Kim" <yongbok.kim@mips.com>,
"Marek Vasut" <marex@denx.de>,
qemu-trivial@nongnu.org, "Alexander Graf" <agraf@suse.de>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Marcel Apfelbaum" <marcel@redhat.com>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Richard Henderson" <rth@twiddle.net>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"open list:ARM" <qemu-arm@nongnu.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Chris Wulff" <crwulff@gmail.com>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Paul Burton" <paul.burton@mips.com>,
"open list:New World" <qemu-ppc@nongnu.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: [Qemu-arm] [Qemu-devel] [RFC PATCH v2 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h"
Date: Mon, 5 Mar 2018 18:57:54 +0000 [thread overview]
Message-ID: <20180305185754.GE17368@redhat.com> (raw)
In-Reply-To: <20180305112732.26471-3-f4bug@amsat.org>
On Mon, Mar 05, 2018 at 08:27:04AM -0300, Philippe Mathieu-Daudé wrote:
> These files were including "qemu/cutils.h" to use the byte-based size
> definitions, now available in "qemu/cunits.h".
I know I'm "complaining" about bike-shed colour here....
Feels like just calling it units.h is sufficient - all our .h code is
C code so don't need reminding of it by filename, particularly since
we're avoiding system header clash by using the qemu/ prefix on #includes.
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Regardless of whether you rename it or not though,
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: qemu-trivial@nongnu.org,
"Peter Maydell" <peter.maydell@linaro.org>,
"Michael Walle" <michael@walle.cc>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org, "Gerd Hoffmann" <kraxel@redhat.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Yongbok Kim" <yongbok.kim@mips.com>,
"Marek Vasut" <marex@denx.de>, "Alexander Graf" <agraf@suse.de>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Marcel Apfelbaum" <marcel@redhat.com>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Richard Henderson" <rth@twiddle.net>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"open list:ARM" <qemu-arm@nongnu.org>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Chris Wulff" <crwulff@gmail.com>,
"Subbaraya Sundeep" <sundeep.lkml@gmail.com>,
"Paul Burton" <paul.burton@mips.com>,
"open list:New World" <qemu-ppc@nongnu.org>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [RFC PATCH v2 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h"
Date: Mon, 5 Mar 2018 18:57:54 +0000 [thread overview]
Message-ID: <20180305185754.GE17368@redhat.com> (raw)
In-Reply-To: <20180305112732.26471-3-f4bug@amsat.org>
On Mon, Mar 05, 2018 at 08:27:04AM -0300, Philippe Mathieu-Daudé wrote:
> These files were including "qemu/cutils.h" to use the byte-based size
> definitions, now available in "qemu/cunits.h".
I know I'm "complaining" about bike-shed colour here....
Feels like just calling it units.h is sufficient - all our .h code is
C code so don't need reminding of it by filename, particularly since
we're avoiding system header clash by using the qemu/ prefix on #includes.
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Regardless of whether you rename it or not though,
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-03-05 18:58 UTC|newest]
Thread overview: 92+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 11:27 [Qemu-trivial] [PATCH v2 00/30] hw: use the BYTE-based definitions when useful Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 01/30] util/cutils: extract byte-based definitions into a new header: "qemu/cunits.h" Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [RFC PATCH v2 02/30] hw: include "qemu/cunits.h" and clean unused "qemu/cutils.h" Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-arm] " Philippe Mathieu-Daudé
2018-03-05 18:57 ` Daniel P. Berrangé [this message]
2018-03-05 18:57 ` [Qemu-devel] " Daniel P. Berrangé
2018-03-05 18:57 ` [Qemu-arm] " Daniel P. Berrangé
2018-03-05 19:01 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-03-05 19:01 ` [Qemu-devel] [Qemu-arm] " Philippe Mathieu-Daudé
2018-03-05 19:01 ` [Qemu-arm] [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 03/30] hw/block/nvme: include the "qemu/cutils.h" in the source file Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 04/30] hw/lm32/milkymist: remove unused include Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 05/30] hw/mips/r4k: constify params_size Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 06/30] hw/mips: use the BYTE-based definitions Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 07/30] hw/arm: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` Philippe Mathieu-Daudé
2018-03-06 15:46 ` [Qemu-trivial] " Alex Bennée
2018-03-06 15:46 ` Alex Bennée
2018-03-06 15:46 ` Alex Bennée
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 08/30] hw/i386: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` Philippe Mathieu-Daudé
2018-03-05 18:51 ` [Qemu-trivial] " Anthony PERARD
2018-03-05 18:51 ` [Qemu-devel] " Anthony PERARD
2018-03-05 18:51 ` Anthony PERARD
2018-03-06 12:43 ` [Qemu-trivial] [Qemu-devel] " Igor Mammedov
2018-03-06 12:43 ` Igor Mammedov
2018-03-06 12:43 ` Igor Mammedov
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 09/30] hw/sparc: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 10/30] hw/ppc: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 11/30] hw/s390x: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 12/30] hw/hppa: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 13/30] hw/xtensa: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 14/30] hw/alpha: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 15/30] hw/lm32: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 16/30] hw/sh4: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 17/30] hw/tricore: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 18/30] hw/microblaze: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 19/30] hw/nios2: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 20/30] hw/cris: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 21/30] hw/misc: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 19:02 ` Jiri Slaby
2018-03-05 19:05 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-03-05 19:05 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [PATCH v2 22/30] hw/display: " Philippe Mathieu-Daudé
2018-03-05 18:52 ` [Qemu-trivial] " Anthony PERARD
2018-03-05 18:52 ` [Qemu-devel] " Anthony PERARD
2018-03-05 18:52 ` Anthony PERARD
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 23/30] hw/net: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-arm] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 24/30] hw/ipack: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 25/30] hw/scsi: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 26/30] hw/smbios: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-06 9:02 ` [Qemu-trivial] " Igor Mammedov
2018-03-06 9:02 ` Igor Mammedov
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 27/30] vfio/pci: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 28/30] ivshmem: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 29/30] tpm: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-trivial] [PATCH v2 30/30] xen: " Philippe Mathieu-Daudé
2018-03-05 11:27 ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-03-05 11:27 ` Philippe Mathieu-Daudé
2018-03-05 18:53 ` [Qemu-trivial] " Anthony PERARD
2018-03-05 18:53 ` [Qemu-devel] " Anthony PERARD
2018-03-05 18:53 ` Anthony PERARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305185754.GE17368@redhat.com \
--to=berrange@redhat.com \
--cc=agraf@suse.de \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=crwulff@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=hpoussin@reactos.org \
--cc=kraxel@redhat.com \
--cc=marcel@redhat.com \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=michael@walle.cc \
--cc=paul.burton@mips.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=rth@twiddle.net \
--cc=samuel.thibault@ens-lyon.org \
--cc=sundeep.lkml@gmail.com \
--cc=yongbok.kim@mips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.