From: Christoph Hellwig <hch@lst.de>
To: viro@zeniv.linux.org.uk
Cc: Avi Kivity <avi@scylladb.com>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
netdev@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 21/36] net/dccp: convert to ->poll_mask
Date: Mon, 5 Mar 2018 13:27:28 -0800 [thread overview]
Message-ID: <20180305212743.16664-22-hch@lst.de> (raw)
In-Reply-To: <20180305212743.16664-1-hch@lst.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
net/dccp/dccp.h | 3 +--
net/dccp/ipv4.c | 2 +-
net/dccp/ipv6.c | 2 +-
net/dccp/proto.c | 13 ++-----------
4 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h
index f91e3816806b..0ea2ee56ac1b 100644
--- a/net/dccp/dccp.h
+++ b/net/dccp/dccp.h
@@ -316,8 +316,7 @@ int dccp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, int nonblock,
int flags, int *addr_len);
void dccp_shutdown(struct sock *sk, int how);
int inet_dccp_listen(struct socket *sock, int backlog);
-__poll_t dccp_poll(struct file *file, struct socket *sock,
- poll_table *wait);
+__poll_t dccp_poll_mask(struct socket *sock, __poll_t events);
int dccp_v4_connect(struct sock *sk, struct sockaddr *uaddr, int addr_len);
void dccp_req_err(struct sock *sk, u64 seq);
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c
index e65fcb45c3f6..e8476f319efd 100644
--- a/net/dccp/ipv4.c
+++ b/net/dccp/ipv4.c
@@ -983,7 +983,7 @@ static const struct proto_ops inet_dccp_ops = {
.accept = inet_accept,
.getname = inet_getname,
/* FIXME: work on tcp_poll to rename it to inet_csk_poll */
- .poll = dccp_poll,
+ .poll_mask = dccp_poll_mask,
.ioctl = inet_ioctl,
/* FIXME: work on inet_listen to rename it to sock_common_listen */
.listen = inet_dccp_listen,
diff --git a/net/dccp/ipv6.c b/net/dccp/ipv6.c
index 5df7857fc0f3..f0aac8e4b888 100644
--- a/net/dccp/ipv6.c
+++ b/net/dccp/ipv6.c
@@ -1069,7 +1069,7 @@ static const struct proto_ops inet6_dccp_ops = {
.socketpair = sock_no_socketpair,
.accept = inet_accept,
.getname = inet6_getname,
- .poll = dccp_poll,
+ .poll_mask = dccp_poll_mask,
.ioctl = inet6_ioctl,
.listen = inet_dccp_listen,
.shutdown = inet_shutdown,
diff --git a/net/dccp/proto.c b/net/dccp/proto.c
index 15bdc002d90c..26816032a7c2 100644
--- a/net/dccp/proto.c
+++ b/net/dccp/proto.c
@@ -314,20 +314,11 @@ int dccp_disconnect(struct sock *sk, int flags)
EXPORT_SYMBOL_GPL(dccp_disconnect);
-/*
- * Wait for a DCCP event.
- *
- * Note that we don't need to lock the socket, as the upper poll layers
- * take care of normal races (between the test and the event) and we don't
- * go look at any of the socket buffers directly.
- */
-__poll_t dccp_poll(struct file *file, struct socket *sock,
- poll_table *wait)
+__poll_t dccp_poll_mask(struct socket *sock, __poll_t events)
{
__poll_t mask;
struct sock *sk = sock->sk;
- sock_poll_wait(file, sk_sleep(sk), wait);
if (sk->sk_state == DCCP_LISTEN)
return inet_csk_listen_poll(sk);
@@ -369,7 +360,7 @@ __poll_t dccp_poll(struct file *file, struct socket *sock,
return mask;
}
-EXPORT_SYMBOL_GPL(dccp_poll);
+EXPORT_SYMBOL_GPL(dccp_poll_mask);
int dccp_ioctl(struct sock *sk, int cmd, unsigned long arg)
{
--
2.14.2
--
To unsubscribe, send a message with 'unsubscribe linux-aio' in
the body to majordomo@kvack.org. For more info on Linux AIO,
see: http://www.kvack.org/aio/
Don't email: <a href=mailto:"aart@kvack.org">aart@kvack.org</a>
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: viro@zeniv.linux.org.uk
Cc: Avi Kivity <avi@scylladb.com>,
linux-aio@kvack.org, linux-fsdevel@vger.kernel.org,
netdev@vger.kernel.org, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 21/36] net/dccp: convert to ->poll_mask
Date: Mon, 5 Mar 2018 13:27:28 -0800 [thread overview]
Message-ID: <20180305212743.16664-22-hch@lst.de> (raw)
In-Reply-To: <20180305212743.16664-1-hch@lst.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
net/dccp/dccp.h | 3 +--
net/dccp/ipv4.c | 2 +-
net/dccp/ipv6.c | 2 +-
net/dccp/proto.c | 13 ++-----------
4 files changed, 5 insertions(+), 15 deletions(-)
diff --git a/net/dccp/dccp.h b/net/dccp/dccp.h
index f91e3816806b..0ea2ee56ac1b 100644
--- a/net/dccp/dccp.h
+++ b/net/dccp/dccp.h
@@ -316,8 +316,7 @@ int dccp_recvmsg(struct sock *sk, struct msghdr *msg, size_t len, int nonblock,
int flags, int *addr_len);
void dccp_shutdown(struct sock *sk, int how);
int inet_dccp_listen(struct socket *sock, int backlog);
-__poll_t dccp_poll(struct file *file, struct socket *sock,
- poll_table *wait);
+__poll_t dccp_poll_mask(struct socket *sock, __poll_t events);
int dccp_v4_connect(struct sock *sk, struct sockaddr *uaddr, int addr_len);
void dccp_req_err(struct sock *sk, u64 seq);
diff --git a/net/dccp/ipv4.c b/net/dccp/ipv4.c
index e65fcb45c3f6..e8476f319efd 100644
--- a/net/dccp/ipv4.c
+++ b/net/dccp/ipv4.c
@@ -983,7 +983,7 @@ static const struct proto_ops inet_dccp_ops = {
.accept = inet_accept,
.getname = inet_getname,
/* FIXME: work on tcp_poll to rename it to inet_csk_poll */
- .poll = dccp_poll,
+ .poll_mask = dccp_poll_mask,
.ioctl = inet_ioctl,
/* FIXME: work on inet_listen to rename it to sock_common_listen */
.listen = inet_dccp_listen,
diff --git a/net/dccp/ipv6.c b/net/dccp/ipv6.c
index 5df7857fc0f3..f0aac8e4b888 100644
--- a/net/dccp/ipv6.c
+++ b/net/dccp/ipv6.c
@@ -1069,7 +1069,7 @@ static const struct proto_ops inet6_dccp_ops = {
.socketpair = sock_no_socketpair,
.accept = inet_accept,
.getname = inet6_getname,
- .poll = dccp_poll,
+ .poll_mask = dccp_poll_mask,
.ioctl = inet6_ioctl,
.listen = inet_dccp_listen,
.shutdown = inet_shutdown,
diff --git a/net/dccp/proto.c b/net/dccp/proto.c
index 15bdc002d90c..26816032a7c2 100644
--- a/net/dccp/proto.c
+++ b/net/dccp/proto.c
@@ -314,20 +314,11 @@ int dccp_disconnect(struct sock *sk, int flags)
EXPORT_SYMBOL_GPL(dccp_disconnect);
-/*
- * Wait for a DCCP event.
- *
- * Note that we don't need to lock the socket, as the upper poll layers
- * take care of normal races (between the test and the event) and we don't
- * go look at any of the socket buffers directly.
- */
-__poll_t dccp_poll(struct file *file, struct socket *sock,
- poll_table *wait)
+__poll_t dccp_poll_mask(struct socket *sock, __poll_t events)
{
__poll_t mask;
struct sock *sk = sock->sk;
- sock_poll_wait(file, sk_sleep(sk), wait);
if (sk->sk_state == DCCP_LISTEN)
return inet_csk_listen_poll(sk);
@@ -369,7 +360,7 @@ __poll_t dccp_poll(struct file *file, struct socket *sock,
return mask;
}
-EXPORT_SYMBOL_GPL(dccp_poll);
+EXPORT_SYMBOL_GPL(dccp_poll_mask);
int dccp_ioctl(struct sock *sk, int cmd, unsigned long arg)
{
--
2.14.2
next prev parent reply other threads:[~2018-03-05 21:27 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 21:27 aio poll, io_pgetevents and a new in-kernel poll API V5 Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 01/36] aio: don't print the page size at boot time Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-20 0:11 ` Darrick J. Wong
2018-03-20 0:11 ` Darrick J. Wong
2018-03-05 21:27 ` [PATCH 02/36] aio: remove an outdated comment in aio_complete Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-20 0:12 ` Darrick J. Wong
2018-03-20 0:12 ` Darrick J. Wong
2018-03-05 21:27 ` [PATCH 03/36] aio: refactor read/write iocb setup Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-20 0:19 ` Darrick J. Wong
2018-03-20 0:19 ` Darrick J. Wong
2018-03-05 21:27 ` [PATCH 04/36] aio: sanitize ki_list handling Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-20 0:21 ` Darrick J. Wong
2018-03-20 0:21 ` Darrick J. Wong
2018-03-05 21:27 ` [PATCH 05/36] aio: simplify cancellation Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-20 0:25 ` Darrick J. Wong
2018-03-20 0:25 ` Darrick J. Wong
2018-03-05 21:27 ` [PATCH 06/36] aio: delete iocbs from the active_reqs list in kiocb_cancel Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-20 0:34 ` Darrick J. Wong
2018-03-20 0:34 ` Darrick J. Wong
2018-03-05 21:27 ` [PATCH 07/36] aio: add delayed cancel support Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-20 3:19 ` Darrick J. Wong
2018-03-20 3:19 ` Darrick J. Wong
2018-03-20 15:20 ` Christoph Hellwig
2018-03-20 15:20 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 08/36] aio: implement io_pgetevents Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:51 ` Jeff Moyer
2018-03-05 21:51 ` Jeff Moyer
2018-03-20 2:12 ` Darrick J. Wong
2018-03-20 2:12 ` Darrick J. Wong
2018-03-20 15:22 ` Christoph Hellwig
2018-03-20 15:22 ` Christoph Hellwig
2018-03-20 15:30 ` Jeff Moyer
2018-03-20 15:30 ` Jeff Moyer
2018-03-20 15:31 ` Christoph Hellwig
2018-03-20 15:31 ` Christoph Hellwig
2018-03-20 15:34 ` Jeff Moyer
2018-03-20 15:34 ` Jeff Moyer
2018-03-05 21:27 ` [PATCH 09/36] fs: unexport poll_schedule_timeout Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-20 2:13 ` Darrick J. Wong
2018-03-20 2:13 ` Darrick J. Wong
2018-03-05 21:27 ` [PATCH 10/36] fs: cleanup do_pollfd Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-20 2:14 ` Darrick J. Wong
2018-03-20 2:14 ` Darrick J. Wong
2018-03-05 21:27 ` [PATCH 11/36] fs: update documentation for __poll_t Christoph Hellwig
2018-03-20 2:19 ` Darrick J. Wong
2018-03-20 2:19 ` Darrick J. Wong
2018-03-05 21:27 ` [PATCH 12/36] fs: add new vfs_poll and file_can_poll helpers Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-20 2:27 ` Darrick J. Wong
2018-03-20 2:27 ` Darrick J. Wong
2018-03-05 21:27 ` [PATCH 13/36] fs: introduce new ->get_poll_head and ->poll_mask methods Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-20 3:29 ` Darrick J. Wong
2018-03-20 3:29 ` Darrick J. Wong
2018-03-20 15:39 ` Christoph Hellwig
2018-03-20 15:39 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 14/36] aio: implement IOCB_CMD_POLL Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:51 ` Jeff Moyer
2018-03-05 21:27 ` [PATCH 15/36] net: refactor socket_poll Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 16/36] net: add support for ->poll_mask in proto_ops Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 17/36] net: remove sock_no_poll Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 18/36] net/tcp: convert to ->poll_mask Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 19/36] net/unix: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 20/36] net: convert datagram_poll users tp ->poll_mask Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig [this message]
2018-03-05 21:27 ` [PATCH 21/36] net/dccp: convert to ->poll_mask Christoph Hellwig
2018-03-05 21:27 ` [PATCH 22/36] net/atm: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 23/36] net/vmw_vsock: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 24/36] net/tipc: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 25/36] net/sctp: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 26/36] net/bluetooth: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 27/36] net/caif: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 28/36] net/nfc: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 29/36] net/phonet: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 30/36] net/iucv: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 31/36] net/rxrpc: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 32/36] crypto: af_alg: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 33/36] pipe: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 34/36] eventfd: switch " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 35/36] timerfd: convert " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-05 21:27 ` [PATCH 36/36] random: " Christoph Hellwig
2018-03-05 21:27 ` Christoph Hellwig
2018-03-13 7:46 ` aio poll, io_pgetevents and a new in-kernel poll API V5 Christoph Hellwig
2018-03-19 8:35 ` Christoph Hellwig
2018-03-19 8:35 ` Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2018-01-22 20:12 aio poll, io_pgetevents and a new in-kernel poll API V4 Christoph Hellwig
2018-01-22 20:12 ` [PATCH 21/36] net/dccp: convert to ->poll_mask Christoph Hellwig
2018-01-17 19:27 aio poll, io_pgetevents and a new in-kernel poll API V3 Christoph Hellwig
2018-01-17 19:27 ` [PATCH 21/36] net/dccp: convert to ->poll_mask Christoph Hellwig
2018-01-17 19:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305212743.16664-22-hch@lst.de \
--to=hch@lst.de \
--cc=avi@scylladb.com \
--cc=linux-aio@kvack.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.