All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-nvdimm@lists.01.org
Subject: Re: [PATCH] libnvdimm: remove redundant __func__ in dev_dbg
Date: Mon, 5 Mar 2018 20:54:34 -0700	[thread overview]
Message-ID: <20180306035434.GC15227@linux.intel.com> (raw)
In-Reply-To: <152029856149.39547.12704338925946035297.stgit@dwillia2-desk3.amr.corp.intel.com>

On Mon, Mar 05, 2018 at 05:09:21PM -0800, Dan Williams wrote:
> Dynamic debug can be instructed to add the function name to the debug
> output using the +f switch, so there is no need for the libnvdimm
> modules to do it again. If a user decides to add the +f switch for
> libnvdimm's dynamic debug this results in double prints of the function
> name.
> 
> Reported-by: Johannes Thumshirn <jthumshirn@suse.de>
> Reported-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/nvdimm/badrange.c       |    3 +-
>  drivers/nvdimm/btt_devs.c       |   21 ++++++++--------
>  drivers/nvdimm/bus.c            |   13 +++++-----
>  drivers/nvdimm/claim.c          |    2 +-
>  drivers/nvdimm/core.c           |    4 ++-
>  drivers/nvdimm/dax_devs.c       |    5 ++--
>  drivers/nvdimm/dimm_devs.c      |    7 ++---
>  drivers/nvdimm/label.c          |   51 ++++++++++++++++++---------------------
>  drivers/nvdimm/namespace_devs.c |   38 ++++++++++++-----------------
>  drivers/nvdimm/pfn_devs.c       |   25 +++++++++----------
>  drivers/nvdimm/pmem.c           |    2 +-
>  11 files changed, 77 insertions(+), 94 deletions(-)
> 
> diff --git a/drivers/nvdimm/badrange.c b/drivers/nvdimm/badrange.c
> index e068d72b4357..df17f1cd696d 100644
> --- a/drivers/nvdimm/badrange.c
> +++ b/drivers/nvdimm/badrange.c
> @@ -176,8 +176,7 @@ static void set_badblock(struct badblocks *bb, sector_t s, int num)
>  			(u64) s * 512, (u64) num * 512);
>  	/* this isn't an error as the hardware will still throw an exception */
>  	if (badblocks_set(bb, s, num, 1))
> -		dev_info_once(bb->dev, "%s: failed for sector %llx\n",
> -				__func__, (u64) s);
> +		dev_info_once(bb->dev, "failed for sector %llx\n", (u64) s);

I don't think you should remove this one.  dev_info_once() is just a printk(),
and doesn't inherit the +f flag from the dynamic debugging code. The __func__
here does add value.

The rest of these look correct, though I think you missed one in each of
nvdimm_map_release() and validate_dimm().  (I made these changes as well, but
you sent out your patch first. :)
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-nvdimm@lists.01.org,
	Johannes Thumshirn <jthumshirn@suse.de>,
	Ross Zwisler <ross.zwisler@linux.intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libnvdimm: remove redundant __func__ in dev_dbg
Date: Mon, 5 Mar 2018 20:54:34 -0700	[thread overview]
Message-ID: <20180306035434.GC15227@linux.intel.com> (raw)
In-Reply-To: <152029856149.39547.12704338925946035297.stgit@dwillia2-desk3.amr.corp.intel.com>

On Mon, Mar 05, 2018 at 05:09:21PM -0800, Dan Williams wrote:
> Dynamic debug can be instructed to add the function name to the debug
> output using the +f switch, so there is no need for the libnvdimm
> modules to do it again. If a user decides to add the +f switch for
> libnvdimm's dynamic debug this results in double prints of the function
> name.
> 
> Reported-by: Johannes Thumshirn <jthumshirn@suse.de>
> Reported-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
> ---
>  drivers/nvdimm/badrange.c       |    3 +-
>  drivers/nvdimm/btt_devs.c       |   21 ++++++++--------
>  drivers/nvdimm/bus.c            |   13 +++++-----
>  drivers/nvdimm/claim.c          |    2 +-
>  drivers/nvdimm/core.c           |    4 ++-
>  drivers/nvdimm/dax_devs.c       |    5 ++--
>  drivers/nvdimm/dimm_devs.c      |    7 ++---
>  drivers/nvdimm/label.c          |   51 ++++++++++++++++++---------------------
>  drivers/nvdimm/namespace_devs.c |   38 ++++++++++++-----------------
>  drivers/nvdimm/pfn_devs.c       |   25 +++++++++----------
>  drivers/nvdimm/pmem.c           |    2 +-
>  11 files changed, 77 insertions(+), 94 deletions(-)
> 
> diff --git a/drivers/nvdimm/badrange.c b/drivers/nvdimm/badrange.c
> index e068d72b4357..df17f1cd696d 100644
> --- a/drivers/nvdimm/badrange.c
> +++ b/drivers/nvdimm/badrange.c
> @@ -176,8 +176,7 @@ static void set_badblock(struct badblocks *bb, sector_t s, int num)
>  			(u64) s * 512, (u64) num * 512);
>  	/* this isn't an error as the hardware will still throw an exception */
>  	if (badblocks_set(bb, s, num, 1))
> -		dev_info_once(bb->dev, "%s: failed for sector %llx\n",
> -				__func__, (u64) s);
> +		dev_info_once(bb->dev, "failed for sector %llx\n", (u64) s);

I don't think you should remove this one.  dev_info_once() is just a printk(),
and doesn't inherit the +f flag from the dynamic debugging code. The __func__
here does add value.

The rest of these look correct, though I think you missed one in each of
nvdimm_map_release() and validate_dimm().  (I made these changes as well, but
you sent out your patch first. :)

  reply	other threads:[~2018-03-06  3:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06  1:09 [PATCH] libnvdimm: remove redundant __func__ in dev_dbg Dan Williams
2018-03-06  1:09 ` Dan Williams
2018-03-06  3:54 ` Ross Zwisler [this message]
2018-03-06  3:54   ` Ross Zwisler
2018-03-06 16:59   ` Dan Williams
2018-03-06 16:59     ` Dan Williams
2018-03-07  0:58     ` Ross Zwisler
2018-03-07  0:58       ` Ross Zwisler
2018-03-08  8:58     ` Johannes Thumshirn
2018-03-08  8:58       ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306035434.GC15227@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.