From: Vinod Koul <vinod.koul@intel.com>
To: Qi Hou <qi.hou@windriver.com>
Cc: dan.j.williams@intel.com, fmh6jj@gmail.com,
fmhess@users.sourceforge.net, jassisinghbrar@gmail.com,
rmk+kernel@arm.linux.org.uk, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: dmaengine: pl330: fix a race condition in case of threaded irqs
Date: Tue, 6 Mar 2018 17:21:54 +0530 [thread overview]
Message-ID: <20180306115153.GS15443@localhost> (raw)
On Tue, Mar 06, 2018 at 09:13:37AM +0800, Qi Hou wrote:
> When booting up with "threadirqs" in command line, all irq handlers of the DMA
> controller pl330 will be threaded forcedly. These threads will race for the same
> list, pl330->req_done.
>
> Before the callback, the spinlock was released. And after it, the spinlock was
> taken. This opened an race window where another threaded irq handler could steal
> the spinlock and be permitted to delete entries of the list, pl330->req_done.
>
> If the later deleted an entry that was still referred to by the former, there would
> be a kernel panic when the former was scheduled and tried to get the next sibling
> of the deleted entry.
Applied, thanks
WARNING: multiple messages have this Message-ID (diff)
From: Vinod Koul <vinod.koul@intel.com>
To: Qi Hou <qi.hou@windriver.com>
Cc: dan.j.williams@intel.com, fmh6jj@gmail.com,
fmhess@users.sourceforge.net, jassisinghbrar@gmail.com,
rmk+kernel@arm.linux.org.uk, dmaengine@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: pl330: fix a race condition in case of threaded irqs
Date: Tue, 6 Mar 2018 17:21:54 +0530 [thread overview]
Message-ID: <20180306115153.GS15443@localhost> (raw)
In-Reply-To: <1520298817-19870-1-git-send-email-qi.hou@windriver.com>
On Tue, Mar 06, 2018 at 09:13:37AM +0800, Qi Hou wrote:
> When booting up with "threadirqs" in command line, all irq handlers of the DMA
> controller pl330 will be threaded forcedly. These threads will race for the same
> list, pl330->req_done.
>
> Before the callback, the spinlock was released. And after it, the spinlock was
> taken. This opened an race window where another threaded irq handler could steal
> the spinlock and be permitted to delete entries of the list, pl330->req_done.
>
> If the later deleted an entry that was still referred to by the former, there would
> be a kernel panic when the former was scheduled and tried to get the next sibling
> of the deleted entry.
Applied, thanks
--
~Vinod
next reply other threads:[~2018-03-06 11:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 11:51 Vinod Koul [this message]
2018-03-06 11:51 ` [PATCH] dmaengine: pl330: fix a race condition in case of threaded irqs Vinod Koul
-- strict thread matches above, loose matches on Subject: below --
2018-03-06 1:13 Qi Hou
2018-03-06 1:13 ` [PATCH] " Qi Hou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306115153.GS15443@localhost \
--to=vinod.koul@intel.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=fmh6jj@gmail.com \
--cc=fmhess@users.sourceforge.net \
--cc=jassisinghbrar@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.hou@windriver.com \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.