From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
"Usyskin, Alexander" <alexander.usyskin@intel.com>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] tmp: factor out tpm1_get_random into tpm1-cmd.c
Date: Tue, 6 Mar 2018 15:56:07 +0200 [thread overview]
Message-ID: <20180306135607.GB5700@linux.intel.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9422F24F@hasmsx108.ger.corp.intel.com>
On Tue, Mar 06, 2018 at 11:34:50AM +0000, Winkler, Tomas wrote:
>
> >
> > On Tue, 2018-03-06 at 11:30 +0200, Tomas Winkler wrote:
> > > Factor out get random implementation from tpm-interface.c into
> > > tpm1_get_random function in tpm1-cmd.c.
> > > No functional changes.
> > >
> > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> >
> > While you are doing this, please make it use tpm_buf so tha we get stuff out
> > of that nasty union. Using "helper" structs is still fine, just move it right
> > before the function implementation out of tpm.h (there are examples of this
> > tpm2-cmd.c).
>
> Sure, but not while moving code, this is dangerous. Should be done after code is moved.
Makes sense have use two steps here.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 3/4] tmp: factor out tpm1_get_random into tpm1-cmd.c
Date: Tue, 6 Mar 2018 15:56:07 +0200 [thread overview]
Message-ID: <20180306135607.GB5700@linux.intel.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B9422F24F@hasmsx108.ger.corp.intel.com>
On Tue, Mar 06, 2018 at 11:34:50AM +0000, Winkler, Tomas wrote:
>
> >
> > On Tue, 2018-03-06 at 11:30 +0200, Tomas Winkler wrote:
> > > Factor out get random implementation from tpm-interface.c into
> > > tpm1_get_random function in tpm1-cmd.c.
> > > No functional changes.
> > >
> > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> >
> > While you are doing this, please make it use tpm_buf so tha we get stuff out
> > of that nasty union. Using "helper" structs is still fine, just move it right
> > before the function implementation out of tpm.h (there are examples of this
> > tpm2-cmd.c).
>
> Sure, but not while moving code, this is dangerous. Should be done after code is moved.
Makes sense have use two steps here.
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-06 13:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 9:30 [PATCH 0/4] tpm: factor out tpm1 code into tpm1-cmd.c Tomas Winkler
2018-03-06 9:30 ` Tomas Winkler
2018-03-06 9:30 ` [PATCH 1/4] tmp: move tpm1_pcr_extend to tpm1-cmd.c Tomas Winkler
2018-03-06 9:30 ` Tomas Winkler
2018-03-06 9:30 ` [PATCH 2/4] tmp: move tpm_getcap " Tomas Winkler
2018-03-06 9:30 ` Tomas Winkler
2018-03-06 9:30 ` [PATCH 3/4] tmp: factor out tpm1_get_random into tpm1-cmd.c Tomas Winkler
2018-03-06 9:30 ` Tomas Winkler
2018-03-06 11:31 ` Jarkko Sakkinen
2018-03-06 11:31 ` Jarkko Sakkinen
2018-03-06 11:34 ` Winkler, Tomas
2018-03-06 11:34 ` Winkler, Tomas
2018-03-06 13:56 ` Jarkko Sakkinen [this message]
2018-03-06 13:56 ` Jarkko Sakkinen
2018-03-06 9:30 ` [PATCH 4/4] tpm: move tpm1 selftest code from tpm-interface tpm1-cmd.c Tomas Winkler
2018-03-06 9:30 ` Tomas Winkler
2018-03-06 11:32 ` Jarkko Sakkinen
2018-03-06 11:32 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306135607.GB5700@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=alexander.usyskin@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.