From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] misc, ide: remove use of HWADDR_PRIx in trace events
Date: Tue, 6 Mar 2018 14:24:40 +0000 [thread overview]
Message-ID: <20180306142440.GK6163@redhat.com> (raw)
In-Reply-To: <10097c87-9302-5de5-9b63-e76200989ac1@ilande.co.uk>
On Tue, Mar 06, 2018 at 02:16:00PM +0000, Mark Cave-Ayland wrote:
> On 06/03/18 13:44, Daniel P. Berrangé wrote:
>
> > The trace events all use a uint64_t data type, so should be using the
> > corresponding PRIx64 format, not HWADDR_PRIx which is intended for use
> > with the 'hwaddr' type.
>
> Ha okay looks like you beat me to it ;) I wonder if we can teach
> checkpatch.pl about this...
We should just make tracetool whitelist the data types it permits, and
it could also report on unusual format macros like this - only allow
the standard PRI* ones. That way all build configs would immediately
fail, instead of only the ust build config
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
WARNING: multiple messages have this Message-ID (diff)
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] misc, ide: remove use of HWADDR_PRIx in trace events
Date: Tue, 6 Mar 2018 14:24:40 +0000 [thread overview]
Message-ID: <20180306142440.GK6163@redhat.com> (raw)
In-Reply-To: <10097c87-9302-5de5-9b63-e76200989ac1@ilande.co.uk>
On Tue, Mar 06, 2018 at 02:16:00PM +0000, Mark Cave-Ayland wrote:
> On 06/03/18 13:44, Daniel P. Berrangé wrote:
>
> > The trace events all use a uint64_t data type, so should be using the
> > corresponding PRIx64 format, not HWADDR_PRIx which is intended for use
> > with the 'hwaddr' type.
>
> Ha okay looks like you beat me to it ;) I wonder if we can teach
> checkpatch.pl about this...
We should just make tracetool whitelist the data types it permits, and
it could also report on unusual format macros like this - only allow
the standard PRI* ones. That way all build configs would immediately
fail, instead of only the ust build config
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-03-06 14:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 13:44 [Qemu-trivial] [PATCH] misc, ide: remove use of HWADDR_PRIx in trace events Daniel P. Berrangé
2018-03-06 13:44 ` [Qemu-devel] " Daniel P. Berrangé
2018-03-06 14:16 ` [Qemu-trivial] " Mark Cave-Ayland
2018-03-06 14:16 ` Mark Cave-Ayland
2018-03-06 14:24 ` Daniel P. Berrangé [this message]
2018-03-06 14:24 ` Daniel P. Berrangé
2018-03-06 18:57 ` [Qemu-trivial] " Philippe Mathieu-Daudé
2018-03-06 18:57 ` [Qemu-devel] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306142440.GK6163@redhat.com \
--to=berrange@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.