All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jason Gunthorpe <jgg@ziepe.ca>
To: Jiandi An <anjiandi@codeaurora.org>
Cc: zohar@linux.vnet.ibm.com, dmitry.kasatkin@gmail.com,
	jmorris@namei.org, serge@hallyn.com,
	linux-integrity@vger.kernel.org,
	linux-ima-devel@lists.sourceforge.net,
	linux-ima-user@lists.sourceforge.net,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64
Date: Wed, 7 Mar 2018 11:51:32 -0700	[thread overview]
Message-ID: <20180307185132.GA30102@ziepe.ca> (raw)
In-Reply-To: <1520400386-17674-1-git-send-email-anjiandi@codeaurora.org>

On Tue, Mar 06, 2018 at 11:26:26PM -0600, Jiandi An wrote:
> TPM_CRB driver is the TPM support for ARM64.  If it
> is built as module, TPM chip is registered after IMA
> init.  tpm_pcr_read() in IMA driver would fail and
> display the following message even though eventually
> there is TPM chip on the system:
> 
> ima: No TPM chip found, activating TPM-bypass! (rc=-19)
> 
> Fix IMA Kconfig to select TPM_CRB so TPM_CRB driver is
> built in kernel and initializes before IMA driver.
> 
> Signed-off-by: Jiandi An <anjiandi@codeaurora.org>
>  security/integrity/ima/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig
> index 35ef693..6a8f677 100644
> +++ b/security/integrity/ima/Kconfig
> @@ -10,6 +10,7 @@ config IMA
>  	select CRYPTO_HASH_INFO
>  	select TCG_TPM if HAS_IOMEM && !UML
>  	select TCG_TIS if TCG_TPM && X86
> +	select TCG_CRB if TCG_TPM && ACPI
>  	select TCG_IBMVTPM if TCG_TPM && PPC_PSERIES
>  	help
>  	  The Trusted Computing Group(TCG) runtime Integrity

This seems really weird, why are any specific TPM drivers linked to
IMA config, we have lots of drivers..

I don't think I've ever seen this pattern in Kconfig before?

Jason

WARNING: multiple messages have this Message-ID (diff)
From: jgg@ziepe.ca (Jason Gunthorpe)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] security: Fix IMA Kconfig for dependencies on ARM64
Date: Wed, 7 Mar 2018 11:51:32 -0700	[thread overview]
Message-ID: <20180307185132.GA30102@ziepe.ca> (raw)
In-Reply-To: <1520400386-17674-1-git-send-email-anjiandi@codeaurora.org>

On Tue, Mar 06, 2018 at 11:26:26PM -0600, Jiandi An wrote:
> TPM_CRB driver is the TPM support for ARM64.  If it
> is built as module, TPM chip is registered after IMA
> init.  tpm_pcr_read() in IMA driver would fail and
> display the following message even though eventually
> there is TPM chip on the system:
> 
> ima: No TPM chip found, activating TPM-bypass! (rc=-19)
> 
> Fix IMA Kconfig to select TPM_CRB so TPM_CRB driver is
> built in kernel and initializes before IMA driver.
> 
> Signed-off-by: Jiandi An <anjiandi@codeaurora.org>
>  security/integrity/ima/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/security/integrity/ima/Kconfig b/security/integrity/ima/Kconfig
> index 35ef693..6a8f677 100644
> +++ b/security/integrity/ima/Kconfig
> @@ -10,6 +10,7 @@ config IMA
>  	select CRYPTO_HASH_INFO
>  	select TCG_TPM if HAS_IOMEM && !UML
>  	select TCG_TIS if TCG_TPM && X86
> +	select TCG_CRB if TCG_TPM && ACPI
>  	select TCG_IBMVTPM if TCG_TPM && PPC_PSERIES
>  	help
>  	  The Trusted Computing Group(TCG) runtime Integrity

This seems really weird, why are any specific TPM drivers linked to
IMA config, we have lots of drivers..

I don't think I've ever seen this pattern in Kconfig before?

Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-03-07 18:51 UTC|newest]

Thread overview: 87+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07  5:26 [PATCH] security: Fix IMA Kconfig for dependencies on ARM64 Jiandi An
2018-03-07  5:26 ` Jiandi An
2018-03-07 18:51 ` Jason Gunthorpe [this message]
2018-03-07 18:51   ` Jason Gunthorpe
2018-03-07 18:55   ` Mimi Zohar
2018-03-07 18:55     ` Mimi Zohar
2018-03-07 18:55     ` Mimi Zohar
2018-03-07 19:08     ` James Bottomley
2018-03-07 19:08       ` James Bottomley
2018-03-07 19:08       ` James Bottomley
2018-03-07 19:21       ` Mimi Zohar
2018-03-07 19:21         ` Mimi Zohar
2018-03-07 19:21         ` Mimi Zohar
2018-03-07 19:41         ` James Bottomley
2018-03-07 19:41           ` James Bottomley
2018-03-07 19:41           ` James Bottomley
2018-03-07 21:12           ` Jiandi An
2018-03-07 21:12             ` Jiandi An
2018-03-07 21:12             ` Jiandi An
2018-03-07 21:16             ` James Bottomley
2018-03-07 21:16               ` James Bottomley
2018-03-07 21:16               ` James Bottomley
2018-03-07 22:19           ` Mimi Zohar
2018-03-07 22:19             ` Mimi Zohar
2018-03-07 22:19             ` Mimi Zohar
2018-03-08 18:42             ` Jiandi An
2018-03-08 18:42               ` Jiandi An
2018-03-08 18:42               ` Jiandi An
2018-03-08 20:06               ` Mimi Zohar
2018-03-08 20:06                 ` Mimi Zohar
2018-03-08 20:06                 ` Mimi Zohar
2018-03-09 17:11               ` James Bottomley
2018-03-09 17:11                 ` James Bottomley
2018-03-09 17:11                 ` James Bottomley
2018-03-12 21:53                 ` Mimi Zohar
2018-03-12 21:53                   ` Mimi Zohar
2018-03-12 21:53                   ` Mimi Zohar
2018-03-12 21:59                   ` Jason Gunthorpe
2018-03-12 21:59                     ` Jason Gunthorpe
2018-03-12 21:59                     ` Jason Gunthorpe
2018-03-12 22:58                     ` Mimi Zohar
2018-03-12 22:58                       ` Mimi Zohar
2018-03-12 22:58                       ` Mimi Zohar
2018-03-12 23:05                       ` Jason Gunthorpe
2018-03-12 23:05                         ` Jason Gunthorpe
2018-03-12 23:05                         ` Jason Gunthorpe
2018-03-12 23:19                         ` Mimi Zohar
2018-03-12 23:19                           ` Mimi Zohar
2018-03-12 23:19                           ` Mimi Zohar
2018-03-12 22:30                   ` James Bottomley
2018-03-12 22:30                     ` James Bottomley
2018-03-12 22:30                     ` James Bottomley
2018-03-12 23:30                     ` Mimi Zohar
2018-03-12 23:30                       ` Mimi Zohar
2018-03-12 23:30                       ` Mimi Zohar
2018-03-13  0:06                       ` James Bottomley
2018-03-13  0:06                         ` James Bottomley
2018-03-13  0:06                         ` James Bottomley
2018-03-13 12:57                         ` Safford, David (GE Global Research, US)
2018-03-13 12:57                           ` Safford, David (GE Global Research, US)
2018-03-13 12:57                           ` Safford, David (GE Global Research, US)
2018-03-14 14:41                           ` James Bottomley
2018-03-14 14:41                             ` James Bottomley
2018-03-14 14:41                             ` James Bottomley
2018-03-14 17:08                             ` Mimi Zohar
2018-03-14 17:08                               ` Mimi Zohar
2018-03-14 17:08                               ` Mimi Zohar
2018-03-14 17:25                               ` James Bottomley
2018-03-14 17:25                                 ` James Bottomley
2018-03-14 17:25                                 ` James Bottomley
2018-03-15 16:19                                 ` Mimi Zohar
2018-03-15 16:19                                   ` Mimi Zohar
2018-03-15 16:19                                   ` Mimi Zohar
2018-03-15 17:08                                   ` James Bottomley
2018-03-15 17:08                                     ` James Bottomley
2018-03-15 17:08                                     ` James Bottomley
2018-03-15 17:14                                     ` Mimi Zohar
2018-03-15 17:14                                       ` Mimi Zohar
2018-03-15 17:14                                       ` Mimi Zohar
2018-03-15 17:29                                       ` James Bottomley
2018-03-15 17:29                                         ` James Bottomley
2018-03-15 17:29                                         ` James Bottomley
2018-03-16 16:51                                         ` Mimi Zohar
2018-03-16 16:51                                           ` Mimi Zohar
2018-03-16 16:51                                           ` Mimi Zohar
2018-03-11 22:06 ` Mimi Zohar
2018-03-11 22:06   ` Mimi Zohar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180307185132.GA30102@ziepe.ca \
    --to=jgg@ziepe.ca \
    --cc=anjiandi@codeaurora.org \
    --cc=dmitry.kasatkin@gmail.com \
    --cc=jmorris@namei.org \
    --cc=linux-ima-devel@lists.sourceforge.net \
    --cc=linux-ima-user@lists.sourceforge.net \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=serge@hallyn.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.