From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Agustin Vega-Frias <agustinv@codeaurora.org>,
linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
timur@codeaurora.org
Subject: Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events
Date: Wed, 7 Mar 2018 16:05:43 -0300 [thread overview]
Message-ID: <20180307190543.GR3701@kernel.org> (raw)
In-Reply-To: <20180307190509.GQ3701@kernel.org>
Em Wed, Mar 07, 2018 at 04:05:09PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Mar 07, 2018 at 10:54:15AM -0800, Andi Kleen escreveu:
> > > Sorry about that. That's probably because FNM_EXTMATCH is a GNU extension,
> > > not POSIX, and the Alpine and Android runtimes likely don't implement
> > > that...
> > > I'll send a fix reverting back to the strncmp to ignore the uncore_ prefix,
> > > and dropping that extension.
> >
> > Just don't set it? Even the basic glob patterns are useful.
>
> Or use:
>
> #ifndef FNM_EXTMATCH
> #define FNM_EXTMATCH 0
> #endif
>
> So on systems without it, its not used, while on GNU systems, we have
> that functionality (pretty fancy, someone may need that... ;-))
I'll try this route, btw, no need to send more patches for now.
- Arnaldo
WARNING: multiple messages have this Message-ID (diff)
From: acme@kernel.org (Arnaldo Carvalho de Melo)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events
Date: Wed, 7 Mar 2018 16:05:43 -0300 [thread overview]
Message-ID: <20180307190543.GR3701@kernel.org> (raw)
In-Reply-To: <20180307190509.GQ3701@kernel.org>
Em Wed, Mar 07, 2018 at 04:05:09PM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, Mar 07, 2018 at 10:54:15AM -0800, Andi Kleen escreveu:
> > > Sorry about that. That's probably because FNM_EXTMATCH is a GNU extension,
> > > not POSIX, and the Alpine and Android runtimes likely don't implement
> > > that...
> > > I'll send a fix reverting back to the strncmp to ignore the uncore_ prefix,
> > > and dropping that extension.
> >
> > Just don't set it? Even the basic glob patterns are useful.
>
> Or use:
>
> #ifndef FNM_EXTMATCH
> #define FNM_EXTMATCH 0
> #endif
>
> So on systems without it, its not used, while on GNU systems, we have
> that functionality (pretty fancy, someone may need that... ;-))
I'll try this route, btw, no need to send more patches for now.
- Arnaldo
next prev parent reply other threads:[~2018-03-07 19:05 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 14:04 [RFC V3 0/3] perf stat: improvements for handling of multiple PMUs Agustin Vega-Frias
2018-03-06 14:04 ` Agustin Vega-Frias
2018-03-06 14:04 ` [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events Agustin Vega-Frias
2018-03-06 14:04 ` Agustin Vega-Frias
2018-03-07 16:02 ` Arnaldo Carvalho de Melo
2018-03-07 16:02 ` Arnaldo Carvalho de Melo
2018-03-07 16:02 ` Arnaldo Carvalho de Melo
2018-03-07 17:39 ` Agustin Vega-Frias
2018-03-07 17:39 ` Agustin Vega-Frias
2018-03-07 18:54 ` Andi Kleen
2018-03-07 18:54 ` Andi Kleen
2018-03-07 19:05 ` Arnaldo Carvalho de Melo
2018-03-07 19:05 ` Arnaldo Carvalho de Melo
2018-03-07 19:05 ` Arnaldo Carvalho de Melo [this message]
2018-03-07 19:05 ` Arnaldo Carvalho de Melo
2018-03-07 19:39 ` Arnaldo Carvalho de Melo
2018-03-07 19:39 ` Arnaldo Carvalho de Melo
2018-03-07 19:49 ` Agustin Vega-Frias
2018-03-07 19:49 ` Agustin Vega-Frias
2018-03-07 19:58 ` Arnaldo Carvalho de Melo
2018-03-07 19:58 ` Arnaldo Carvalho de Melo
2018-03-07 19:58 ` Arnaldo Carvalho de Melo
2018-03-07 20:09 ` Agustin Vega-Frias
2018-03-07 20:09 ` Agustin Vega-Frias
2018-03-07 20:21 ` Jiri Olsa
2018-03-07 20:21 ` Jiri Olsa
2018-03-07 20:33 ` Arnaldo Carvalho de Melo
2018-03-07 20:33 ` Arnaldo Carvalho de Melo
2018-03-06 14:04 ` [RFC V3 2/3] perf, tools: Display pmu name when printing unmerged events in stat Agustin Vega-Frias
2018-03-06 14:04 ` Agustin Vega-Frias
2018-03-09 8:42 ` [tip:perf/core] perf pmu: " tip-bot for Agustin Vega-Frias
2018-03-06 14:04 ` [RFC V3 3/3] perf pmu: Auto-merge PMU events created by prefix or glob match Agustin Vega-Frias
2018-03-06 14:04 ` Agustin Vega-Frias
2018-03-09 8:43 ` [tip:perf/core] " tip-bot for Agustin Vega-Frias
2018-03-07 10:04 ` [RFC V3 0/3] perf stat: improvements for handling of multiple PMUs Jiri Olsa
2018-03-07 10:04 ` Jiri Olsa
2018-03-07 10:04 ` Jiri Olsa
2018-03-07 13:36 ` Arnaldo Carvalho de Melo
2018-03-07 13:36 ` Arnaldo Carvalho de Melo
2018-03-07 13:51 ` Jiri Olsa
2018-03-07 13:51 ` Jiri Olsa
2018-03-07 14:30 ` Arnaldo Carvalho de Melo
2018-03-07 14:30 ` Arnaldo Carvalho de Melo
2018-03-07 17:09 ` Andi Kleen
2018-03-07 17:09 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307190543.GR3701@kernel.org \
--to=acme@kernel.org \
--cc=agustinv@codeaurora.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.