From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: dts: imx: Add missing #sound-dai-cells for sgtl5000 codec
Date: Thu, 8 Mar 2018 16:33:01 +0800 [thread overview]
Message-ID: <20180308083300.GU3217@dragon> (raw)
In-Reply-To: <20180301202537.30571-1-robh@kernel.org>
On Thu, Mar 01, 2018 at 02:25:33PM -0600, Rob Herring wrote:
> dtc now warns about missing #sound-dai-cells:
>
> arch/arm/boot/dts/imx6ul-geam.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus at 2100000/i2c at 21a0000/codec at a or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/imx6ul-isiot-emmc.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus at 2100000/i2c at 21a0000/codec at a or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/imx6ul-isiot-nand.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus at 2100000/i2c at 21a0000/codec at a or bad phandle (referred from sound-dai[0])
>
> Lots of i.MX boards use the SGTL5000 codec, but not all get the warning
> because only some reference the codec with "sound-dai" property. However,
> the codec should always provide #sound-dai-cells regardless, so fix all
> the occurrences.
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Fabio Estevam <fabio.estevam@nxp.com>,
devicetree@vger.kernel.org, arm@kernel.org,
Sascha Hauer <kernel@pengutronix.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm: dts: imx: Add missing #sound-dai-cells for sgtl5000 codec
Date: Thu, 8 Mar 2018 16:33:01 +0800 [thread overview]
Message-ID: <20180308083300.GU3217@dragon> (raw)
In-Reply-To: <20180301202537.30571-1-robh@kernel.org>
On Thu, Mar 01, 2018 at 02:25:33PM -0600, Rob Herring wrote:
> dtc now warns about missing #sound-dai-cells:
>
> arch/arm/boot/dts/imx6ul-geam.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/imx6ul-isiot-emmc.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0])
> arch/arm/boot/dts/imx6ul-isiot-nand.dtb: Warning (sound_dai_property): /sound/simple-audio-card,codec: Missing property '#sound-dai-cells' in node /soc/aips-bus@2100000/i2c@21a0000/codec@a or bad phandle (referred from sound-dai[0])
>
> Lots of i.MX boards use the SGTL5000 codec, but not all get the warning
> because only some reference the codec with "sound-dai" property. However,
> the codec should always provide #sound-dai-cells regardless, so fix all
> the occurrences.
>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Sascha Hauer <kernel@pengutronix.de>
> Cc: Fabio Estevam <fabio.estevam@nxp.com>
> Signed-off-by: Rob Herring <robh@kernel.org>
Applied, thanks.
next prev parent reply other threads:[~2018-03-08 8:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 20:25 [PATCH] arm: dts: imx: Add missing #sound-dai-cells for sgtl5000 codec Rob Herring
2018-03-01 20:25 ` Rob Herring
2018-03-08 8:33 ` Shawn Guo [this message]
2018-03-08 8:33 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308083300.GU3217@dragon \
--to=shawnguo@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.