From: Bin Liu <b-liu@ti.com>
To: Merlijn Wajer <merlijn@wizzup.org>
Cc: ivo.g.dimitrov.75@gmail.com, linux-omap@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH] usb: musb: Fix external abort in musb_remove
Date: Thu, 8 Mar 2018 12:22:38 -0600 [thread overview]
Message-ID: <20180308182238.GI14921@uda0271908> (raw)
In-Reply-To: <1b280405-5af6-ef64-f8a2-cc8865487e0a@wizzup.org>
On Thu, Mar 08, 2018 at 07:00:16PM +0100, Merlijn Wajer wrote:
> Hi,
>
> On 08/03/18 17:46, Bin Liu wrote:
>
>
> > No need to flush, the work is already cancelled at this point.
> >
> >> +
> >> musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
> >> + musb_platform_exit(musb);
> >
> > This can be move down to out side of holding the spinlock,
> >
> >> spin_unlock_irqrestore(&musb->lock, flags);
> >
> > to here.
>
> Thank you - with I've verified that it works with these changes. I'm
> surprised, because I believe that I had tried this already. I must have
> missed a step in my testing-routine.
>
> I will send a patch shortly.
Thank you for fixing this up.
Regards,
-Bin.
WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu@ti.com>
To: Merlijn Wajer <merlijn@wizzup.org>
Cc: ivo.g.dimitrov.75@gmail.com, linux-omap@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC] usb: musb: Fix external abort in musb_remove
Date: Thu, 8 Mar 2018 12:22:38 -0600 [thread overview]
Message-ID: <20180308182238.GI14921@uda0271908> (raw)
On Thu, Mar 08, 2018 at 07:00:16PM +0100, Merlijn Wajer wrote:
> Hi,
>
> On 08/03/18 17:46, Bin Liu wrote:
>
>
> > No need to flush, the work is already cancelled at this point.
> >
> >> +
> >> musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
> >> + musb_platform_exit(musb);
> >
> > This can be move down to out side of holding the spinlock,
> >
> >> spin_unlock_irqrestore(&musb->lock, flags);
> >
> > to here.
>
> Thank you - with I've verified that it works with these changes. I'm
> surprised, because I believe that I had tried this already. I must have
> missed a step in my testing-routine.
>
> I will send a patch shortly.
Thank you for fixing this up.
Regards,
-Bin.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Bin Liu <b-liu@ti.com>
To: Merlijn Wajer <merlijn@wizzup.org>
Cc: <ivo.g.dimitrov.75@gmail.com>, <linux-omap@vger.kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH] usb: musb: Fix external abort in musb_remove
Date: Thu, 8 Mar 2018 12:22:38 -0600 [thread overview]
Message-ID: <20180308182238.GI14921@uda0271908> (raw)
In-Reply-To: <1b280405-5af6-ef64-f8a2-cc8865487e0a@wizzup.org>
On Thu, Mar 08, 2018 at 07:00:16PM +0100, Merlijn Wajer wrote:
> Hi,
>
> On 08/03/18 17:46, Bin Liu wrote:
>
>
> > No need to flush, the work is already cancelled at this point.
> >
> >> +
> >> musb_writeb(musb->mregs, MUSB_DEVCTL, 0);
> >> + musb_platform_exit(musb);
> >
> > This can be move down to out side of holding the spinlock,
> >
> >> spin_unlock_irqrestore(&musb->lock, flags);
> >
> > to here.
>
> Thank you - with I've verified that it works with these changes. I'm
> surprised, because I believe that I had tried this already. I must have
> missed a step in my testing-routine.
>
> I will send a patch shortly.
Thank you for fixing this up.
Regards,
-Bin.
next prev parent reply other threads:[~2018-03-08 18:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 9:31 [RFC PATCH] usb: musb: Fix external abort in musb_remove Merlijn Wajer
2018-03-08 9:31 ` [RFC] " Merlijn Wajer
2018-03-08 16:46 ` [RFC PATCH] " Bin Liu
2018-03-08 16:46 ` Bin Liu
2018-03-08 16:46 ` [RFC] " Bin Liu
2018-03-08 18:00 ` [RFC PATCH] " Merlijn Wajer
2018-03-08 18:00 ` [RFC] " Merlijn Wajer
2018-03-08 18:22 ` Bin Liu [this message]
2018-03-08 18:22 ` [RFC PATCH] " Bin Liu
2018-03-08 18:22 ` [RFC] " Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180308182238.GI14921@uda0271908 \
--to=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=merlijn@wizzup.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.