From: Will Deacon <will.deacon@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Shanker Donthineni <shankerd@codeaurora.org>,
Robin Murphy <robin.murphy@arm.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Catalin Marinas <catalin.marinas@arm.com>,
kvmarm <kvmarm@lists.cs.columbia.edu>,
Marc Zyngier <marc.zyngier@arm.com>,
Vikram Sethi <vikrams@codeaurora.org>,
Philip Elcan <pelcan@codeaurora.org>
Subject: Re: [PATCH v7] arm64: Add support for new control bits CTR_EL0.DIC and CTR_EL0.IDC
Date: Fri, 9 Mar 2018 13:47:59 +0000 [thread overview]
Message-ID: <20180309134759.GB15537@arm.com> (raw)
In-Reply-To: <20180309134439.76b43chxnrw7okrw@lakrids.cambridge.arm.com>
On Fri, Mar 09, 2018 at 01:44:40PM +0000, Mark Rutland wrote:
> On Wed, Mar 07, 2018 at 09:00:08AM -0600, Shanker Donthineni wrote:
> > static inline void __flush_icache_all(void)
> > {
> > - asm("ic ialluis");
> > - dsb(ish);
> > + /* Instruction cache invalidation is not required for I/D coherence? */
> > + if (!cpus_have_const_cap(ARM64_HAS_CACHE_DIC)) {
> > + asm("ic ialluis");
> > + dsb(ish);
> > + }
> > }
>
> I don't think we need the comment here. We don't have this in the other
> cases we look at the ARM64_HAS_CACHE_{IDC,DIC} caps.
>
> This would also be slightly nicer as an early return:
>
> static inline void __flush_icache_all(void)
> {
> if (cpus_have_const_cap(ARM64_HAS_CACHE_DIC))
> return;
>
> asm("ic ialluis");
> dsb(ish);
> }
>
> ... which minimizes indentation, and the diffstat.
>
> The rest looks fine to me, so with the above changes:
>
> Reviewed-by: Mark Rutland <mark.rutland@arm.com>
I've already queued this, but not pushed out yet so I'll fold these changes
in.
Will
WARNING: multiple messages have this Message-ID (diff)
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7] arm64: Add support for new control bits CTR_EL0.DIC and CTR_EL0.IDC
Date: Fri, 9 Mar 2018 13:47:59 +0000 [thread overview]
Message-ID: <20180309134759.GB15537@arm.com> (raw)
In-Reply-To: <20180309134439.76b43chxnrw7okrw@lakrids.cambridge.arm.com>
On Fri, Mar 09, 2018 at 01:44:40PM +0000, Mark Rutland wrote:
> On Wed, Mar 07, 2018 at 09:00:08AM -0600, Shanker Donthineni wrote:
> > static inline void __flush_icache_all(void)
> > {
> > - asm("ic ialluis");
> > - dsb(ish);
> > + /* Instruction cache invalidation is not required for I/D coherence? */
> > + if (!cpus_have_const_cap(ARM64_HAS_CACHE_DIC)) {
> > + asm("ic ialluis");
> > + dsb(ish);
> > + }
> > }
>
> I don't think we need the comment here. We don't have this in the other
> cases we look at the ARM64_HAS_CACHE_{IDC,DIC} caps.
>
> This would also be slightly nicer as an early return:
>
> static inline void __flush_icache_all(void)
> {
> if (cpus_have_const_cap(ARM64_HAS_CACHE_DIC))
> return;
>
> asm("ic ialluis");
> dsb(ish);
> }
>
> ... which minimizes indentation, and the diffstat.
>
> The rest looks fine to me, so with the above changes:
>
> Reviewed-by: Mark Rutland <mark.rutland@arm.com>
I've already queued this, but not pushed out yet so I'll fold these changes
in.
Will
next prev parent reply other threads:[~2018-03-09 13:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 15:00 [PATCH v7] arm64: Add support for new control bits CTR_EL0.DIC and CTR_EL0.IDC Shanker Donthineni
2018-03-07 15:00 ` Shanker Donthineni
2018-03-09 13:44 ` Mark Rutland
2018-03-09 13:44 ` Mark Rutland
2018-03-09 13:47 ` Will Deacon [this message]
2018-03-09 13:47 ` Will Deacon
2018-03-09 13:48 ` Will Deacon
2018-03-09 13:48 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309134759.GB15537@arm.com \
--to=will.deacon@arm.com \
--cc=catalin.marinas@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=pelcan@codeaurora.org \
--cc=robin.murphy@arm.com \
--cc=shankerd@codeaurora.org \
--cc=vikrams@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.