From: Stephen Hemminger <stephen@networkplumber.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support
Date: Sat, 10 Mar 2018 08:42:43 -0800 [thread overview]
Message-ID: <20180310084243.4584ccd9@xeon-e3> (raw)
In-Reply-To: <20180309172136.9073-13-anirudh.venkataramanan@intel.com>
On Fri, 9 Mar 2018 09:21:33 -0800
Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> wrote:
> + /* VSI stats */
> + struct rtnl_link_stats64 net_stats;
> + struct rtnl_link_stats64 net_stats_prev;
> + struct ice_eth_stats eth_stats;
> + struct ice_eth_stats eth_stats_prev;
You also don't need current and previous as separate copies since previous is only
used while computing the current values.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: Anirudh Venkataramanan <anirudh.venkataramanan@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH 12/15] ice: Add stats and ethtool support
Date: Sat, 10 Mar 2018 08:42:43 -0800 [thread overview]
Message-ID: <20180310084243.4584ccd9@xeon-e3> (raw)
In-Reply-To: <20180309172136.9073-13-anirudh.venkataramanan@intel.com>
On Fri, 9 Mar 2018 09:21:33 -0800
Anirudh Venkataramanan <anirudh.venkataramanan@intel.com> wrote:
> + /* VSI stats */
> + struct rtnl_link_stats64 net_stats;
> + struct rtnl_link_stats64 net_stats_prev;
> + struct ice_eth_stats eth_stats;
> + struct ice_eth_stats eth_stats_prev;
You also don't need current and previous as separate copies since previous is only
used while computing the current values.
next prev parent reply other threads:[~2018-03-10 16:42 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 17:21 [Intel-wired-lan] [PATCH 00/15] Add ice driver Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 01/15] ice: Add basic driver framework for Intel(R) E800 Series Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-09 22:16 ` [Intel-wired-lan] " Jakub Kicinski
2018-03-09 22:16 ` Jakub Kicinski
2018-03-12 16:56 ` [Intel-wired-lan] " Jeff Kirsher
2018-03-12 16:56 ` Jeff Kirsher
2018-03-13 4:41 ` Jakub Kicinski
2018-03-13 4:41 ` Jakub Kicinski
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 02/15] ice: Add support for control queues Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-13 2:05 ` [Intel-wired-lan] " Shannon Nelson
2018-03-13 2:05 ` Shannon Nelson
2018-03-14 22:16 ` Jeff Kirsher
2018-03-14 22:16 ` Jeff Kirsher
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 03/15] ice: Start hardware initialization Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-13 2:05 ` [Intel-wired-lan] " Shannon Nelson
2018-03-13 2:05 ` Shannon Nelson
2018-03-14 22:05 ` Venkataramanan, Anirudh
2018-03-14 22:05 ` Venkataramanan, Anirudh
2018-03-15 17:00 ` Shannon Nelson
2018-03-15 17:00 ` Shannon Nelson
2018-03-15 18:27 ` Venkataramanan, Anirudh
2018-03-15 18:27 ` Venkataramanan, Anirudh
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 04/15] ice: Get switch config, scheduler config and device capabilities Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-13 2:05 ` [Intel-wired-lan] " Shannon Nelson
2018-03-13 2:05 ` Shannon Nelson
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 05/15] ice: Get MAC/PHY/link info and scheduler topology Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 06/15] ice: Initialize PF and setup miscellaneous interrupt Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-13 2:05 ` [Intel-wired-lan] " Shannon Nelson
2018-03-13 2:05 ` Shannon Nelson
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 07/15] ice: Add support for VSI allocation and deallocation Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-13 2:05 ` [Intel-wired-lan] " Shannon Nelson
2018-03-13 2:05 ` Shannon Nelson
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 08/15] ice: Add support for switch filter programming Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 09/15] ice: Configure VSIs for Tx/Rx Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-10 16:39 ` [Intel-wired-lan] " Stephen Hemminger
2018-03-10 16:39 ` Stephen Hemminger
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 10/15] ice: Implement transmit and NAPI support Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 11/15] ice: Add support for VLANs and offloads Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 12/15] ice: Add stats and ethtool support Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-09 18:14 ` [Intel-wired-lan] " Andrew Lunn
2018-03-09 18:14 ` Andrew Lunn
2018-03-09 23:14 ` [Intel-wired-lan] " Jakub Kicinski
2018-03-09 23:14 ` Jakub Kicinski
2018-03-10 2:35 ` [Intel-wired-lan] " David Miller
2018-03-10 2:35 ` David Miller
2018-03-13 19:05 ` [Intel-wired-lan] " Venkataramanan, Anirudh
2018-03-13 19:05 ` Venkataramanan, Anirudh
2018-03-13 19:17 ` [Intel-wired-lan] " Eric Dumazet
2018-03-13 19:17 ` Eric Dumazet
2018-03-13 21:14 ` [Intel-wired-lan] " Jesse Brandeburg
2018-03-13 21:14 ` Jesse Brandeburg
2018-03-13 21:44 ` Eric Dumazet
2018-03-13 21:44 ` Eric Dumazet
2018-03-14 1:30 ` Toshiaki Makita
2018-03-14 1:30 ` Toshiaki Makita
2018-03-14 15:13 ` Stephen Hemminger
2018-03-14 15:13 ` Stephen Hemminger
2018-03-13 20:54 ` David Miller
2018-03-13 20:54 ` David Miller
2018-03-10 16:37 ` [Intel-wired-lan] " Stephen Hemminger
2018-03-10 16:37 ` Stephen Hemminger
2018-03-10 16:42 ` Stephen Hemminger [this message]
2018-03-10 16:42 ` Stephen Hemminger
2018-03-13 20:42 ` [Intel-wired-lan] " Venkataramanan, Anirudh
2018-03-13 20:42 ` Venkataramanan, Anirudh
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 13/15] ice: Update Tx scheduler tree for VSI multi-Tx queue support Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 14/15] ice: Support link events, reset and rebuild Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-09 17:21 ` [Intel-wired-lan] [PATCH 15/15] ice: Implement filter sync, NDO operations and bump version Anirudh Venkataramanan
2018-03-09 17:21 ` Anirudh Venkataramanan
2018-03-09 18:23 ` [Intel-wired-lan] [PATCH 00/15] Add ice driver David Miller
2018-03-09 18:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180310084243.4584ccd9@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.