From: Borislav Petkov <bp@alien8.de>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: EDAC, sb_edac: Remove VLA usage
Date: Sat, 10 Mar 2018 15:04:34 +0100 [thread overview]
Message-ID: <20180310140434.GC8261@pd.tnic> (raw)
On Fri, Mar 09, 2018 at 09:02:18PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA and replace it
> with a fixed-length array instead.
>
> Fixed as part of the directive to remove all VLAs from
> the kernel: https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>
> Notice that due to this change, the field max_interleave is no longer
> used after it has been initialized. Maybe it should be removed?
Yes.
> @@ -110,6 +110,7 @@ static const u32 knl_interleave_list[] = {
> 0xdc, 0xe4, 0xec, 0xf4, 0xfc, /* 15-19 */
> 0x104, 0x10c, 0x114, 0x11c, /* 20-23 */
> };
> +#define MAX_INTERLEAVE ARRAY_SIZE(knl_interleave_list)
define that as the max of all interleave lists array sizes so that
people can update it properly when new interleave lists get added.
WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] EDAC, sb_edac: Remove VLA usage
Date: Sat, 10 Mar 2018 15:04:34 +0100 [thread overview]
Message-ID: <20180310140434.GC8261@pd.tnic> (raw)
In-Reply-To: <20180309235654.GA9887@embeddedor.com>
On Fri, Mar 09, 2018 at 09:02:18PM -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA and replace it
> with a fixed-length array instead.
>
> Fixed as part of the directive to remove all VLAs from
> the kernel: https://lkml.org/lkml/2018/3/7/621
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
> ---
>
> Notice that due to this change, the field max_interleave is no longer
> used after it has been initialized. Maybe it should be removed?
Yes.
> @@ -110,6 +110,7 @@ static const u32 knl_interleave_list[] = {
> 0xdc, 0xe4, 0xec, 0xf4, 0xfc, /* 15-19 */
> 0x104, 0x10c, 0x114, 0x11c, /* 20-23 */
> };
> +#define MAX_INTERLEAVE ARRAY_SIZE(knl_interleave_list)
define that as the max of all interleave lists array sizes so that
people can update it properly when new interleave lists get added.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next reply other threads:[~2018-03-10 14:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 14:04 Borislav Petkov [this message]
2018-03-10 14:04 ` [PATCH] EDAC, sb_edac: Remove VLA usage Borislav Petkov
-- strict thread matches above, loose matches on Subject: below --
2018-03-13 11:08 Gustavo A. R. Silva
2018-03-13 11:08 ` [PATCH] " Gustavo A. R. Silva
2018-03-13 10:48 Borislav Petkov
2018-03-13 10:48 ` [PATCH] " Borislav Petkov
2018-03-12 22:52 Gustavo A. R. Silva
2018-03-12 22:52 ` [PATCH] " Gustavo A. R. Silva
2018-03-10 3:02 Gustavo A. R. Silva
2018-03-10 3:02 ` [PATCH] " Gustavo A. R. Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180310140434.GC8261@pd.tnic \
--to=bp@alien8.de \
--cc=garsilva@embeddedor.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.