From: hch@lst.de (Christoph Hellwig)
Subject: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support
Date: Tue, 13 Mar 2018 09:54:42 +0100 [thread overview]
Message-ID: <20180313085442.GA1537@lst.de> (raw)
In-Reply-To: <1520930719.11412.2.camel@infradead.org>
On Tue, Mar 13, 2018@08:45:19AM +0000, David Woodhouse wrote:
>
>
> On Tue, 2018-03-13@09:16 +0100, Christoph Hellwig wrote:
> > On Tue, Mar 13, 2018@08:12:52AM +0000, David Woodhouse wrote:
> > >
> > > I'd also *really* like to see a way to enable this for PFs which don't
> > > have (and don't need) a driver. We seem to have lost that along the
> > > way.
> > We've been forth and back on that.??I agree that not having any driver
> > just seems dangerous.??If your PF really does nothing we should just
> > have a trivial pf_stub driver that does nothing but wiring up
> > pci_sriov_configure_simple.??We can then add PCI IDs to it either
> > statically, or using the dynamic ids mechanism.
>
> Or just add it to the existing pci-stub. What's the point in having a
> new driver??
Because binding to pci-stub means that you'd now enable the simple
SR-IOV for any device bound to PCI stub. Which often might be the wrong
thing.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Christoph Hellwig <hch@lst.de>,
Alexander Duyck <alexander.duyck@gmail.com>,
bhelgaas@google.com, alexander.h.duyck@intel.com,
linux-pci@vger.kernel.org, virtio-dev@lists.oasis-open.org,
kvm@vger.kernel.org, netdev@vger.kernel.org, dan.daly@intel.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
keith.busch@intel.com, netanel@amazon.com, mheyne@amazon.de,
liang-min.wang@intel.com, mark.d.rustad@intel.com
Subject: Re: [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support
Date: Tue, 13 Mar 2018 09:54:42 +0100 [thread overview]
Message-ID: <20180313085442.GA1537@lst.de> (raw)
In-Reply-To: <1520930719.11412.2.camel@infradead.org>
On Tue, Mar 13, 2018 at 08:45:19AM +0000, David Woodhouse wrote:
>
>
> On Tue, 2018-03-13 at 09:16 +0100, Christoph Hellwig wrote:
> > On Tue, Mar 13, 2018 at 08:12:52AM +0000, David Woodhouse wrote:
> > >
> > > I'd also *really* like to see a way to enable this for PFs which don't
> > > have (and don't need) a driver. We seem to have lost that along the
> > > way.
> > We've been forth and back on that. I agree that not having any driver
> > just seems dangerous. If your PF really does nothing we should just
> > have a trivial pf_stub driver that does nothing but wiring up
> > pci_sriov_configure_simple. We can then add PCI IDs to it either
> > statically, or using the dynamic ids mechanism.
>
> Or just add it to the existing pci-stub. What's the point in having a
> new driver?
Because binding to pci-stub means that you'd now enable the simple
SR-IOV for any device bound to PCI stub. Which often might be the wrong
thing.
next prev parent reply other threads:[~2018-03-13 8:54 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 17:20 [pci PATCH v5 0/4] Series short description Alexander Duyck
2018-03-12 17:20 ` [virtio-dev] " Alexander Duyck
2018-03-12 17:20 ` Alexander Duyck
2018-03-12 17:21 ` [pci PATCH v5 1/4] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources Alexander Duyck
2018-03-12 17:21 ` [virtio-dev] " Alexander Duyck
2018-03-12 17:21 ` Alexander Duyck
2018-03-12 17:40 ` Keith Busch
2018-03-12 17:40 ` Keith Busch
2018-03-12 18:09 ` Alexander Duyck
2018-03-12 18:09 ` [virtio-dev] " Alexander Duyck
2018-03-12 18:09 ` Alexander Duyck
2018-03-12 18:23 ` Keith Busch
2018-03-12 18:23 ` Keith Busch
2018-03-12 20:17 ` Alexander Duyck
2018-03-12 20:17 ` [virtio-dev] " Alexander Duyck
2018-03-12 20:17 ` Alexander Duyck
2018-03-13 7:44 ` Christoph Hellwig
2018-03-13 7:44 ` Christoph Hellwig
2018-03-12 17:23 ` [pci PATCH v5 2/4] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices Alexander Duyck
2018-03-12 17:23 ` [virtio-dev] " Alexander Duyck
2018-03-12 17:23 ` Alexander Duyck
2018-03-12 17:23 ` [pci PATCH v5 3/4] ena: Migrate over to unmanaged SR-IOV support Alexander Duyck
2018-03-12 17:23 ` [virtio-dev] " Alexander Duyck
2018-03-12 17:23 ` Alexander Duyck
2018-03-13 8:12 ` David Woodhouse
2018-03-13 8:12 ` David Woodhouse
2018-03-13 8:16 ` Christoph Hellwig
2018-03-13 8:16 ` Christoph Hellwig
2018-03-13 8:45 ` David Woodhouse
2018-03-13 8:45 ` David Woodhouse
2018-03-13 8:54 ` Christoph Hellwig [this message]
2018-03-13 8:54 ` Christoph Hellwig
2018-03-13 9:14 ` David Woodhouse
2018-03-13 9:14 ` David Woodhouse
2018-03-13 14:51 ` Alexander Duyck
2018-03-13 14:51 ` [virtio-dev] " Alexander Duyck
2018-03-13 14:51 ` Alexander Duyck
2018-03-13 15:04 ` David Woodhouse
2018-03-13 15:04 ` David Woodhouse
2018-03-13 16:17 ` Don Dutile
2018-03-13 16:17 ` Don Dutile
2018-03-12 17:23 ` [pci PATCH v5 4/4] nvme: " Alexander Duyck
2018-03-12 17:23 ` [virtio-dev] " Alexander Duyck
2018-03-12 17:23 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313085442.GA1537@lst.de \
--to=hch@lst.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.