* [PATCH] mt7601u: simplify mt7601u_mcu_msg_alloc signature [not found] <cover.1520414446.git.lorenzo.bianconi@redhat.com> @ 2018-03-07 9:25 ` Lorenzo Bianconi 2018-03-07 18:18 ` Jakub Kicinski 2018-03-13 16:34 ` Kalle Valo 0 siblings, 2 replies; 3+ messages in thread From: Lorenzo Bianconi @ 2018-03-07 9:25 UTC (permalink / raw) To: kubakici; +Cc: linux-wireless Remove mt7601u_dev parameter from mt7601u_mcu_msg_alloc signature since dev pointer is never used in routine body Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> --- drivers/net/wireless/mediatek/mt7601u/mcu.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/wireless/mediatek/mt7601u/mcu.c b/drivers/net/wireless/mediatek/mt7601u/mcu.c index 65a8004418ea..d9d6fd7eff5e 100644 --- a/drivers/net/wireless/mediatek/mt7601u/mcu.c +++ b/drivers/net/wireless/mediatek/mt7601u/mcu.c @@ -58,8 +58,7 @@ static inline void trace_mt_mcu_msg_send_cs(struct mt7601u_dev *dev, trace_mt_mcu_msg_send(dev, skb, csum, need_resp); } -static struct sk_buff * -mt7601u_mcu_msg_alloc(struct mt7601u_dev *dev, const void *data, int len) +static struct sk_buff *mt7601u_mcu_msg_alloc(const void *data, int len) { struct sk_buff *skb; @@ -171,7 +170,7 @@ static int mt7601u_mcu_function_select(struct mt7601u_dev *dev, .value = cpu_to_le32(val), }; - skb = mt7601u_mcu_msg_alloc(dev, &msg, sizeof(msg)); + skb = mt7601u_mcu_msg_alloc(&msg, sizeof(msg)); if (!skb) return -ENOMEM; return mt7601u_mcu_msg_send(dev, skb, CMD_FUN_SET_OP, func == 5); @@ -208,7 +207,7 @@ mt7601u_mcu_calibrate(struct mt7601u_dev *dev, enum mcu_calibrate cal, u32 val) .value = cpu_to_le32(val), }; - skb = mt7601u_mcu_msg_alloc(dev, &msg, sizeof(msg)); + skb = mt7601u_mcu_msg_alloc(&msg, sizeof(msg)); if (!skb) return -ENOMEM; return mt7601u_mcu_msg_send(dev, skb, CMD_CALIBRATION_OP, true); -- 2.14.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mt7601u: simplify mt7601u_mcu_msg_alloc signature 2018-03-07 9:25 ` [PATCH] mt7601u: simplify mt7601u_mcu_msg_alloc signature Lorenzo Bianconi @ 2018-03-07 18:18 ` Jakub Kicinski 2018-03-13 16:34 ` Kalle Valo 1 sibling, 0 replies; 3+ messages in thread From: Jakub Kicinski @ 2018-03-07 18:18 UTC (permalink / raw) To: Lorenzo Bianconi; +Cc: linux-wireless On Wed, 7 Mar 2018 10:25:50 +0100, Lorenzo Bianconi wrote: > Remove mt7601u_dev parameter from mt7601u_mcu_msg_alloc signature since > dev pointer is never used in routine body > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> Acked-by: Jakub Kicinski <kubakici@wp.pl> ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: mt7601u: simplify mt7601u_mcu_msg_alloc signature 2018-03-07 9:25 ` [PATCH] mt7601u: simplify mt7601u_mcu_msg_alloc signature Lorenzo Bianconi 2018-03-07 18:18 ` Jakub Kicinski @ 2018-03-13 16:34 ` Kalle Valo 1 sibling, 0 replies; 3+ messages in thread From: Kalle Valo @ 2018-03-13 16:34 UTC (permalink / raw) To: Lorenzo Bianconi; +Cc: kubakici, linux-wireless Lorenzo Bianconi <lorenzo.bianconi@redhat.com> wrote: > Remove mt7601u_dev parameter from mt7601u_mcu_msg_alloc signature since > dev pointer is never used in routine body > > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com> > Acked-by: Jakub Kicinski <kubakici@wp.pl> Patch applied to wireless-drivers-next.git, thanks. 2f04652f891a mt7601u: simplify mt7601u_mcu_msg_alloc signature -- https://patchwork.kernel.org/patch/10263687/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-13 16:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1520414446.git.lorenzo.bianconi@redhat.com>
2018-03-07 9:25 ` [PATCH] mt7601u: simplify mt7601u_mcu_msg_alloc signature Lorenzo Bianconi
2018-03-07 18:18 ` Jakub Kicinski
2018-03-13 16:34 ` Kalle Valo
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.