All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/8] xfs: don't use XFS_BMAPI_ENTRIRE in xfs_get_blocks
Date: Tue, 13 Mar 2018 13:44:36 -0700	[thread overview]
Message-ID: <20180313204436.GD4865@magnolia> (raw)
In-Reply-To: <20180313143601.30028-3-hch@lst.de>

On Tue, Mar 13, 2018 at 03:35:55PM +0100, Christoph Hellwig wrote:
> There is no reason to get a mapping bigger than what we were asked for.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Looks ok, will test...
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/xfs/xfs_aops.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c
> index a0afb6411417..c79a3ca20ef8 100644
> --- a/fs/xfs/xfs_aops.c
> +++ b/fs/xfs/xfs_aops.c
> @@ -1331,8 +1331,8 @@ xfs_get_blocks(
>  	end_fsb = XFS_B_TO_FSB(mp, (xfs_ufsize_t)offset + size);
>  	offset_fsb = XFS_B_TO_FSBT(mp, offset);
>  
> -	error = xfs_bmapi_read(ip, offset_fsb, end_fsb - offset_fsb,
> -				&imap, &nimaps, XFS_BMAPI_ENTIRE);
> +	error = xfs_bmapi_read(ip, offset_fsb, end_fsb - offset_fsb, &imap,
> +			&nimaps, 0);
>  	if (error)
>  		goto out_unlock;
>  
> -- 
> 2.14.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-03-13 20:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 14:35 misc fixes and cleanups Christoph Hellwig
2018-03-13 14:35 ` [PATCH 1/8] xfs: fix the check for COW extents in xfs_swap_extents Christoph Hellwig
2018-03-13 20:42   ` Darrick J. Wong
2018-03-13 14:35 ` [PATCH 2/8] xfs: don't use XFS_BMAPI_ENTRIRE in xfs_get_blocks Christoph Hellwig
2018-03-13 20:44   ` Darrick J. Wong [this message]
2018-03-13 14:35 ` [PATCH 3/8] xfs: assert that xfs_reflink_allocate_cow is called with XFS_ILOCK_EXCL Christoph Hellwig
2018-03-13 20:45   ` Darrick J. Wong
2018-03-13 14:35 ` [PATCH 4/8] xfs: remove xfs_zero_range Christoph Hellwig
2018-03-13 20:45   ` Darrick J. Wong
2018-03-13 14:35 ` [PATCH 5/8] xfs: minor cleanup for xfs_get_blocks Christoph Hellwig
2018-03-13 20:45   ` Darrick J. Wong
2018-03-13 14:35 ` [PATCH 6/8] xfs: minor cleanup for xfs_reflink_end_cow Christoph Hellwig
2018-03-13 20:46   ` Darrick J. Wong
2018-03-13 14:36 ` [PATCH 7/8] xfs: mark xfs_reflink_clear_inode_flag static Christoph Hellwig
2018-03-13 20:50   ` Darrick J. Wong
2018-03-14  8:42     ` Christoph Hellwig
2018-03-13 14:36 ` [PATCH 8/8] xfs: only clear preallocated COW blocks in xfs_reflink_clear_inode_flag Christoph Hellwig
2018-03-13 20:56   ` Darrick J. Wong
2018-03-14  8:42     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180313204436.GD4865@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=hch@lst.de \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.