From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 7/8] xfs: mark xfs_reflink_clear_inode_flag static
Date: Tue, 13 Mar 2018 13:50:53 -0700 [thread overview]
Message-ID: <20180313205053.GI4865@magnolia> (raw)
In-Reply-To: <20180313143601.30028-8-hch@lst.de>
On Tue, Mar 13, 2018 at 03:36:00PM +0100, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/xfs/xfs_reflink.c | 2 +-
> fs/xfs/xfs_reflink.h | 2 --
> 2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c
> index cdbd342a5249..85d3379a81df 100644
> --- a/fs/xfs/xfs_reflink.c
> +++ b/fs/xfs/xfs_reflink.c
> @@ -1552,7 +1552,7 @@ xfs_reflink_inode_has_shared_extents(
> }
>
> /* Clear the inode reflink flag if there are no shared extents. */
> -int
> +static int
Online inode repair/optimization will call this function (see
xfs_repair_inode in scrub/inode_repair.c in the online repair series),
so I'd prefer not to add static only to have to pull it out later.
(Granted, nobody's commented on any of online repair afaict...)
--D
> xfs_reflink_clear_inode_flag(
> struct xfs_inode *ip,
> struct xfs_trans **tpp)
> diff --git a/fs/xfs/xfs_reflink.h b/fs/xfs/xfs_reflink.h
> index 701487bab468..7d6d34a30200 100644
> --- a/fs/xfs/xfs_reflink.h
> +++ b/fs/xfs/xfs_reflink.h
> @@ -49,8 +49,6 @@ extern int xfs_reflink_remap_range(struct file *file_in, loff_t pos_in,
> struct file *file_out, loff_t pos_out, u64 len, bool is_dedupe);
> extern int xfs_reflink_inode_has_shared_extents(struct xfs_trans *tp,
> struct xfs_inode *ip, bool *has_shared);
> -extern int xfs_reflink_clear_inode_flag(struct xfs_inode *ip,
> - struct xfs_trans **tpp);
> extern int xfs_reflink_unshare(struct xfs_inode *ip, xfs_off_t offset,
> xfs_off_t len);
>
> --
> 2.14.2
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-13 20:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 14:35 misc fixes and cleanups Christoph Hellwig
2018-03-13 14:35 ` [PATCH 1/8] xfs: fix the check for COW extents in xfs_swap_extents Christoph Hellwig
2018-03-13 20:42 ` Darrick J. Wong
2018-03-13 14:35 ` [PATCH 2/8] xfs: don't use XFS_BMAPI_ENTRIRE in xfs_get_blocks Christoph Hellwig
2018-03-13 20:44 ` Darrick J. Wong
2018-03-13 14:35 ` [PATCH 3/8] xfs: assert that xfs_reflink_allocate_cow is called with XFS_ILOCK_EXCL Christoph Hellwig
2018-03-13 20:45 ` Darrick J. Wong
2018-03-13 14:35 ` [PATCH 4/8] xfs: remove xfs_zero_range Christoph Hellwig
2018-03-13 20:45 ` Darrick J. Wong
2018-03-13 14:35 ` [PATCH 5/8] xfs: minor cleanup for xfs_get_blocks Christoph Hellwig
2018-03-13 20:45 ` Darrick J. Wong
2018-03-13 14:35 ` [PATCH 6/8] xfs: minor cleanup for xfs_reflink_end_cow Christoph Hellwig
2018-03-13 20:46 ` Darrick J. Wong
2018-03-13 14:36 ` [PATCH 7/8] xfs: mark xfs_reflink_clear_inode_flag static Christoph Hellwig
2018-03-13 20:50 ` Darrick J. Wong [this message]
2018-03-14 8:42 ` Christoph Hellwig
2018-03-13 14:36 ` [PATCH 8/8] xfs: only clear preallocated COW blocks in xfs_reflink_clear_inode_flag Christoph Hellwig
2018-03-13 20:56 ` Darrick J. Wong
2018-03-14 8:42 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313205053.GI4865@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.