All of lore.kernel.org
 help / color / mirror / Atom feed
From: hch@lst.de (Christoph Hellwig)
Subject: [pci PATCH v6 5/5] pci-pf-stub: Add PF driver stub for PFs that function only to enable VFs
Date: Wed, 14 Mar 2018 09:56:01 +0100	[thread overview]
Message-ID: <20180314085601.GD28796@lst.de> (raw)
In-Reply-To: <20180313213054.3553.89366.stgit@localhost.localdomain>

> +
> +/**
> + * pci_pf_stub_white_list - White list of devices to bind pci-pf-stub onto
> + *
> + * This table provides the list of IDs this driver is supposed to bind
> + * onto. You could think of this as a list of "quirked" devices where we
> + * are adding support for SR-IOV here since there are no other drivers
> + * that they would be running under.
> + *
> + * Layout of the table below is as follows:
> + * { Vendor ID, Device ID,
> + *   SubVendor ID, SubDevice ID,
> + *   Class, Class Mask,
> + *   private data (not used) }
> + */

No need to document the PCI device table format in a random driver.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch at lst.de>

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Alexander Duyck <alexander.duyck@gmail.com>
Cc: bhelgaas@google.com, alexander.h.duyck@intel.com,
	linux-pci@vger.kernel.org, virtio-dev@lists.oasis-open.org,
	kvm@vger.kernel.org, netdev@vger.kernel.org, dan.daly@intel.com,
	linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
	keith.busch@intel.com, netanel@amazon.com, ddutile@redhat.com,
	mheyne@amazon.de, liang-min.wang@intel.com,
	mark.d.rustad@intel.com, dwmw2@infradead.org, hch@lst.de,
	dwmw@amazon.co.uk
Subject: Re: [pci PATCH v6 5/5] pci-pf-stub: Add PF driver stub for PFs that function only to enable VFs
Date: Wed, 14 Mar 2018 09:56:01 +0100	[thread overview]
Message-ID: <20180314085601.GD28796@lst.de> (raw)
In-Reply-To: <20180313213054.3553.89366.stgit@localhost.localdomain>

> +
> +/**
> + * pci_pf_stub_white_list - White list of devices to bind pci-pf-stub onto
> + *
> + * This table provides the list of IDs this driver is supposed to bind
> + * onto. You could think of this as a list of "quirked" devices where we
> + * are adding support for SR-IOV here since there are no other drivers
> + * that they would be running under.
> + *
> + * Layout of the table below is as follows:
> + * { Vendor ID, Device ID,
> + *   SubVendor ID, SubDevice ID,
> + *   Class, Class Mask,
> + *   private data (not used) }
> + */

No need to document the PCI device table format in a random driver.

Otherwise looks fine:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2018-03-14  8:56 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 21:27 [pci PATCH v6 0/5] Add support for unmanaged SR-IOV Alexander Duyck
2018-03-13 21:27 ` [virtio-dev] " Alexander Duyck
2018-03-13 21:27 ` Alexander Duyck
2018-03-13 21:28 ` [pci PATCH v6 1/5] pci: Add pci_sriov_configure_simple for PFs that don't manage VF resources Alexander Duyck
2018-03-13 21:28   ` [virtio-dev] " Alexander Duyck
2018-03-13 21:28   ` Alexander Duyck
2018-03-14  8:54   ` Christoph Hellwig
2018-03-14  8:54     ` Christoph Hellwig
2018-03-14 15:28     ` Alexander Duyck
2018-03-14 15:28       ` [virtio-dev] " Alexander Duyck
2018-03-14 15:28       ` Alexander Duyck
2018-03-13 21:29 ` [pci PATCH v6 2/5] virtio_pci: Add support for unmanaged SR-IOV on virtio_pci devices Alexander Duyck
2018-03-13 21:29   ` [virtio-dev] " Alexander Duyck
2018-03-13 21:29   ` Alexander Duyck
2018-03-14  8:54   ` Christoph Hellwig
2018-03-14  8:54     ` Christoph Hellwig
2018-03-13 21:30 ` [pci PATCH v6 3/5] ena: Migrate over to unmanaged SR-IOV support Alexander Duyck
2018-03-13 21:30   ` [virtio-dev] " Alexander Duyck
2018-03-13 21:30   ` Alexander Duyck
2018-03-13 21:30 ` [pci PATCH v6 4/5] nvme: " Alexander Duyck
2018-03-13 21:30   ` [virtio-dev] " Alexander Duyck
2018-03-13 21:30   ` Alexander Duyck
2018-03-14  8:54   ` Christoph Hellwig
2018-03-14  8:54     ` Christoph Hellwig
2018-03-13 21:31 ` [pci PATCH v6 5/5] pci-pf-stub: Add PF driver stub for PFs that function only to enable VFs Alexander Duyck
2018-03-13 21:31   ` [virtio-dev] " Alexander Duyck
2018-03-13 21:31   ` Alexander Duyck
2018-03-14  8:56   ` Christoph Hellwig [this message]
2018-03-14  8:56     ` Christoph Hellwig
2018-03-14 15:31     ` Alexander Duyck
2018-03-14 15:31       ` [virtio-dev] " Alexander Duyck
2018-03-14 15:31       ` Alexander Duyck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314085601.GD28796@lst.de \
    --to=hch@lst.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.