All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: YOUNGKEUN OH <y.k.oh@samsung.com>
Cc: jslaby@suse.com, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] serial: samsung: macros with complex values should be enclosed in parentheses
Date: Wed, 14 Mar 2018 13:58:04 +0000	[thread overview]
Message-ID: <20180314135804.GA21350@kroah.com> (raw)
In-Reply-To: <1520993825-8605-1-git-send-email-y.k.oh@samsung.com>

On Wed, Mar 14, 2018 at 11:17:05AM +0900, YOUNGKEUN OH wrote:
> Cleanup checkpatch error:
> ERROR: Macros with complex values should be enclosed in parentheses
> 
> Signed-off-by: YOUNGKEUN OH <y.k.oh@samsung.com>
> ---
>  drivers/tty/serial/samsung.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 3f2f8c1..da9bddb1 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1455,7 +1455,7 @@ static int __init s3c24xx_serial_console_init(void)
>  }
>  console_initcall(s3c24xx_serial_console_init);
> 
> -#define S3C24XX_SERIAL_CONSOLE &s3c24xx_serial_console
> +#define S3C24XX_SERIAL_CONSOLE (&s3c24xx_serial_console)

That's not a complex macro!

Please use checkpatch as a hint, not the "truth".

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: YOUNGKEUN OH <y.k.oh@samsung.com>
Cc: jslaby@suse.com, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] serial: samsung: macros with complex values should be enclosed in parentheses
Date: Wed, 14 Mar 2018 14:58:04 +0100	[thread overview]
Message-ID: <20180314135804.GA21350@kroah.com> (raw)
In-Reply-To: <1520993825-8605-1-git-send-email-y.k.oh@samsung.com>

On Wed, Mar 14, 2018 at 11:17:05AM +0900, YOUNGKEUN OH wrote:
> Cleanup checkpatch error:
> ERROR: Macros with complex values should be enclosed in parentheses
> 
> Signed-off-by: YOUNGKEUN OH <y.k.oh@samsung.com>
> ---
>  drivers/tty/serial/samsung.c | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/tty/serial/samsung.c b/drivers/tty/serial/samsung.c
> index 3f2f8c1..da9bddb1 100644
> --- a/drivers/tty/serial/samsung.c
> +++ b/drivers/tty/serial/samsung.c
> @@ -1455,7 +1455,7 @@ static int __init s3c24xx_serial_console_init(void)
>  }
>  console_initcall(s3c24xx_serial_console_init);
> 
> -#define S3C24XX_SERIAL_CONSOLE &s3c24xx_serial_console
> +#define S3C24XX_SERIAL_CONSOLE (&s3c24xx_serial_console)

That's not a complex macro!

Please use checkpatch as a hint, not the "truth".

thanks,

greg k-h

  reply	other threads:[~2018-03-14 13:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180314021710epcas1p3766602fe312f87d916cab69af2acf203@epcas1p3.samsung.com>
2018-03-14  2:17 ` [PATCH] serial: samsung: macros with complex values should be enclosed in parentheses YOUNGKEUN OH
2018-03-14  2:17   ` YOUNGKEUN OH
2018-03-14 13:58   ` Greg KH [this message]
2018-03-14 13:58     ` Greg KH
2018-03-22  4:37     ` y.k.oh
2018-03-22  4:37       ` y.k.oh
2018-03-22  4:45       ` Joe Perches
2018-03-22  4:45         ` Joe Perches
2018-03-22  8:45       ` Greg KH
2018-03-22  8:45         ` Greg KH
2018-03-22  9:04         ` YOUNGKEUN OH
2018-03-22  9:04           ` YOUNGKEUN OH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314135804.GA21350@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=y.k.oh@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.