From: "Serge E. Hallyn" <serge@hallyn.com>
To: Stefan Berger <stefanb@linux.vnet.ibm.com>
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
Mimi Zohar <zohar@linux.vnet.ibm.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
Seth Forshee <seth.forshee@canonical.com>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Dongsu Park <dongsu@kinvolk.io>, Alban Crequy <alban@kinvolk.io>
Subject: Re: [PATCH v3 4/4] fuse: define the filesystem as untrusted
Date: Wed, 14 Mar 2018 09:27:01 -0500 [thread overview]
Message-ID: <20180314142701.GA6497@mail.hallyn.com> (raw)
In-Reply-To: <1fd04e0e-37ab-329c-c75d-d349a3b2f136@linux.vnet.ibm.com>
Quoting Stefan Berger (stefanb@linux.vnet.ibm.com):
> On 03/12/2018 03:29 PM, Serge E. Hallyn wrote:
> >Quoting Mimi Zohar (zohar@linux.vnet.ibm.com):
> >>Files on FUSE can change at any point in time without IMA being able
> >>to detect it. The file data read for the file signature verification
> >>could be totally different from what is subsequently read, making the
> >>signature verification useless.
> >>
> >>FUSE can be mounted by unprivileged users either today with fusermount
> >>installed with setuid, or soon with the upcoming patches to allow FUSE
> >>mounts in a non-init user namespace.
> >>
> >>This patch sets the SB_I_IMA_UNVERIFIABLE_SIGNATURE flag and when
> >>appropriate sets the SB_I_UNTRUSTED_MOUNTER flag.
> >>
> >>Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
> >>Cc: Miklos Szeredi <miklos@szeredi.hu>
> >>Cc: Seth Forshee <seth.forshee@canonical.com>
> >>Cc: Eric W. Biederman <ebiederm@xmission.com>
> >>Cc: Dongsu Park <dongsu@kinvolk.io>
> >>Cc: Alban Crequy <alban@kinvolk.io>
> >>Cc: "Serge E. Hallyn" <serge@hallyn.com>
> >Acked-by: Serge Hallyn <serge@hallyn.com>
> >
> >Of course when IMA namespacing hits, you'll want to compare the
> >sb->s_user_ns to the (~handwaving~) user_ns owning the ima ns
> >right?
>
> I suppose this would be the only way to enable 'trusted mounters'
> within IMA namespaces. Maybe there could be an additional capability
> gate that would allow one to be a 'trusted mounter' then?
Wouldn't CAP_SYS_ADMIN to the ima_ns->user_ns suffice?
I personally think CAP_INTEGRITY would make sense, but right
now CAP_SYS_ADMIN seems to suffice so it wouldn't make sense to
raise the bar there unless we raise it for all of IMA configuration.
-serge
WARNING: multiple messages have this Message-ID (diff)
From: serge@hallyn.com (Serge E. Hallyn)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v3 4/4] fuse: define the filesystem as untrusted
Date: Wed, 14 Mar 2018 09:27:01 -0500 [thread overview]
Message-ID: <20180314142701.GA6497@mail.hallyn.com> (raw)
In-Reply-To: <1fd04e0e-37ab-329c-c75d-d349a3b2f136@linux.vnet.ibm.com>
Quoting Stefan Berger (stefanb at linux.vnet.ibm.com):
> On 03/12/2018 03:29 PM, Serge E. Hallyn wrote:
> >Quoting Mimi Zohar (zohar at linux.vnet.ibm.com):
> >>Files on FUSE can change at any point in time without IMA being able
> >>to detect it. The file data read for the file signature verification
> >>could be totally different from what is subsequently read, making the
> >>signature verification useless.
> >>
> >>FUSE can be mounted by unprivileged users either today with fusermount
> >>installed with setuid, or soon with the upcoming patches to allow FUSE
> >>mounts in a non-init user namespace.
> >>
> >>This patch sets the SB_I_IMA_UNVERIFIABLE_SIGNATURE flag and when
> >>appropriate sets the SB_I_UNTRUSTED_MOUNTER flag.
> >>
> >>Signed-off-by: Mimi Zohar <zohar@linux.vnet.ibm.com>
> >>Cc: Miklos Szeredi <miklos@szeredi.hu>
> >>Cc: Seth Forshee <seth.forshee@canonical.com>
> >>Cc: Eric W. Biederman <ebiederm@xmission.com>
> >>Cc: Dongsu Park <dongsu@kinvolk.io>
> >>Cc: Alban Crequy <alban@kinvolk.io>
> >>Cc: "Serge E. Hallyn" <serge@hallyn.com>
> >Acked-by: Serge Hallyn <serge@hallyn.com>
> >
> >Of course when IMA namespacing hits, you'll want to compare the
> >sb->s_user_ns to the (~handwaving~) user_ns owning the ima ns
> >right?
>
> I suppose this would be the only way to enable 'trusted mounters'
> within IMA namespaces. Maybe there could be an additional capability
> gate that would allow one to be a 'trusted mounter' then?
Wouldn't CAP_SYS_ADMIN to the ima_ns->user_ns suffice?
I personally think CAP_INTEGRITY would make sense, but right
now CAP_SYS_ADMIN seems to suffice so it wouldn't make sense to
raise the bar there unless we raise it for all of IMA configuration.
-serge
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-14 14:27 UTC|newest]
Thread overview: 71+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 20:24 [PATCH v3 0/4] unverifiable file signatures Mimi Zohar
2018-03-08 20:24 ` Mimi Zohar
2018-03-08 20:24 ` [PATCH v3 1/4] ima: fail file signature verification on non-init mounted filesystems Mimi Zohar
2018-03-08 20:24 ` Mimi Zohar
2018-03-12 19:17 ` Serge E. Hallyn
2018-03-12 19:17 ` Serge E. Hallyn
2018-03-12 19:26 ` Serge E. Hallyn
2018-03-12 19:26 ` Serge E. Hallyn
2018-03-13 18:45 ` Eric W. Biederman
2018-03-13 18:45 ` Eric W. Biederman
2018-03-08 20:24 ` [PATCH v3 2/4] ima: re-evaluate files on privileged " Mimi Zohar
2018-03-08 20:24 ` Mimi Zohar
2018-03-12 19:18 ` Serge E. Hallyn
2018-03-12 19:18 ` Serge E. Hallyn
2018-03-13 19:24 ` Eric W. Biederman
2018-03-13 19:24 ` Eric W. Biederman
2018-03-08 20:24 ` [PATCH v3 3/4] ima: fail signature verification based on policy Mimi Zohar
2018-03-08 20:24 ` Mimi Zohar
2018-03-12 19:28 ` Serge E. Hallyn
2018-03-12 19:28 ` Serge E. Hallyn
2018-03-12 19:32 ` Mimi Zohar
2018-03-12 19:32 ` Mimi Zohar
2018-03-13 19:31 ` Eric W. Biederman
2018-03-13 19:31 ` Eric W. Biederman
2018-03-08 20:24 ` [PATCH v3 4/4] fuse: define the filesystem as untrusted Mimi Zohar
2018-03-08 20:24 ` Mimi Zohar
2018-03-12 19:29 ` Serge E. Hallyn
2018-03-12 19:29 ` Serge E. Hallyn
2018-03-13 14:46 ` Stefan Berger
2018-03-13 14:46 ` Stefan Berger
2018-03-14 14:27 ` Serge E. Hallyn [this message]
2018-03-14 14:27 ` Serge E. Hallyn
2018-03-14 14:37 ` Stefan Berger
2018-03-14 14:37 ` Stefan Berger
2018-03-13 19:32 ` Eric W. Biederman
2018-03-13 19:32 ` Eric W. Biederman
2018-03-19 11:57 ` Mimi Zohar
2018-03-19 11:57 ` Mimi Zohar
2018-03-19 11:57 ` Mimi Zohar
2018-03-14 7:52 ` Stef Bon
2018-03-14 7:52 ` Stef Bon
2018-03-14 13:01 ` Mimi Zohar
2018-03-14 13:01 ` Mimi Zohar
2018-03-14 16:17 ` Eric W. Biederman
2018-03-14 16:17 ` Eric W. Biederman
2018-03-14 17:50 ` Mimi Zohar
2018-03-14 17:50 ` Mimi Zohar
2018-03-14 17:50 ` Mimi Zohar
2018-03-14 18:08 ` Chuck Lever
2018-03-14 18:08 ` Chuck Lever
2018-03-14 19:46 ` Eric W. Biederman
2018-03-14 19:46 ` Eric W. Biederman
2018-03-14 20:34 ` Chuck Lever
2018-03-14 20:34 ` Chuck Lever
2018-03-14 21:42 ` Eric W. Biederman
2018-03-14 21:42 ` Eric W. Biederman
2018-03-14 22:53 ` Michael Halcrow
2018-03-14 22:53 ` Michael Halcrow
2018-03-15 21:24 ` Mimi Zohar
2018-03-15 21:24 ` Mimi Zohar
2018-03-15 21:24 ` Mimi Zohar
2018-03-15 10:07 ` Stef Bon
2018-03-15 10:07 ` Stef Bon
2018-03-15 13:53 ` Chuck Lever
2018-03-15 13:53 ` Chuck Lever
2018-03-15 22:05 ` Mimi Zohar
2018-03-15 22:05 ` Mimi Zohar
2018-03-13 19:40 ` [PATCH v3 0/4] unverifiable file signatures Eric W. Biederman
2018-03-13 19:40 ` Eric W. Biederman
2018-03-13 20:40 ` Mimi Zohar
2018-03-13 20:40 ` Mimi Zohar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314142701.GA6497@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=alban@kinvolk.io \
--cc=dongsu@kinvolk.io \
--cc=ebiederm@xmission.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=seth.forshee@canonical.com \
--cc=stefanb@linux.vnet.ibm.com \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.