All of lore.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: York Sun <york.sun@nxp.com>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC,1/2] drivers/edac: Add L1 and L2 error detection for A53 and A57
Date: Thu, 15 Mar 2018 02:07:28 +0100	[thread overview]
Message-ID: <20180315010728.GF11061@pd.tnic> (raw)

On Wed, Mar 14, 2018 at 05:17:46PM -0700, York Sun wrote:
> Add error detection for A53 and A57 cores. Hardware error injection
> is supported on A53. Software error injection is supported on both.
> For hardware error injection on A53 to work, proper access to
> L2ACTLR_EL1, CPUACTLR_EL1 needs to be granted by EL3 firmware. This
> is done by making an SMC call in the driver. Failure to enable access
> disables hardware error injection. For error interrupt to work,
> another SMC call enables access to L2ECTLR_EL1. Failure to enable
> access disables interrupt for error reporting.
> 
> Signed-off-by: York Sun <york.sun@nxp.com>
> ---
>  .../devicetree/bindings/edac/cortex-arm64-edac.txt |  37 +
>  arch/arm64/include/asm/cacheflush.h                |   1 +
>  arch/arm64/mm/cache.S                              |  35 +
>  drivers/edac/Kconfig                               |   6 +
>  drivers/edac/Makefile                              |   1 +
>  drivers/edac/cortex_arm64_l1_l2.c                  | 741 +++++++++++++++++++++

I don't want per-functional unit EDAC drivers. Also, what happened to
talking to ARM people about designing a generic ARM64 EDAC driver?

If this is going to be it, then it should be called edac_arm64.c and it
should contain all the architectural RAS functionality in it.

WARNING: multiple messages have this Message-ID (diff)
From: Borislav Petkov <bp@alien8.de>
To: York Sun <york.sun@nxp.com>
Cc: linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 1/2] drivers/edac: Add L1 and L2 error detection for A53 and A57
Date: Thu, 15 Mar 2018 02:07:28 +0100	[thread overview]
Message-ID: <20180315010728.GF11061@pd.tnic> (raw)
In-Reply-To: <1521073067-24348-1-git-send-email-york.sun@nxp.com>

On Wed, Mar 14, 2018 at 05:17:46PM -0700, York Sun wrote:
> Add error detection for A53 and A57 cores. Hardware error injection
> is supported on A53. Software error injection is supported on both.
> For hardware error injection on A53 to work, proper access to
> L2ACTLR_EL1, CPUACTLR_EL1 needs to be granted by EL3 firmware. This
> is done by making an SMC call in the driver. Failure to enable access
> disables hardware error injection. For error interrupt to work,
> another SMC call enables access to L2ECTLR_EL1. Failure to enable
> access disables interrupt for error reporting.
> 
> Signed-off-by: York Sun <york.sun@nxp.com>
> ---
>  .../devicetree/bindings/edac/cortex-arm64-edac.txt |  37 +
>  arch/arm64/include/asm/cacheflush.h                |   1 +
>  arch/arm64/mm/cache.S                              |  35 +
>  drivers/edac/Kconfig                               |   6 +
>  drivers/edac/Makefile                              |   1 +
>  drivers/edac/cortex_arm64_l1_l2.c                  | 741 +++++++++++++++++++++

I don't want per-functional unit EDAC drivers. Also, what happened to
talking to ARM people about designing a generic ARM64 EDAC driver?

If this is going to be it, then it should be called edac_arm64.c and it
should contain all the architectural RAS functionality in it.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.

             reply	other threads:[~2018-03-15  1:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15  1:07 Borislav Petkov [this message]
2018-03-15  1:07 ` [PATCH RFC 1/2] drivers/edac: Add L1 and L2 error detection for A53 and A57 Borislav Petkov
  -- strict thread matches above, loose matches on Subject: below --
2018-03-15 15:15 [RFC,1/2] " York Sun
2018-03-15 15:15 ` [PATCH RFC 1/2] " York Sun
2018-03-15 15:15 ` York Sun
2018-03-15 15:15 [RFC,1/2] " York Sun
2018-03-15 15:15 ` [PATCH RFC 1/2] " York Sun
2018-03-15 15:15 ` York Sun
2018-03-15 15:10 [RFC,1/2] " Mark Rutland
2018-03-15 15:10 ` [PATCH RFC 1/2] " Mark Rutland
2018-03-15 15:07 [RFC,1/2] " Mark Rutland
2018-03-15 15:07 ` [PATCH RFC 1/2] " Mark Rutland
2018-03-15 15:07 ` Mark Rutland
2018-03-15 14:55 [RFC,1/2] " York Sun
2018-03-15 14:55 ` [PATCH RFC 1/2] " York Sun
2018-03-15 13:33 [RFC,1/2] " James Morse
2018-03-15 13:33 ` [PATCH RFC 1/2] " James Morse
2018-03-15 13:33 ` James Morse
2018-03-15 10:17 [RFC,1/2] " Borislav Petkov
2018-03-15 10:17 ` [PATCH RFC 1/2] " Borislav Petkov
2018-03-15  1:20 [RFC,1/2] " York Sun
2018-03-15  1:20 ` [PATCH RFC 1/2] " York Sun
2018-03-15  0:17 [RFC,2/2] arm64: Update device tree for ls1043a and ls1046a to enable edac driver York Sun
2018-03-15  0:17 ` [PATCH RFC 2/2] " York Sun
2018-03-15  0:17 [RFC,1/2] drivers/edac: Add L1 and L2 error detection for A53 and A57 York Sun
2018-03-15  0:17 ` [PATCH RFC 1/2] " York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180315010728.GF11061@pd.tnic \
    --to=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=york.sun@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.