From: Pavel Machek <pavel@ucw.cz>
To: Suman Anna <s-anna@ti.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Tony Lindgren <tony@atomide.com>,
Sakari Ailus <sakari.ailus@iki.fi>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH v2] media: omap3isp: fix unbalanced dma_iommu_mapping
Date: Thu, 15 Mar 2018 11:52:00 +0100 [thread overview]
Message-ID: <20180315105200.GA27057@amd> (raw)
In-Reply-To: <20180314154136.16468-1-s-anna@ti.com>
[-- Attachment #1.1: Type: text/plain, Size: 1135 bytes --]
On Wed 2018-03-14 10:41:36, Suman Anna wrote:
> The OMAP3 ISP driver manages its MMU mappings through the IOMMU-aware
> ARM DMA backend. The current code creates a dma_iommu_mapping and
> attaches this to the ISP device, but never detaches the mapping in
> either the probe failure paths or the driver remove path resulting
> in an unbalanced mapping refcount and a memory leak. Fix this properly.
>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> v2 Changes:
> - Dropped the error_attach label, and returned directly from the
> first error path (comments from Sakari)
> - Added Sakari's Acked-by
> v1: https://patchwork.kernel.org/patch/10276759/
>
> Pavel,
> I dropped your Tested-by from v2 since I modified the patch, can you
> recheck the new patch again? Thanks.
I updated to new -next version and re-ran the test.
Tested-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: pavel@ucw.cz (Pavel Machek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] media: omap3isp: fix unbalanced dma_iommu_mapping
Date: Thu, 15 Mar 2018 11:52:00 +0100 [thread overview]
Message-ID: <20180315105200.GA27057@amd> (raw)
In-Reply-To: <20180314154136.16468-1-s-anna@ti.com>
On Wed 2018-03-14 10:41:36, Suman Anna wrote:
> The OMAP3 ISP driver manages its MMU mappings through the IOMMU-aware
> ARM DMA backend. The current code creates a dma_iommu_mapping and
> attaches this to the ISP device, but never detaches the mapping in
> either the probe failure paths or the driver remove path resulting
> in an unbalanced mapping refcount and a memory leak. Fix this properly.
>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> v2 Changes:
> - Dropped the error_attach label, and returned directly from the
> first error path (comments from Sakari)
> - Added Sakari's Acked-by
> v1: https://patchwork.kernel.org/patch/10276759/
>
> Pavel,
> I dropped your Tested-by from v2 since I modified the patch, can you
> recheck the new patch again? Thanks.
I updated to new -next version and re-ran the test.
Tested-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180315/f6f5b43e/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Pavel Machek <pavel@ucw.cz>
To: Suman Anna <s-anna@ti.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@iki.fi>,
Tony Lindgren <tony@atomide.com>,
linux-media@vger.kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] media: omap3isp: fix unbalanced dma_iommu_mapping
Date: Thu, 15 Mar 2018 11:52:00 +0100 [thread overview]
Message-ID: <20180315105200.GA27057@amd> (raw)
In-Reply-To: <20180314154136.16468-1-s-anna@ti.com>
[-- Attachment #1: Type: text/plain, Size: 1135 bytes --]
On Wed 2018-03-14 10:41:36, Suman Anna wrote:
> The OMAP3 ISP driver manages its MMU mappings through the IOMMU-aware
> ARM DMA backend. The current code creates a dma_iommu_mapping and
> attaches this to the ISP device, but never detaches the mapping in
> either the probe failure paths or the driver remove path resulting
> in an unbalanced mapping refcount and a memory leak. Fix this properly.
>
> Reported-by: Pavel Machek <pavel@ucw.cz>
> Signed-off-by: Suman Anna <s-anna@ti.com>
> Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
> v2 Changes:
> - Dropped the error_attach label, and returned directly from the
> first error path (comments from Sakari)
> - Added Sakari's Acked-by
> v1: https://patchwork.kernel.org/patch/10276759/
>
> Pavel,
> I dropped your Tested-by from v2 since I modified the patch, can you
> recheck the new patch again? Thanks.
I updated to new -next version and re-ran the test.
Tested-by: Pavel Machek <pavel@ucw.cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2018-03-15 10:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 15:41 [PATCH v2] media: omap3isp: fix unbalanced dma_iommu_mapping Suman Anna
2018-03-14 15:41 ` Suman Anna
2018-03-14 15:41 ` Suman Anna
2018-03-15 10:52 ` Pavel Machek [this message]
2018-03-15 10:52 ` Pavel Machek
2018-03-15 10:52 ` Pavel Machek
2018-03-21 10:26 ` Laurent Pinchart
2018-03-21 10:26 ` Laurent Pinchart
2018-03-21 10:26 ` Laurent Pinchart
2018-03-26 16:40 ` Suman Anna
2018-03-26 16:40 ` Suman Anna
2018-03-26 16:40 ` Suman Anna
2018-04-11 16:26 ` Sakari Ailus
2018-04-11 16:26 ` Sakari Ailus
2018-04-11 16:26 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315105200.GA27057@amd \
--to=pavel@ucw.cz \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=s-anna@ti.com \
--cc=sakari.ailus@iki.fi \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.