All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laura Abbott <labbott@redhat.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Kees Cook <keescook@chromium.org>, Lukas Wunner <lukas@wunner.de>
Cc: Laura Abbott <labbott@redhat.com>,
	linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-hardening@lists.openwall.com,
	Mathias Duckeck <m.duckeck@kunbus.de>
Subject: [PATCHv2 2/4] gpio: Remove VLA from MAX3191X driver
Date: Thu, 15 Mar 2018 11:00:28 -0700	[thread overview]
Message-ID: <20180315180030.20001-3-labbott@redhat.com> (raw)
In-Reply-To: <20180315180030.20001-1-labbott@redhat.com>


The new challenge is to remove VLAs from the kernel
(see https://lkml.org/lkml/2018/3/7/621)

This patch replaces several a VLA with an appropriate call to
kmalloc_array.

Signed-off-by: Laura Abbott <labbott@redhat.com>
---
v2: No changes
---
 drivers/gpio/gpio-max3191x.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c
index f74b1072e84b..b5b9cb1fda50 100644
--- a/drivers/gpio/gpio-max3191x.c
+++ b/drivers/gpio/gpio-max3191x.c
@@ -315,12 +315,17 @@ static void gpiod_set_array_single_value_cansleep(unsigned int ndescs,
 						  struct gpio_desc **desc,
 						  int value)
 {
-	int i, values[ndescs];
+	int i, *values;
+
+	values = kmalloc_array(ndescs, sizeof(*values), GFP_KERNEL);
+	if (!values)
+		return;
 
 	for (i = 0; i < ndescs; i++)
 		values[i] = value;
 
 	gpiod_set_array_value_cansleep(ndescs, desc, values);
+	kfree(values);
 }
 
 static struct gpio_descs *devm_gpiod_get_array_optional_count(
-- 
2.14.3

  parent reply	other threads:[~2018-03-15 18:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15 18:00 [PATCHv2 0/4] VLA removal from the gpio subsystem Laura Abbott
2018-03-15 18:00 ` [PATCHv2 1/4] gpio: Remove VLA from gpiolib Laura Abbott
2018-03-17 15:36   ` kbuild test robot
2018-03-17 15:36     ` kbuild test robot
2018-03-17 15:36     ` kbuild test robot
2018-03-15 18:00 ` Laura Abbott [this message]
2018-03-19 14:38   ` [PATCHv2 2/4] gpio: Remove VLA from MAX3191X driver Lukas Wunner
2018-03-15 18:00 ` [PATCHv2 3/4] gpio: Remove VLA from xra1403 driver Laura Abbott
2018-03-15 18:00 ` [PATCHv2 4/4] gpio: Remove VLA from stmpe driver Laura Abbott
2018-03-19  1:29   ` Phil Reid
2018-03-22 21:43     ` Laura Abbott
2018-03-23  1:28       ` Phil Reid
2018-03-27 13:41       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180315180030.20001-3-labbott@redhat.com \
    --to=labbott@redhat.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=m.duckeck@kunbus.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.