From: Laura Abbott <labbott@redhat.com>
To: Linus Walleij <linus.walleij@linaro.org>,
Kees Cook <keescook@chromium.org>, Nandor Han <nandor.han@ge.com>
Cc: Laura Abbott <labbott@redhat.com>,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: [PATCHv2 3/4] gpio: Remove VLA from xra1403 driver
Date: Thu, 15 Mar 2018 11:00:29 -0700 [thread overview]
Message-ID: <20180315180030.20001-4-labbott@redhat.com> (raw)
In-Reply-To: <20180315180030.20001-1-labbott@redhat.com>
The new challenge is to remove VLAs from the kernel
(see https://lkml.org/lkml/2018/3/7/621)
This patch replaces a VLA with an appropriate call to kmalloc_array.
Reviewed-by: Nandor Han <nandor.han@ge.com>
Signed-off-by: Laura Abbott <labbott@redhat.com>
---
v3: Add reviwed-by
---
drivers/gpio/gpio-xra1403.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-xra1403.c b/drivers/gpio/gpio-xra1403.c
index 0230e4b7a2fb..8d4c8e99b251 100644
--- a/drivers/gpio/gpio-xra1403.c
+++ b/drivers/gpio/gpio-xra1403.c
@@ -126,11 +126,16 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip)
{
int reg;
struct xra1403 *xra = gpiochip_get_data(chip);
- int value[xra1403_regmap_cfg.max_register];
+ int *value;
int i;
unsigned int gcr;
unsigned int gsr;
+ value = kmalloc_array(xra1403_regmap_cfg.max_register, sizeof(*value),
+ GFP_KERNEL);
+ if (!value)
+ return;
+
seq_puts(s, "xra reg:");
for (reg = 0; reg <= xra1403_regmap_cfg.max_register; reg++)
seq_printf(s, " %2.2x", reg);
@@ -154,6 +159,7 @@ static void xra1403_dbg_show(struct seq_file *s, struct gpio_chip *chip)
(gcr & BIT(i)) ? "in" : "out",
(gsr & BIT(i)) ? "hi" : "lo");
}
+ kfree(value);
}
#else
#define xra1403_dbg_show NULL
--
2.14.3
next prev parent reply other threads:[~2018-03-15 18:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 18:00 [PATCHv2 0/4] VLA removal from the gpio subsystem Laura Abbott
2018-03-15 18:00 ` [PATCHv2 1/4] gpio: Remove VLA from gpiolib Laura Abbott
2018-03-17 15:36 ` kbuild test robot
2018-03-17 15:36 ` kbuild test robot
2018-03-17 15:36 ` kbuild test robot
2018-03-15 18:00 ` [PATCHv2 2/4] gpio: Remove VLA from MAX3191X driver Laura Abbott
2018-03-19 14:38 ` Lukas Wunner
2018-03-15 18:00 ` Laura Abbott [this message]
2018-03-15 18:00 ` [PATCHv2 4/4] gpio: Remove VLA from stmpe driver Laura Abbott
2018-03-19 1:29 ` Phil Reid
2018-03-22 21:43 ` Laura Abbott
2018-03-23 1:28 ` Phil Reid
2018-03-27 13:41 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315180030.20001-4-labbott@redhat.com \
--to=labbott@redhat.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nandor.han@ge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.