From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
"Usyskin, Alexander" <alexander.usyskin@intel.com>,
"linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
"linux-security-module@vger.kernel.org"
<linux-security-module@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c
Date: Fri, 16 Mar 2018 16:02:40 +0200 [thread overview]
Message-ID: <20180316140240.GA9616@linux.intel.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B94237DCA@hasmsx108.ger.corp.intel.com>
On Thu, Mar 15, 2018 at 11:24:23PM +0000, Winkler, Tomas wrote:
> >
> > On Sat, 2018-03-10 at 10:24 +0200, Tomas Winkler wrote:
> > > + rlength = be32_to_cpu(tpm_cmd.header.out.length);
> > > + if (rlength < offsetof(struct tpm_getrandom_out, rng_data) +
> > > + recd) {
> > > + total = -EFAULT;
> > > + break;
> > > + }
> > > + memcpy(dest, tpm_cmd.params.getrandom_out.rng_data,
> > recd);
> >
> > This rlength stuff can be handled with tpm_buf_length() as I do in my
> > pendig-for-review patch set:
> >
> > https://patchwork.kernel.org/patch/10259331/
>
> Right, as I wrote before not sure it's good to move and change the code more than necessary at the same time.
> I would leave the tpm_buf_ changes after this series.
Right, this is a valid point. I'll ack this as it is. Thanks for
pointing this out.
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c
Date: Fri, 16 Mar 2018 16:02:40 +0200 [thread overview]
Message-ID: <20180316140240.GA9616@linux.intel.com> (raw)
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B94237DCA@hasmsx108.ger.corp.intel.com>
On Thu, Mar 15, 2018 at 11:24:23PM +0000, Winkler, Tomas wrote:
> >
> > On Sat, 2018-03-10 at 10:24 +0200, Tomas Winkler wrote:
> > > + rlength = be32_to_cpu(tpm_cmd.header.out.length);
> > > + if (rlength < offsetof(struct tpm_getrandom_out, rng_data) +
> > > + recd) {
> > > + total = -EFAULT;
> > > + break;
> > > + }
> > > + memcpy(dest, tpm_cmd.params.getrandom_out.rng_data,
> > recd);
> >
> > This rlength stuff can be handled with tpm_buf_length() as I do in my
> > pendig-for-review patch set:
> >
> > https://patchwork.kernel.org/patch/10259331/
>
> Right, as I wrote before not sure it's good to move and change the code more than necessary at the same time.
> I would leave the tpm_buf_ changes after this series.
Right, this is a valid point. I'll ack this as it is. Thanks for
pointing this out.
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-16 14:02 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 8:24 [PATCH v2 0/8] tpm: factor out tpm1 code into tpm1-cmd.c Tomas Winkler
2018-03-10 8:24 ` Tomas Winkler
2018-03-10 8:24 ` [PATCH v2 1/8] tpm: move tpm1_pcr_extend to tpm1-cmd.c Tomas Winkler
2018-03-10 8:24 ` Tomas Winkler
2018-03-15 16:27 ` Jarkko Sakkinen
2018-03-15 16:27 ` Jarkko Sakkinen
2018-03-10 8:24 ` [PATCH v2 2/8] tpm: move tpm_getcap " Tomas Winkler
2018-03-10 8:24 ` Tomas Winkler
2018-03-15 16:29 ` Jarkko Sakkinen
2018-03-15 16:29 ` Jarkko Sakkinen
2018-03-10 8:24 ` [PATCH v2 3/8] tpm: factor out tpm1_get_random into tpm1-cmd.c Tomas Winkler
2018-03-10 8:24 ` Tomas Winkler
2018-03-15 16:32 ` Jarkko Sakkinen
2018-03-15 16:32 ` Jarkko Sakkinen
2018-03-15 23:24 ` Winkler, Tomas
2018-03-15 23:24 ` Winkler, Tomas
2018-03-16 14:02 ` Jarkko Sakkinen [this message]
2018-03-16 14:02 ` Jarkko Sakkinen
2018-03-10 8:24 ` [PATCH v2 4/8] tpm: move tpm1 selftest code from tpm-interface tpm1-cmd.c Tomas Winkler
2018-03-10 8:24 ` Tomas Winkler
2018-03-15 16:37 ` Jarkko Sakkinen
2018-03-15 16:37 ` Jarkko Sakkinen
2018-03-10 8:24 ` [PATCH v2 5/8] tpm: factor out tpm1 pm suspend flow into tpm1-cmd.c Tomas Winkler
2018-03-10 8:24 ` Tomas Winkler
2018-03-15 16:40 ` Jarkko Sakkinen
2018-03-15 16:40 ` Jarkko Sakkinen
2018-03-10 8:24 ` [PATCH v2 6/8] tpm: factor out tpm_startup function Tomas Winkler
2018-03-10 8:24 ` Tomas Winkler
2018-03-15 16:41 ` Jarkko Sakkinen
2018-03-15 16:41 ` Jarkko Sakkinen
2018-03-10 8:24 ` [PATCH v2 7/8] tpm: Move pcr extend to tpm2-cmd.c Tomas Winkler
2018-03-10 8:24 ` Tomas Winkler
2018-03-15 16:47 ` Jarkko Sakkinen
2018-03-15 16:47 ` Jarkko Sakkinen
2018-03-15 23:28 ` Winkler, Tomas
2018-03-15 23:28 ` Winkler, Tomas
2018-03-16 14:08 ` Jarkko Sakkinen
2018-03-16 14:08 ` Jarkko Sakkinen
2018-03-10 8:24 ` [PATCH v2 8/8] tpm: move tpm2 code validation to tpm2-space.c Tomas Winkler
2018-03-10 8:24 ` Tomas Winkler
2018-03-15 16:49 ` Jarkko Sakkinen
2018-03-15 16:49 ` Jarkko Sakkinen
2018-03-15 16:35 ` [PATCH v2 0/8] tpm: factor out tpm1 code into tpm1-cmd.c Jarkko Sakkinen
2018-03-15 16:35 ` Jarkko Sakkinen
2018-03-15 23:25 ` Winkler, Tomas
2018-03-15 23:25 ` Winkler, Tomas
2018-03-16 14:03 ` Jarkko Sakkinen
2018-03-16 14:03 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180316140240.GA9616@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=alexander.usyskin@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.