All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: lars@metafoo.de, Michael.Hennerich@analog.com, pmeerw@pmeerw.net,
	gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	daniel.baluta@gmail.com, 21cnbao@gmail.com
Subject: Re: [PATCH v2 6/9] Staging: iio: accel: adis16201: Use sign_extend32 function
Date: Sun, 18 Mar 2018 08:33:14 +0000	[thread overview]
Message-ID: <20180318083314.3b444790@archlinux> (raw)
In-Reply-To: <1521230786-18155-7-git-send-email-himanshujha199640@gmail.com>

On Sat, 17 Mar 2018 01:36:23 +0530
Himanshu Jha <himanshujha199640@gmail.com> wrote:

> Use sign_extned32() for 32 bit sign extending rather than hard coding.
> 
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>

Great, applied.

Thanks,

Jonathan

> ---
> v2:
>    -no change in this patch.
> 
>  drivers/staging/iio/accel/adis16201.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c
> index 97150ea..298bf90 100644
> --- a/drivers/staging/iio/accel/adis16201.c
> +++ b/drivers/staging/iio/accel/adis16201.c
> @@ -173,9 +173,8 @@ static int adis16201_read_raw(struct iio_dev *indio_dev,
>  		ret = adis_read_reg_16(st, addr, &val16);
>  		if (ret)
>  			return ret;
> -		val16 &= (1 << bits) - 1;
> -		val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> -		*val = val16;
> +
> +		*val = sign_extend32(val16, bits - 1);
>  		return IIO_VAL_INT;
>  	}
>  


WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Himanshu Jha <himanshujha199640@gmail.com>
Cc: devel@driverdev.osuosl.org, daniel.baluta@gmail.com,
	lars@metafoo.de, Michael.Hennerich@analog.com,
	linux-iio@vger.kernel.org, gregkh@linuxfoundation.org,
	21cnbao@gmail.com, linux-kernel@vger.kernel.org,
	pmeerw@pmeerw.net
Subject: Re: [PATCH v2 6/9] Staging: iio: accel: adis16201: Use sign_extend32 function
Date: Sun, 18 Mar 2018 08:33:14 +0000	[thread overview]
Message-ID: <20180318083314.3b444790@archlinux> (raw)
In-Reply-To: <1521230786-18155-7-git-send-email-himanshujha199640@gmail.com>

On Sat, 17 Mar 2018 01:36:23 +0530
Himanshu Jha <himanshujha199640@gmail.com> wrote:

> Use sign_extned32() for 32 bit sign extending rather than hard coding.
> 
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>

Great, applied.

Thanks,

Jonathan

> ---
> v2:
>    -no change in this patch.
> 
>  drivers/staging/iio/accel/adis16201.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/iio/accel/adis16201.c b/drivers/staging/iio/accel/adis16201.c
> index 97150ea..298bf90 100644
> --- a/drivers/staging/iio/accel/adis16201.c
> +++ b/drivers/staging/iio/accel/adis16201.c
> @@ -173,9 +173,8 @@ static int adis16201_read_raw(struct iio_dev *indio_dev,
>  		ret = adis_read_reg_16(st, addr, &val16);
>  		if (ret)
>  			return ret;
> -		val16 &= (1 << bits) - 1;
> -		val16 = (s16)(val16 << (16 - bits)) >> (16 - bits);
> -		*val = val16;
> +
> +		*val = sign_extend32(val16, bits - 1);
>  		return IIO_VAL_INT;
>  	}
>  

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2018-03-18  8:33 UTC|newest]

Thread overview: 55+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-16 20:06 [PATCH v2 0/9] Staging: iio: accel: adis16201 driver cleanup Himanshu Jha
2018-03-16 20:06 ` Himanshu Jha
2018-03-16 20:06 ` [PATCH v2 1/9] Staging: iio: accel: adis16201: Rename few macro definitions Himanshu Jha
2018-03-16 20:06   ` Himanshu Jha
2018-03-18  8:19   ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 2/9] Staging: iio: accel: adis16201: Remove unnecessary comments Himanshu Jha
2018-03-16 20:06   ` Himanshu Jha
2018-03-18  8:22   ` Jonathan Cameron
2018-03-18  8:22     ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 3/9] Staging: iio: accel: adis16201: Add _REG suffix to reisters Himanshu Jha
2018-03-16 20:06   ` Himanshu Jha
2018-03-18  8:24   ` Jonathan Cameron
2018-03-18  8:24     ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 4/9] Staging: iio: accel: adis16201: Group register definitions Himanshu Jha
2018-03-16 20:06   ` Himanshu Jha
2018-03-18  8:29   ` Jonathan Cameron
2018-03-18  8:29     ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 5/9] Staging: iio: accel: adis16201: Add comments about units in read_raw() Himanshu Jha
2018-03-16 20:06   ` Himanshu Jha
2018-03-18  8:32   ` Jonathan Cameron
2018-03-18  8:32     ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 6/9] Staging: iio: accel: adis16201: Use sign_extend32 function Himanshu Jha
2018-03-16 20:06   ` Himanshu Jha
2018-03-18  8:33   ` Jonathan Cameron [this message]
2018-03-18  8:33     ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 7/9] Staging: iio: accel: adis16201: Prefer reverse christmas tree ordering Himanshu Jha
2018-03-16 20:06   ` Himanshu Jha
2018-03-18  8:34   ` Jonathan Cameron
2018-03-18  8:34     ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 8/9] Staging: iio: accel: adis16201: Adjust argument to match open parentheses Himanshu Jha
2018-03-16 20:06   ` Himanshu Jha
2018-03-18  8:35   ` Jonathan Cameron
2018-03-18  8:35     ` Jonathan Cameron
2018-03-16 20:06 ` [PATCH v2 9/9] Staging: iio: accel: adis16201: Move adis16201 driver out of staging Himanshu Jha
2018-03-16 20:06   ` Himanshu Jha
2018-03-18  9:31   ` Jonathan Cameron
2018-03-18  9:31     ` Jonathan Cameron
2018-03-22 19:12   ` [PATCH 1/4] Staging: iio: accel: adis16201: Remove unused headers Himanshu Jha
2018-03-22 19:12     ` Himanshu Jha
2018-03-22 19:12     ` [PATCH 2/4] Staging: iio: accel: adis16201: Use GENMASK Himanshu Jha
2018-03-22 19:12       ` Himanshu Jha
2018-03-24 14:16       ` Jonathan Cameron
2018-03-24 14:16         ` Jonathan Cameron
2018-03-22 19:12     ` [PATCH 3/4] Staging: iio: accel: adis16201: Fix 80 character line limit Himanshu Jha
2018-03-22 19:12       ` Himanshu Jha
2018-03-24 14:16       ` Jonathan Cameron
2018-03-24 14:16         ` Jonathan Cameron
2018-03-22 19:12     ` [PATCH 4/4] Staging: iio: accel: adis16201: Move adis16201 driver out of staging Himanshu Jha
2018-03-22 19:12       ` Himanshu Jha
2018-03-24 14:26       ` Jonathan Cameron
2018-03-24 14:26         ` Jonathan Cameron
2018-03-23 13:32     ` [PATCH 1/4] Staging: iio: accel: adis16201: Remove unused headers Jonathan Cameron
2018-03-23 13:32       ` Jonathan Cameron
2018-03-24 14:15     ` Jonathan Cameron
2018-03-24 14:15       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180318083314.3b444790@archlinux \
    --to=jic23@kernel.org \
    --cc=21cnbao@gmail.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=daniel.baluta@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=himanshujha199640@gmail.com \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.