From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm64: fix undefined reference to 'printk'
Date: Mon, 19 Mar 2018 11:23:02 +0000 [thread overview]
Message-ID: <20180319112302.GA11021@arm.com> (raw)
In-Reply-To: <20180313125309.3662792-1-arnd@arndb.de>
On Tue, Mar 13, 2018 at 01:52:36PM +0100, Arnd Bergmann wrote:
> The printk symbol was intended as a generic address that is always
> exported, however that turned out to be false with CONFIG_PRINTK=n:
>
> ERROR: "printk" [arch/arm64/kernel/arm64-reloc-test.ko] undefined!
>
> This changes the references to memstart_addr, which should be there
> regardless of configuration.
>
> Fixes: a257e02579e4 ("arm64/kernel: don't ban ADRP to work around Cortex-A53 erratum #843419")
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: fix changelog as pointed out by Ard
>
> arch/arm64/kernel/reloc_test_core.c | 2 +-
> arch/arm64/kernel/reloc_test_syms.S | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Cheers, I've picked this up now. Sorry for the delay.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] arm64: fix undefined reference to 'printk'
Date: Mon, 19 Mar 2018 11:23:02 +0000 [thread overview]
Message-ID: <20180319112302.GA11021@arm.com> (raw)
In-Reply-To: <20180313125309.3662792-1-arnd@arndb.de>
On Tue, Mar 13, 2018 at 01:52:36PM +0100, Arnd Bergmann wrote:
> The printk symbol was intended as a generic address that is always
> exported, however that turned out to be false with CONFIG_PRINTK=n:
>
> ERROR: "printk" [arch/arm64/kernel/arm64-reloc-test.ko] undefined!
>
> This changes the references to memstart_addr, which should be there
> regardless of configuration.
>
> Fixes: a257e02579e4 ("arm64/kernel: don't ban ADRP to work around Cortex-A53 erratum #843419")
> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> v2: fix changelog as pointed out by Ard
>
> arch/arm64/kernel/reloc_test_core.c | 2 +-
> arch/arm64/kernel/reloc_test_syms.S | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
Cheers, I've picked this up now. Sorry for the delay.
Will
next prev parent reply other threads:[~2018-03-19 11:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 11:41 [PATCH] arm64: fix undefined reference to 'printk' Arnd Bergmann
2018-03-13 11:41 ` Arnd Bergmann
2018-03-13 12:48 ` Ard Biesheuvel
2018-03-13 12:48 ` Ard Biesheuvel
2018-03-13 12:52 ` [PATCH v2] " Arnd Bergmann
2018-03-13 12:52 ` Arnd Bergmann
2018-03-19 11:23 ` Will Deacon [this message]
2018-03-19 11:23 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319112302.GA11021@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.