Re: [PATCH] staging:vc04_services:bcm2835-camera:controls.c: Fix multiple line dereference

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Mar 19, 2018 at 02:07:42PM +0000, Nishka Dasgupta wrote:
> Fix multiple line dereference. Issue found with checkpatch.

What is a "multiple line dereference"?

> 
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> ---
>  drivers/staging/vc04_services/bcm2835-camera/controls.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/vc04_services/bcm2835-camera/controls.c b/drivers/staging/vc04_services/bcm2835-camera/controls.c
> index cff7b1e..bae7f2e 100644
> --- a/drivers/staging/vc04_services/bcm2835-camera/controls.c
> +++ b/drivers/staging/vc04_services/bcm2835-camera/controls.c
> @@ -1194,6 +1194,8 @@ int set_framerate_params(struct bm2835_mmal_dev *dev)
>  {
>  	struct mmal_parameter_fps_range fps_range;
>  	int ret;
> +	int mcc = MMAL_COMPONENT_CAMERA;
> +	int mcpp = MMAL_CAMERA_PORT_PREVIEW;
>  
>  	if ((dev->exposure_mode_active != MMAL_PARAM_EXPOSUREMODE_OFF) &&
>  	    (dev->exp_auto_priority)) {
> @@ -1220,8 +1222,7 @@ int set_framerate_params(struct bm2835_mmal_dev *dev)
>  		 fps_range.fps_high.den);
>  
>  	ret = vchiq_mmal_port_parameter_set(dev->instance,
> -					    &dev->component[MMAL_COMPONENT_CAMERA]->
> -					    output[MMAL_CAMERA_PORT_PREVIEW],
> +					    &dev->component[mcc]->output[mcpp],

I don't see what the benifit of this change is here, a shorter line?
It's really not worth it, don't you think?

thanks,

greg k-h