Re: [PATCH] staging:vc04_services:bcm2835-camera:controls.c: Fix multiple line dereference

[Greg KH <gregkh@linuxfoundation.org>]

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Mon, Mar 19, 2018 at 08:54:11PM +0530, Nishka Dasgupta wrote:
> The reference (in this and other patches of the same type) is of the
> form dev->component[something]->output[something else]. Because of the
> line limit, this tended to be split over multiple lines even though
> it's technically (as far as I can tell) a single argument. Such
> splitting may have the effect of making the code harder to follow
> (since we now have to mentally assemble the same value from multiple
> lines of code).
> By condensing the parts within the square brackets to 3 or 4
> characters, I could fit the entire variable in a single line without
> violating the 80 character limit.

Yeah, but you "waste" two new variables for this, and force the reader
to have to go backwards to try to understand what exactly the array
values are, and be confused as to why they never change.

If you don't like the statement, it can be all put on one line, and
ignore the 80 column rule here.  Or better yet, just indent things a bit
to keep it all on one line, or use a temp variable for the pointer
value.

As it is, I don't like this change, sorry.

greg k-h