From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgg@ziepe.ca>, Sahil Rihan <srihan@fb.com>
Cc: linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
Alexei Starovoitov <ast@fb.com>,
stable@vger.kernel.org, Peter Huewe <peterhuewe@gmx.de>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm: allow TCPA log area to be empty
Date: Mon, 19 Mar 2018 23:24:36 +0200 [thread overview]
Message-ID: <20180319212436.GD14364@linux.intel.com> (raw)
In-Reply-To: <20180319021323.GD27186@ziepe.ca>
On Sun, Mar 18, 2018 at 08:13:23PM -0600, Jason Gunthorpe wrote:
> On Fri, Mar 16, 2018 at 02:55:25PM +0200, Jarkko Sakkinen wrote:
> > On Mon, Mar 12, 2018 at 09:02:32AM -0600, Jason Gunthorpe wrote:
> > > On Sat, Mar 10, 2018 at 06:16:37PM +0200, Jarkko Sakkinen wrote:
> > > > TCPA log are can be empty when the TPM is disabled. This commit changes the
> > > > behavior of tpm_read_log_acpi() to return successfully in this case.
> > >
> > > The commit should explain why we'd want this..
> > >
> > > eg Why does it matter to create the extra sysfs files to report an empty
> > > log?
> > >
> > > Jason
> >
> > The initialization of the driver will fail otherwise. Not sure if I
> > understand your question.
>
> Well, I mean in the sense of what is broken and why is this the right
> fix. Why not return -ENODEV?
Well, because then the device initialization would fail.
Just noticed that this is missing:
Reported-by: Sahil Rihan <srihan@fb.com>
Sahil, would you care to try if this fixes the issue that you are
having or not?
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] tpm: allow TCPA log area to be empty
Date: Mon, 19 Mar 2018 23:24:36 +0200 [thread overview]
Message-ID: <20180319212436.GD14364@linux.intel.com> (raw)
In-Reply-To: <20180319021323.GD27186@ziepe.ca>
On Sun, Mar 18, 2018 at 08:13:23PM -0600, Jason Gunthorpe wrote:
> On Fri, Mar 16, 2018 at 02:55:25PM +0200, Jarkko Sakkinen wrote:
> > On Mon, Mar 12, 2018 at 09:02:32AM -0600, Jason Gunthorpe wrote:
> > > On Sat, Mar 10, 2018 at 06:16:37PM +0200, Jarkko Sakkinen wrote:
> > > > TCPA log are can be empty when the TPM is disabled. This commit changes the
> > > > behavior of tpm_read_log_acpi() to return successfully in this case.
> > >
> > > The commit should explain why we'd want this..
> > >
> > > eg Why does it matter to create the extra sysfs files to report an empty
> > > log?
> > >
> > > Jason
> >
> > The initialization of the driver will fail otherwise. Not sure if I
> > understand your question.
>
> Well, I mean in the sense of what is broken and why is this the right
> fix. Why not return -ENODEV?
Well, because then the device initialization would fail.
Just noticed that this is missing:
Reported-by: Sahil Rihan <srihan@fb.com>
Sahil, would you care to try if this fixes the issue that you are
having or not?
/Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-03-19 21:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 16:16 [PATCH] tpm: allow TCPA log area to be empty Jarkko Sakkinen
2018-03-10 16:16 ` Jarkko Sakkinen
2018-03-12 11:09 ` Jarkko Sakkinen
2018-03-12 11:09 ` Jarkko Sakkinen
2018-03-12 15:02 ` Jason Gunthorpe
2018-03-12 15:02 ` Jason Gunthorpe
2018-03-16 12:55 ` Jarkko Sakkinen
2018-03-16 12:55 ` Jarkko Sakkinen
2018-03-19 2:13 ` Jason Gunthorpe
2018-03-19 2:13 ` Jason Gunthorpe
2018-03-19 21:24 ` Jarkko Sakkinen [this message]
2018-03-19 21:24 ` Jarkko Sakkinen
2018-03-20 22:29 ` Sahil Rihan
2018-03-20 22:29 ` Sahil Rihan
2018-03-22 14:20 ` Jarkko Sakkinen
2018-03-22 14:20 ` Jarkko Sakkinen
2018-03-27 0:07 ` Sahil Rihan
2018-03-27 0:07 ` Sahil Rihan
2018-03-27 8:05 ` Jarkko Sakkinen
2018-03-27 8:05 ` Jarkko Sakkinen
2018-03-27 15:37 ` Sahil Rihan
2018-03-27 15:37 ` Sahil Rihan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319212436.GD14364@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=arnd@arndb.de \
--cc=ast@fb.com \
--cc=gregkh@linuxfoundation.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=srihan@fb.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.