From: maxime.ripard@bootlin.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop
Date: Mon, 19 Mar 2018 22:27:42 +0100 [thread overview]
Message-ID: <20180319212742.wttebbgoh2la63o5@flea> (raw)
In-Reply-To: <20180319071723.GA854@afzalpc>
hi,
On Mon, Mar 19, 2018 at 12:47:23PM +0530, afzal mohammed wrote:
> On Sun, Mar 18, 2018 at 09:22:51PM +0100, Maxime Ripard wrote:
> > The first part is supposed to be the name of the boards. I did sed
> > s/leds/teres-i/, and applied, together with all the patches but the
> > PWM (so I had to drop the backlight node as well).
> >
> > Please coordinate with Andre about who should send the PWM support.
>
> Assuming that these patches were applied to your sunxi/dt64-for-4.17
> branch, since PWM support patch is missing, there is a build error,
>
> arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts:129.1-5 Label or path pwm not found
>
> Diff at the end cures it.
>
> (there is another H6 pine 64 DT build error related to header file
> missing)
>
> afzal
>
>
> --->8---
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> index b3c7ef6b6fe5..d9baab3dc96b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> @@ -126,12 +126,6 @@
> status = "okay";
> };
>
> -&pwm {
> - pinctrl-names = "default";
> - pinctrl-0 = <&pwm_pin>;
> - status = "okay";
> -};
> -
> &ohci1 {
> status = "okay";
> };
>
Thanks for noticing and sending a patch. I've fixed the original
commit.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20180319/ae8f8c20/attachment.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: afzal mohammed <afzal.mohd.ma@gmail.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org,
Andre Przywara <andre.przywara@arm.com>,
info@olimex.com, Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>, Harald Geyer <harald@ccbib.org>,
linux-arm-kernel@lists.infradead.org,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop
Date: Mon, 19 Mar 2018 22:27:42 +0100 [thread overview]
Message-ID: <20180319212742.wttebbgoh2la63o5@flea> (raw)
In-Reply-To: <20180319071723.GA854@afzalpc>
[-- Attachment #1.1: Type: text/plain, Size: 1551 bytes --]
hi,
On Mon, Mar 19, 2018 at 12:47:23PM +0530, afzal mohammed wrote:
> On Sun, Mar 18, 2018 at 09:22:51PM +0100, Maxime Ripard wrote:
> > The first part is supposed to be the name of the boards. I did sed
> > s/leds/teres-i/, and applied, together with all the patches but the
> > PWM (so I had to drop the backlight node as well).
> >
> > Please coordinate with Andre about who should send the PWM support.
>
> Assuming that these patches were applied to your sunxi/dt64-for-4.17
> branch, since PWM support patch is missing, there is a build error,
>
> arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts:129.1-5 Label or path pwm not found
>
> Diff at the end cures it.
>
> (there is another H6 pine 64 DT build error related to header file
> missing)
>
> afzal
>
>
> --->8---
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> index b3c7ef6b6fe5..d9baab3dc96b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> @@ -126,12 +126,6 @@
> status = "okay";
> };
>
> -&pwm {
> - pinctrl-names = "default";
> - pinctrl-0 = <&pwm_pin>;
> - status = "okay";
> -};
> -
> &ohci1 {
> status = "okay";
> };
>
Thanks for noticing and sending a patch. I've fixed the original
commit.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard@bootlin.com>
To: afzal mohammed <afzal.mohd.ma@gmail.com>
Cc: Harald Geyer <harald@ccbib.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, info@olimex.com,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Rob Herring <robh+dt@kernel.org>,
Andre Przywara <andre.przywara@arm.com>,
linux-arm-kernel@lists.infradead.org,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop
Date: Mon, 19 Mar 2018 22:27:42 +0100 [thread overview]
Message-ID: <20180319212742.wttebbgoh2la63o5@flea> (raw)
In-Reply-To: <20180319071723.GA854@afzalpc>
[-- Attachment #1: Type: text/plain, Size: 1551 bytes --]
hi,
On Mon, Mar 19, 2018 at 12:47:23PM +0530, afzal mohammed wrote:
> On Sun, Mar 18, 2018 at 09:22:51PM +0100, Maxime Ripard wrote:
> > The first part is supposed to be the name of the boards. I did sed
> > s/leds/teres-i/, and applied, together with all the patches but the
> > PWM (so I had to drop the backlight node as well).
> >
> > Please coordinate with Andre about who should send the PWM support.
>
> Assuming that these patches were applied to your sunxi/dt64-for-4.17
> branch, since PWM support patch is missing, there is a build error,
>
> arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts:129.1-5 Label or path pwm not found
>
> Diff at the end cures it.
>
> (there is another H6 pine 64 DT build error related to header file
> missing)
>
> afzal
>
>
> --->8---
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> index b3c7ef6b6fe5..d9baab3dc96b 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-teres-i.dts
> @@ -126,12 +126,6 @@
> status = "okay";
> };
>
> -&pwm {
> - pinctrl-names = "default";
> - pinctrl-0 = <&pwm_pin>;
> - status = "okay";
> -};
> -
> &ohci1 {
> status = "okay";
> };
>
Thanks for noticing and sending a patch. I've fixed the original
commit.
Maxime
--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-19 21:27 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 16:25 [PATCHv2 0/5] arm64: allwinner: Add support for TERES-I laptop Harald Geyer
2018-03-15 16:25 ` Harald Geyer
2018-03-15 16:25 ` [PATCHv2 1/5] arm64: dts: allwinner: a64: Add i2c0 pins Harald Geyer
2018-03-15 16:25 ` Harald Geyer
2018-03-15 16:25 ` [PATCHv2 2/5] arm64: dts: allwinner: a64: Add watchdog Harald Geyer
2018-03-15 16:25 ` Harald Geyer
2018-03-18 12:52 ` Rob Herring
2018-03-18 12:52 ` Rob Herring
2018-03-18 12:52 ` Rob Herring
2018-03-15 16:25 ` [PATCHv2 3/5] arm64: dts: allwinner: a64: add simplefb for A64 SoC Harald Geyer
2018-03-15 16:25 ` Harald Geyer
2018-03-15 16:25 ` [PATCHv2 4/5] arm64: dts: allwinner: a64: Add pwm device Harald Geyer
2018-03-15 16:25 ` Harald Geyer
2018-03-18 12:52 ` Rob Herring
2018-03-18 12:52 ` Rob Herring
2018-03-18 13:51 ` André Przywara
2018-03-18 13:51 ` André Przywara
2018-03-15 16:25 ` [PATCHv2 5/5] arm64: allwinner: a64: Add support for TERES-I laptop Harald Geyer
2018-03-15 16:25 ` Harald Geyer
2018-03-16 6:37 ` afzal mohammed
2018-03-16 6:37 ` afzal mohammed
2018-03-16 17:50 ` afzal mohammed
2018-03-16 17:50 ` afzal mohammed
2018-03-18 20:22 ` Maxime Ripard
2018-03-18 20:22 ` Maxime Ripard
2018-03-19 7:17 ` afzal mohammed
2018-03-19 7:17 ` afzal mohammed
2018-03-19 21:27 ` Maxime Ripard [this message]
2018-03-19 21:27 ` Maxime Ripard
2018-03-19 21:27 ` Maxime Ripard
2018-03-19 15:27 ` Harald Geyer
2018-03-19 15:27 ` Harald Geyer
2018-03-20 14:13 ` Maxime Ripard
2018-03-20 14:13 ` Maxime Ripard
2018-03-20 17:09 ` Andre Przywara
2018-03-20 17:09 ` Andre Przywara
2018-03-22 17:59 ` Maxime Ripard
2018-03-22 17:59 ` Maxime Ripard
2018-06-22 16:27 ` Icenowy Zheng
2018-06-22 16:27 ` Icenowy Zheng
2018-06-24 16:34 ` Harald Geyer
2018-06-24 16:34 ` Harald Geyer
2018-06-25 7:43 ` Arend van Spriel
2018-06-25 7:43 ` Arend van Spriel
2018-06-25 7:47 ` Icenowy Zheng
2018-06-25 7:47 ` Icenowy Zheng
2018-06-25 8:13 ` Arend van Spriel
2018-06-25 8:13 ` Arend van Spriel
2018-06-25 10:42 ` Icenowy Zheng
2018-06-25 10:42 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180319212742.wttebbgoh2la63o5@flea \
--to=maxime.ripard@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.