USB: misc: uss720: more vendor/product ID's

[Greg KH <greg@kroah.com>]

On Wed, Mar 14, 2018 at 03:20:04PM -0700, Daniel Gimpelevich wrote:
> Reporting two more VID/PID pairs that work with this driver, having used
> an informational webpage <http://reboots.g-cipher.net/lcd/> as a buying
> guide now. The page listed additional working VID/PID pairs but did not
> include these two. None were upstreamed. Also taking this opportunity to
> sort the pairs numerically.
> 
> Of the two such cables now in my possession, one is white, bearing the
> In-System Design ISD-103 label on one side, sold as an Epson CAEUL0002
> "USB to Parallel Smart Cable For Apple Macintosh Computers" (04b8:0002),
> and the other is black, bearing the In-System Design ISD-101 label on one
> side, sold as an early Belkin F5U002 (05ab:0002).
> 
> Signed-off-by: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
> Cc: stable <stable@vger.kernel.org>
> ---
>  drivers/usb/misc/uss720.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
> index 263c97f..a208e4b 100644
> --- a/drivers/usb/misc/uss720.c
> +++ b/drivers/usb/misc/uss720.c
> @@ -769,10 +769,15 @@ static void uss720_disconnect(struct usb_interface *intf)
>  /* table of cables that work through this driver */
>  static const struct usb_device_id uss720_table[] = {
>  	{ USB_DEVICE(0x047e, 0x1001) },
> +	{ USB_DEVICE(0x04b8, 0x0002) },			/* Daniel Gimpelevich */
> +	{ USB_DEVICE(0x04b8, 0x0003) },			/* Added by Rab */

Who is "Rab" and why do you need to name who added what id to the patch?

> +	{ USB_DEVICE(0x050d, 0x0002) },			/* Fabio Battaglia */

It doesn't say that Fabio added this one below, are you sure?

> +	{ USB_DEVICE(0x050d, 0x1202) },			/* Added by Rab */
>  	{ USB_DEVICE(0x0557, 0x2001) },
> +	{ USB_DEVICE(0x05ab, 0x0002) },                 /* Daniel Gimpelevich */
> +	{ USB_DEVICE(0x06c6, 0x0100) },			/* Added by Rab */
>  	{ USB_DEVICE(0x0729, 0x1284) },
>  	{ USB_DEVICE(0x1293, 0x0002) },
> -	{ USB_DEVICE(0x050d, 0x0002) },

What is more useful is a description of the device types, not who added
the new id, can you do that instead?

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html