All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
Cc: linux-usb@vger.kernel.org, Rab <reboots@g-cipher.net>
Subject: USB: misc: uss720: more vendor/product ID's
Date: Tue, 20 Mar 2018 10:08:27 +0100	[thread overview]
Message-ID: <20180320090827.GA18667@kroah.com> (raw)

On Tue, Mar 20, 2018 at 02:03:46AM -0700, Daniel Gimpelevich wrote:
> On Tue, 2018-03-20 at 09:36 +0100, Greg KH wrote:
> > Who is "Rab" and why do you need to name who added what id to the
> > patch?
> > 
> I copied that part from the web page I referenced in the commit message.
> It's evidently a reference to the page's author. I tried to send an
> e-mail to the address at the bottom of the page, with no response. I
> also CC'ed from git send-email.
> > 
> > What is more useful is a description of the device types, not who
> > added
> > the new id, can you do that instead?
> 
> For the "Rab" devices, there is a wealth of such information on the
> aforementioned web page. I added the info for the ones I have into the
> commit message.
> 
> > It doesn't say that Fabio added this one below, are you sure?
> 
> It says that in the commit that added it:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/misc/uss720.c?id=ecc1624a2fff45780959efbcb73ace18fdb3c58d

Ok, but that isn't needed in the comments of the code.

Put the device "type" or "name" as a comment, that makes more sense and
follows what almost all other drivers do.

> > Always use scripts/get_maintainer.pl to figure out who to cc: on the
> > patches, otherwise the maintainer might miss it :(
> 
> Hmm, I simply looked in the MAINTAINERS file instead, which has no entry
> for this driver.

If there is no default, it falls back to the maintainer(s) of the
subsystem, which get_maintainer.pl knows how to handle.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

             reply	other threads:[~2018-03-20  9:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-20  9:08 Greg KH [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-03-20  9:37 USB: misc: uss720: more vendor/product ID's Greg KH
2018-03-20  9:23 Daniel Gimpelevich
2018-03-20  9:21 Greg KH
2018-03-20  9:13 Daniel Gimpelevich
2018-03-20  9:03 Daniel Gimpelevich
2018-03-20  8:36 Greg KH
2018-03-20  8:35 Greg Kroah-Hartman
2018-03-14 22:20 Daniel Gimpelevich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180320090827.GA18667@kroah.com \
    --to=greg@kroah.com \
    --cc=daniel@gimpelevich.san-francisco.ca.us \
    --cc=linux-usb@vger.kernel.org \
    --cc=reboots@g-cipher.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.