All of lore.kernel.org
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Gabriel Matni <gabriel.matni@exfo.com>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
	"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"Grégory Clement" <gregory.clement@bootlin.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH] serial: mvebu-uart: fix tx lost characters
Date: Tue, 20 Mar 2018 10:32:08 +0100	[thread overview]
Message-ID: <20180320093208.GA22194@kroah.com> (raw)
In-Reply-To: <3B588D51285A4A4D8D39C94212E07826278BDF@SPQCMBX02.exfo.com>

On Fri, Mar 16, 2018 at 01:45:32PM +0000, Gabriel Matni wrote:
> From: Gabriel Matni <gabriel.matni@exfo.com>
> 
> Fixes missing characters on kernel console at low baud rates (i.e.9600).
> The driver should poll TX_RDY or TX_FIFO_EMP instead of TX_EMP to ensure
> that the transmitter holding register (THR) is ready to receive a new byte.
> 
> TX_EMP tells us when it is possible to send a break sequence via
> SND_BRK_SEQ. While this also indicates that both the THR and the TSR are
> empty, it does not guarantee that a new byte can be written just yet.
> 
> Fixes: 30530791a7a0 ("serial: mvebu-uart: initial support for Armada-3700
>       serial port")

Can all be on one line.

And should this go to the stable trees?

> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> 
> Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>  
> Signed-off-by: Gabriel Matni <gabriel.matni@exfo.com> 

Trailing whitespace?

> 
> ---
>  drivers/tty/serial/mvebu-uart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What version of this patch is this?  How do I know which to accept?

Please properly version your patch, and include the changes below the
--- line like the documentation says to do.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (gregkh at linuxfoundation.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] serial: mvebu-uart: fix tx lost characters
Date: Tue, 20 Mar 2018 10:32:08 +0100	[thread overview]
Message-ID: <20180320093208.GA22194@kroah.com> (raw)
In-Reply-To: <3B588D51285A4A4D8D39C94212E07826278BDF@SPQCMBX02.exfo.com>

On Fri, Mar 16, 2018 at 01:45:32PM +0000, Gabriel Matni wrote:
> From: Gabriel Matni <gabriel.matni@exfo.com>
> 
> Fixes missing characters on kernel console at low baud rates (i.e.9600).
> The driver should poll TX_RDY or TX_FIFO_EMP instead of TX_EMP to ensure
> that the transmitter holding register (THR) is ready to receive a new byte.
> 
> TX_EMP tells us when it is possible to send a break sequence via
> SND_BRK_SEQ. While this also indicates that both the THR and the TSR are
> empty, it does not guarantee that a new byte can be written just yet.
> 
> Fixes: 30530791a7a0 ("serial: mvebu-uart: initial support for Armada-3700
>       serial port")

Can all be on one line.

And should this go to the stable trees?

> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> 
> Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>  
> Signed-off-by: Gabriel Matni <gabriel.matni@exfo.com> 

Trailing whitespace?

> 
> ---
>  drivers/tty/serial/mvebu-uart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

What version of this patch is this?  How do I know which to accept?

Please properly version your patch, and include the changes below the
--- line like the documentation says to do.

thanks,

greg k-h

  reply	other threads:[~2018-03-20  9:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 15:47 [PATCH] serial: mvebu-uart: fix tx lost characters Gabriel Matni
2018-03-15 16:55 ` gregkh at linuxfoundation.org
2018-03-15 18:55   ` Gabriel Matni
2018-03-15 18:55     ` Gabriel Matni
2018-03-15 20:21     ` Miquel Raynal
2018-03-15 20:21       ` Miquel Raynal
2018-03-16 13:45       ` Gabriel Matni
2018-03-16 13:45         ` Gabriel Matni
2018-03-20  9:32         ` gregkh [this message]
2018-03-20  9:32           ` gregkh at linuxfoundation.org

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180320093208.GA22194@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=gabriel.matni@exfo.com \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=stable@vger.kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.