All of lore.kernel.org
 help / color / mirror / Atom feed
* [v2] USB: misc: uss720: more vendor/product ID's
  2018-03-20 10:58 ` [PATCH v2] " Daniel Gimpelevich
@ 2018-03-20 11:28 ` Greg KH
  -1 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2018-03-20 11:28 UTC (permalink / raw)
  To: Daniel Gimpelevich
  Cc: linux-usb, linux-kernel, johan, richard.leitner, felipe.balbi

On Tue, Mar 20, 2018 at 03:58:47AM -0700, Daniel Gimpelevich wrote:
> Reporting two more VID/PID pairs that work with this driver, having used
> an informational webpage <http://reboots.g-cipher.net/lcd/> as a buying
> guide now. The page listed additional working VID/PID pairs but did not
> include these two. None were upstreamed. Also taking this opportunity to
> sort the pairs numerically.
> 
> Of the two such cables now in my possession, one is white, bearing the
> In-System Design ISD-103 label on one side, sold as an Epson CAEUL0002
> "USB to Parallel Smart Cable For Apple Macintosh Computers" (04b8:0002),
> and the other is black, bearing the In-System Design ISD-101 label on one
> side, sold as an early Belkin F5U002 (05ab:0002).
> 
> Signed-off-by: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
> ---
>  drivers/usb/misc/uss720.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

For the next time, you should put the versioning of the patch below the
--- line, saying what changed in each version, so we remember what is
going on here.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread
* [v2] USB: misc: uss720: more vendor/product ID's
  2018-03-20  9:37 Greg KH
@ 2018-03-20 10:58 ` Daniel Gimpelevich
  -1 siblings, 0 replies; 5+ messages in thread
From: Daniel Gimpelevich @ 2018-03-20 10:58 UTC (permalink / raw)
  To: linux-usb, linux-kernel, gregkh
  Cc: johan, richard.leitner, felipe.balbi, Daniel Gimpelevich

Reporting two more VID/PID pairs that work with this driver, having used
an informational webpage <http://reboots.g-cipher.net/lcd/> as a buying
guide now. The page listed additional working VID/PID pairs but did not
include these two. None were upstreamed. Also taking this opportunity to
sort the pairs numerically.

Of the two such cables now in my possession, one is white, bearing the
In-System Design ISD-103 label on one side, sold as an Epson CAEUL0002
"USB to Parallel Smart Cable For Apple Macintosh Computers" (04b8:0002),
and the other is black, bearing the In-System Design ISD-101 label on one
side, sold as an early Belkin F5U002 (05ab:0002).

Signed-off-by: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
---
 drivers/usb/misc/uss720.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index 263c97f..de9a502 100644
--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -769,10 +769,15 @@ static void uss720_disconnect(struct usb_interface *intf)
 /* table of cables that work through this driver */
 static const struct usb_device_id uss720_table[] = {
 	{ USB_DEVICE(0x047e, 0x1001) },
+	{ USB_DEVICE(0x04b8, 0x0002) },
+	{ USB_DEVICE(0x04b8, 0x0003) },
+	{ USB_DEVICE(0x050d, 0x0002) },
+	{ USB_DEVICE(0x050d, 0x1202) },
 	{ USB_DEVICE(0x0557, 0x2001) },
+	{ USB_DEVICE(0x05ab, 0x0002) },
+	{ USB_DEVICE(0x06c6, 0x0100) },
 	{ USB_DEVICE(0x0729, 0x1284) },
 	{ USB_DEVICE(0x1293, 0x0002) },
-	{ USB_DEVICE(0x050d, 0x0002) },
 	{ }						/* Terminating entry */
 };
 

^ permalink raw reply related	[flat|nested] 5+ messages in thread
* USB: misc: uss720: more vendor/product ID's
@ 2018-03-20  9:37 Greg KH
  0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2018-03-20  9:37 UTC (permalink / raw)
  To: Daniel Gimpelevich; +Cc: linux-usb, Rab

On Tue, Mar 20, 2018 at 02:23:54AM -0700, Daniel Gimpelevich wrote:
> On Tue, 2018-03-20 at 10:21 +0100, Greg KH wrote:
> > On Tue, Mar 20, 2018 at 02:13:48AM -0700, Daniel Gimpelevich wrote:
> > > On Tue, 2018-03-20 at 10:08 +0100, Greg KH wrote:
> > > > Put the device "type" or "name" as a comment, that makes more sense
> > > > and
> > > > follows what almost all other drivers do.
> > > 
> > > I strongly considered this, but I ultimately decided against it in
> > > consideration of the limited space for comments on the right, the lack
> > > of such device identification extant in this driver, and the presence of
> > > most or all of the listed devices in the usb.ids file.
> > 
> > There is no usb.ids file anymore :)
> 
> The "update-usbids" command still downloads
> http://www.linux-usb.org/usb.ids for me.

Yes, but udev builds it into the hardware id database now directly, and
I doubt any other tool relies on it anymore.  'lsusb' hasn't for quite
some time.

Anyway, pointless digression, can you please fix up the patch to at the
least, take out the people's names from the comments in the code and
resend it so that it can be applied.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-03-20 11:28 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-03-20 11:28 [v2] USB: misc: uss720: more vendor/product ID's Greg Kroah-Hartman
2018-03-20 11:28 ` [PATCH v2] " Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2018-03-20 10:58 [v2] " Daniel Gimpelevich
2018-03-20 10:58 ` [PATCH v2] " Daniel Gimpelevich
2018-03-20  9:37 Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.