From: Jerome Glisse <jglisse@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Ralph Campbell <rcampbell@nvidia.com>,
Evgeny Baskakov <ebaskakov@nvidia.com>,
Mark Hairgrove <mhairgrove@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH 3/4] mm/hmm: HMM should have a callback before MM is destroyed
Date: Tue, 20 Mar 2018 10:45:31 -0400 [thread overview]
Message-ID: <20180320144531.GA3716@redhat.com> (raw)
In-Reply-To: <20180320113326.GJ23100@dhcp22.suse.cz>
On Tue, Mar 20, 2018 at 12:33:26PM +0100, Michal Hocko wrote:
> On Thu 15-03-18 15:48:29, Andrew Morton wrote:
> > On Thu, 15 Mar 2018 14:36:59 -0400 jglisse@redhat.com wrote:
> >
> > > From: Ralph Campbell <rcampbell@nvidia.com>
> > >
> > > The hmm_mirror_register() function registers a callback for when
> > > the CPU pagetable is modified. Normally, the device driver will
> > > call hmm_mirror_unregister() when the process using the device is
> > > finished. However, if the process exits uncleanly, the struct_mm
> > > can be destroyed with no warning to the device driver.
> >
> > The changelog doesn't tell us what the runtime effects of the bug are.
> > This makes it hard for me to answer the "did Jerome consider doing
> > cc:stable" question.
>
> There is no upstream user of this code IIRC, so does it make sense to
> mark anything for stable trees?
I am fine with dropping stable, distribution that care about out of tree
drivers can easily backport themself. I am hoping to have the nouveau
part upstream in 4.18/4.19 ...
Cheers,
Jerome
WARNING: multiple messages have this Message-ID (diff)
From: Jerome Glisse <jglisse@redhat.com>
To: Michal Hocko <mhocko@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Ralph Campbell <rcampbell@nvidia.com>,
Evgeny Baskakov <ebaskakov@nvidia.com>,
Mark Hairgrove <mhairgrove@nvidia.com>,
John Hubbard <jhubbard@nvidia.com>
Subject: Re: [PATCH 3/4] mm/hmm: HMM should have a callback before MM is destroyed
Date: Tue, 20 Mar 2018 10:45:31 -0400 [thread overview]
Message-ID: <20180320144531.GA3716@redhat.com> (raw)
In-Reply-To: <20180320113326.GJ23100@dhcp22.suse.cz>
On Tue, Mar 20, 2018 at 12:33:26PM +0100, Michal Hocko wrote:
> On Thu 15-03-18 15:48:29, Andrew Morton wrote:
> > On Thu, 15 Mar 2018 14:36:59 -0400 jglisse@redhat.com wrote:
> >
> > > From: Ralph Campbell <rcampbell@nvidia.com>
> > >
> > > The hmm_mirror_register() function registers a callback for when
> > > the CPU pagetable is modified. Normally, the device driver will
> > > call hmm_mirror_unregister() when the process using the device is
> > > finished. However, if the process exits uncleanly, the struct_mm
> > > can be destroyed with no warning to the device driver.
> >
> > The changelog doesn't tell us what the runtime effects of the bug are.
> > This makes it hard for me to answer the "did Jerome consider doing
> > cc:stable" question.
>
> There is no upstream user of this code IIRC, so does it make sense to
> mark anything for stable trees?
I am fine with dropping stable, distribution that care about out of tree
drivers can easily backport themself. I am hoping to have the nouveau
part upstream in 4.18/4.19 ...
Cheers,
Jérôme
next prev parent reply other threads:[~2018-03-20 14:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 18:36 [PATCH 0/4] hmm: fixes and documentations jglisse
2018-03-15 18:36 ` jglisse
2018-03-15 18:36 ` [PATCH 1/4] mm/hmm: documentation editorial update to HMM documentation jglisse
2018-03-15 18:36 ` jglisse
2018-03-15 18:36 ` [PATCH 2/4] mm/hmm: fix header file if/else/endif maze jglisse
2018-03-15 18:36 ` jglisse
2018-03-16 0:11 ` Balbir Singh
2018-03-17 0:53 ` kbuild test robot
2018-03-17 0:53 ` kbuild test robot
2018-03-15 18:36 ` [PATCH 3/4] mm/hmm: HMM should have a callback before MM is destroyed jglisse
2018-03-15 18:36 ` jglisse
2018-03-15 22:48 ` Andrew Morton
2018-03-16 0:54 ` Jerome Glisse
2018-03-16 1:17 ` John Hubbard
2018-03-16 1:17 ` John Hubbard
2018-03-20 11:33 ` Michal Hocko
2018-03-20 14:45 ` Jerome Glisse [this message]
2018-03-20 14:45 ` Jerome Glisse
2018-03-15 18:37 ` [PATCH 4/4] mm/hmm: change CPU page table snapshot functions to simplify drivers jglisse
2018-03-15 18:37 ` jglisse
2018-03-16 5:08 ` John Hubbard
2018-03-16 5:08 ` John Hubbard
2018-03-16 19:19 ` Jerome Glisse
2018-03-16 19:19 ` Jerome Glisse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320144531.GA3716@redhat.com \
--to=jglisse@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebaskakov@nvidia.com \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhairgrove@nvidia.com \
--cc=mhocko@kernel.org \
--cc=rcampbell@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.