From: Jason Gunthorpe <jgg@ziepe.ca>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: linux-rdma@vger.kernel.org, timur@codeaurora.org,
sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Faisal Latif <faisal.latif@intel.com>,
Shiraz Saleem <shiraz.saleem@intel.com>,
Doug Ledford <dledford@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/6] RDMA/i40iw: Eliminate duplicate barriers on weakly-ordered archs
Date: Tue, 20 Mar 2018 08:56:26 -0600 [thread overview]
Message-ID: <20180320145626.GJ19744@ziepe.ca> (raw)
In-Reply-To: <1521514068-8856-4-git-send-email-okaya@codeaurora.org>
On Mon, Mar 19, 2018 at 10:47:45PM -0400, Sinan Kaya wrote:
> Code includes wmb() followed by writel(). writel() already has a barrier on
> some architectures like arm64.
>
> This ends up CPU observing two barriers back to back before executing the
> register write.
>
> Create a new wrapper function with relaxed write operator. Use the new
> wrapper when a write is following a wmb().
>
> Since code already has an explicit barrier call, changing writel() to
> writel_relaxed().
>
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 6 ++++--
> drivers/infiniband/hw/i40iw/i40iw_osdep.h | 1 +
> drivers/infiniband/hw/i40iw/i40iw_uk.c | 2 +-
> drivers/infiniband/hw/i40iw/i40iw_utils.c | 11 +++++++++++
> 4 files changed, 17 insertions(+), 3 deletions(-)
The one looks fine
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Jason
WARNING: multiple messages have this Message-ID (diff)
From: jgg@ziepe.ca (Jason Gunthorpe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/6] RDMA/i40iw: Eliminate duplicate barriers on weakly-ordered archs
Date: Tue, 20 Mar 2018 08:56:26 -0600 [thread overview]
Message-ID: <20180320145626.GJ19744@ziepe.ca> (raw)
In-Reply-To: <1521514068-8856-4-git-send-email-okaya@codeaurora.org>
On Mon, Mar 19, 2018 at 10:47:45PM -0400, Sinan Kaya wrote:
> Code includes wmb() followed by writel(). writel() already has a barrier on
> some architectures like arm64.
>
> This ends up CPU observing two barriers back to back before executing the
> register write.
>
> Create a new wrapper function with relaxed write operator. Use the new
> wrapper when a write is following a wmb().
>
> Since code already has an explicit barrier call, changing writel() to
> writel_relaxed().
>
> Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
> drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 6 ++++--
> drivers/infiniband/hw/i40iw/i40iw_osdep.h | 1 +
> drivers/infiniband/hw/i40iw/i40iw_uk.c | 2 +-
> drivers/infiniband/hw/i40iw/i40iw_utils.c | 11 +++++++++++
> 4 files changed, 17 insertions(+), 3 deletions(-)
The one looks fine
Reviewed-by: Jason Gunthorpe <jgg@mellanox.com>
Jason
next prev parent reply other threads:[~2018-03-20 14:56 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-20 2:47 [PATCH v4 0/6] ib: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-20 2:47 ` Sinan Kaya
2018-03-20 2:47 ` [PATCH v4 1/6] RDMA/bnxt_re: " Sinan Kaya
2018-03-20 2:47 ` Sinan Kaya
2018-03-20 14:48 ` Jason Gunthorpe
2018-03-20 14:48 ` Jason Gunthorpe
2018-03-20 15:00 ` Sinan Kaya
2018-03-20 15:00 ` Sinan Kaya
2018-03-20 15:08 ` Sinan Kaya
2018-03-20 15:08 ` Sinan Kaya
2018-03-20 15:23 ` Jason Gunthorpe
2018-03-20 15:23 ` Jason Gunthorpe
2018-03-20 15:20 ` Jason Gunthorpe
2018-03-20 15:20 ` Jason Gunthorpe
2018-03-20 15:30 ` Sinan Kaya
2018-03-20 15:30 ` Sinan Kaya
2018-03-20 16:02 ` Jason Gunthorpe
2018-03-20 16:02 ` Jason Gunthorpe
2018-03-20 2:47 ` [PATCH v4 2/6] IB/mlx4: " Sinan Kaya
2018-03-20 2:47 ` Sinan Kaya
2018-03-20 14:48 ` Jason Gunthorpe
2018-03-20 14:48 ` Jason Gunthorpe
2018-03-20 2:47 ` [PATCH v4 3/6] RDMA/i40iw: " Sinan Kaya
2018-03-20 2:47 ` Sinan Kaya
2018-03-20 14:56 ` Jason Gunthorpe [this message]
2018-03-20 14:56 ` Jason Gunthorpe
2018-03-21 13:38 ` Shiraz Saleem
2018-03-21 13:38 ` Shiraz Saleem
2018-03-21 20:02 ` Jason Gunthorpe
2018-03-21 20:02 ` Jason Gunthorpe
2018-03-21 21:01 ` Sinan Kaya
2018-03-21 21:01 ` Sinan Kaya
2018-03-20 2:47 ` [PATCH v4 4/6] infiniband: cxgb4: " Sinan Kaya
2018-03-20 2:47 ` Sinan Kaya
2018-03-20 14:51 ` Jason Gunthorpe
2018-03-20 14:51 ` Jason Gunthorpe
2018-03-20 15:10 ` Steve Wise
2018-03-20 15:10 ` Steve Wise
2018-03-20 15:38 ` Steve Wise
2018-03-20 15:38 ` Steve Wise
2018-03-22 6:44 ` kbuild test robot
2018-03-22 6:44 ` kbuild test robot
2018-03-22 12:24 ` okaya
2018-03-22 12:24 ` okaya at codeaurora.org
2018-03-22 12:48 ` okaya
2018-03-22 12:48 ` okaya at codeaurora.org
2018-03-22 14:33 ` Sinan Kaya
2018-03-22 14:33 ` Sinan Kaya
2018-03-22 14:40 ` Steve Wise
2018-03-22 14:40 ` Steve Wise
2018-03-22 14:52 ` Sinan Kaya
2018-03-22 14:52 ` Sinan Kaya
2018-03-22 16:28 ` Steve Wise
2018-03-22 16:28 ` Steve Wise
2018-03-22 19:44 ` Casey Leedom
2018-03-22 19:44 ` Casey Leedom
2018-03-22 20:16 ` Jason Gunthorpe
2018-03-22 20:16 ` Jason Gunthorpe
2018-03-22 20:45 ` Casey Leedom
2018-03-22 20:45 ` Casey Leedom
2018-03-22 21:25 ` Jason Gunthorpe
2018-03-22 21:25 ` Jason Gunthorpe
2018-03-22 21:27 ` Sinan Kaya
2018-03-22 21:27 ` Sinan Kaya
2018-03-22 22:02 ` Casey Leedom
2018-03-22 22:02 ` Casey Leedom
[not found] ` <437ab002-b8db-24aa-583e-0e61d61aaa97@codeaurora.org>
2018-03-22 18:46 ` Jason Gunthorpe
2018-03-22 18:46 ` Jason Gunthorpe
2018-03-22 18:48 ` Jason Gunthorpe
2018-03-22 18:48 ` Jason Gunthorpe
2018-03-22 18:58 ` Sinan Kaya
2018-03-22 18:58 ` Sinan Kaya
2018-03-23 4:14 ` kbuild test robot
2018-03-23 4:14 ` kbuild test robot
2018-03-20 2:47 ` [PATCH v4 5/6] IB/nes: " Sinan Kaya
2018-03-20 2:47 ` Sinan Kaya
2018-03-20 14:54 ` Jason Gunthorpe
2018-03-20 14:54 ` Jason Gunthorpe
2018-03-20 15:23 ` Sinan Kaya
2018-03-20 15:23 ` Sinan Kaya
2018-03-20 16:01 ` Jason Gunthorpe
2018-03-20 16:01 ` Jason Gunthorpe
2018-03-20 16:08 ` Sinan Kaya
2018-03-20 16:08 ` Sinan Kaya
2018-03-20 16:29 ` Jason Gunthorpe
2018-03-20 16:29 ` Jason Gunthorpe
2018-03-20 2:47 ` [PATCH v4 6/6] RDMA/qedr: eliminate duplicate barriers on weakly-ordered archs #2 Sinan Kaya
2018-03-20 2:47 ` Sinan Kaya
2018-03-20 7:38 ` Kalderon, Michal
2018-03-20 7:38 ` Kalderon, Michal
2018-03-20 14:55 ` Jason Gunthorpe
2018-03-20 14:55 ` Jason Gunthorpe
2018-03-21 20:08 ` [PATCH v4 0/6] ib: Eliminate duplicate barriers on weakly-ordered archs Jason Gunthorpe
2018-03-21 20:08 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180320145626.GJ19744@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=faisal.latif@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=shiraz.saleem@intel.com \
--cc=sulrich@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.