All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>,
	jerin.jacob@caviumnetworks.com,
	santosh.shukla@caviumnetworks.com, thomas@monjalon.net,
	anatoly.burakov@intel.com, lironh@marvell.com,
	bruce.richardson@intel.com, fiona.trahe@intel.com,
	shreyansh.jain@nxp.com
Cc: dev@dpdk.org
Subject: Re: [PATCH v2 2/2] octeontx: move mbox to common folder
Date: Tue, 20 Mar 2018 21:30:40 +0530	[thread overview]
Message-ID: <20180320160039.GA18022@ltp-pvn> (raw)
In-Reply-To: <10673fa8-fd41-c869-779b-c34459368508@nxp.com>

Hi Hemant,

On Tue, Mar 20, 2018 at 08:31:42PM +0530, Hemant Agrawal wrote:
>
> HI Pavan,
>     One quick comment
>
> On 3/20/2018 8:10 PM, Pavan Nikhilesh wrote:
> > -LDLIBS += -lrte_eal -lrte_eventdev -lrte_mempool_octeontx -lrte_pmd_octeontx
> > +LDLIBS += -lrte_eal -lrte_eventdev -lrte_octeontx_common -lrte_pmd_octeontx
> Typically the naming convention for driver based libraries is
> "rte_type_specific" e.g. rte_mempool_octeontx.
> rte_octeontx_common is breaking the tradition.

Currently, meson uses that scheme where as traditional make uses
rte_mempool_octeontx style. I will change it to rte_common_octeontx for
traditional make in v3.

<meson>
config_flag_fmt = 'RTE_LIBRTE_@0@_MEMPOOL'
driver_name_fmt = 'rte_mempool_@0@'

>
> Regards,
> Hemant

Thanks,
Pavan.

  reply	other threads:[~2018-03-20 16:00 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-19  9:27 [PATCH 1/2] drivers: add common folder Pavan Nikhilesh
2018-03-19  9:27 ` [PATCH 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-03-19 10:35 ` [PATCH 1/2] drivers: add " Shreyansh Jain
2018-03-20 14:38   ` Pavan Nikhilesh
2018-03-20 14:40 ` [PATCH v2 " Pavan Nikhilesh
2018-03-20 14:40   ` [PATCH v2 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-03-20 15:01     ` Hemant Agrawal
2018-03-20 16:00       ` Pavan Nikhilesh [this message]
2018-03-20 15:45   ` [PATCH v2 1/2] drivers: add " Thomas Monjalon
2018-03-20 16:06     ` Pavan Nikhilesh
2018-03-20 17:01       ` Bruce Richardson
2018-03-20 17:27         ` Thomas Monjalon
2018-03-20 19:25           ` Trahe, Fiona
2018-03-26  7:53 ` [PATCH v3 " Pavan Nikhilesh
2018-03-26  7:53   ` [PATCH v3 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-03-27 16:15     ` Thomas Monjalon
2018-03-30 17:23       ` Pavan Nikhilesh
2018-03-27 16:11   ` [PATCH v3 1/2] drivers: add " Thomas Monjalon
2018-04-02  9:09 ` [PATCH v4 " Pavan Nikhilesh
2018-04-02  9:10   ` [PATCH v4 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-04-04  3:29     ` Jerin Jacob
2018-04-04  5:06       ` santosh
2018-04-04  9:23     ` Thomas Monjalon
2018-04-03  6:57   ` [PATCH v4 1/2] drivers: add " Hemant Agrawal
2018-04-04  3:08     ` Jerin Jacob
2018-04-04  5:01   ` santosh
2018-04-04 14:30 ` [PATCH v5 " Pavan Nikhilesh
2018-04-04 14:30   ` [PATCH v5 2/2] octeontx: move mbox to " Pavan Nikhilesh
2018-04-04 14:37     ` Thomas Monjalon
2018-04-04 21:20     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180320160039.GA18022@ltp-pvn \
    --to=pbhagavatula@caviumnetworks.com \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerin.jacob@caviumnetworks.com \
    --cc=lironh@marvell.com \
    --cc=santosh.shukla@caviumnetworks.com \
    --cc=shreyansh.jain@nxp.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.