Re: [PATCH v3 1/2] drivers: add common folder

[Thomas Monjalon <thomas@monjalon.net>]

26/03/2018 09:53, Pavan Nikhilesh:
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -3,18 +3,19 @@
> 
>  include $(RTE_SDK)/mk/rte.vars.mk
> 
> +DIRS-y += common
>  DIRS-y += bus
>  DIRS-y += mempool
> -DEPDIRS-mempool := bus
> +DEPDIRS-mempool := bus common
>  DIRS-y += net
> -DEPDIRS-net := bus mempool
> +DEPDIRS-net := bus common mempool
>  DIRS-$(CONFIG_RTE_LIBRTE_BBDEV) += bbdev
> -DEPDIRS-bbdev := bus mempool
> +DEPDIRS-bbdev := bus common mempool
>  DIRS-$(CONFIG_RTE_LIBRTE_CRYPTODEV) += crypto
> -DEPDIRS-crypto := bus mempool
> +DEPDIRS-crypto := bus common mempool
>  DIRS-$(CONFIG_RTE_LIBRTE_EVENTDEV) += event
> -DEPDIRS-event := bus mempool net
> +DEPDIRS-event := bus common mempool net
>  DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += raw
> -DEPDIRS-raw := bus mempool net event
> +DEPDIRS-raw := bus common mempool net event

> --- a/drivers/meson.build
> +++ b/drivers/meson.build
> @@ -2,11 +2,12 @@
>  # Copyright(c) 2017 Intel Corporation
> 
>  # Defines the order in which the drivers are buit.
> -driver_classes = ['bus',
> -	       'mempool', # depends on bus.
> -	       'net',     # depends on bus and mempool.
> -	       'crypto',  # depenss on bus, mempool (net in future).
> -	       'event']   # depends on bus, mempool and net.
> +driver_classes = ['common',
> +	       'bus',
> +	       'mempool', # depends on bus and common.
> +	       'net',     # depends on bus, common and mempool.
> +	       'crypto',  # depenss on bus, common and mempool (net in future).
> +	       'event']   # depends on bus, common, mempool and net.

It seems you used alphabetical order to list dependencies in the Makefile
and in meson.build. I think it would be more logical to have common
before bus in dependencies.

You can also take the opportunity to fix the typo on "depenss".

Thanks