From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: david@fromorbit.com, fstests <fstests@vger.kernel.org>
Subject: [PATCH] common/xfs: don't call xfs_scrub on a block device
Date: Wed, 21 Mar 2018 19:46:56 -0700 [thread overview]
Message-ID: <20180322024656.GC4810@magnolia> (raw)
In-Reply-To: <20180321165716.GB4818@magnolia>
From: Darrick J. Wong <darrick.wong@oracle.com>
xfs_scrub takes an xfs mountpoint as its argument, not a block device.
Therefore, fix _check_xfs_filesystem to call it correctly.
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
common/xfs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/xfs b/common/xfs
index 5dbd81e..1d98ba1 100644
--- a/common/xfs
+++ b/common/xfs
@@ -358,7 +358,7 @@ _check_xfs_filesystem()
# Run online scrub if we can.
mntpt="$(_is_dev_mounted $device)"
if [ -n "$mntpt" ] && _supports_xfs_scrub "$mntpt" "$device"; then
- "$XFS_SCRUB_PROG" $scrubflag -v -d -n $device > $tmp.scrub 2>&1
+ "$XFS_SCRUB_PROG" $scrubflag -v -d -n $mntpt > $tmp.scrub 2>&1
if [ $? -ne 0 ]; then
_log_err "_check_xfs_filesystem: filesystem on $device failed scrub"
echo "*** xfs_scrub $scrubflag -v -d -n output ***" >> $seqres.full
next prev parent reply other threads:[~2018-03-22 2:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 16:57 [PATCH v3] xfs: test agfl reset on bad list wrapping Darrick J. Wong
2018-03-22 2:46 ` Darrick J. Wong [this message]
2018-03-29 10:25 ` [PATCH] common/xfs: don't call xfs_scrub on a block device Xiao Yang
2018-03-29 15:46 ` Darrick J. Wong
2018-03-22 2:48 ` [PATCH] common/xfs: fix various problems with _supports_xfs_scrub Darrick J. Wong
2018-03-23 5:26 ` [PATCH v3] xfs: test agfl reset on bad list wrapping Eryu Guan
2018-03-23 16:08 ` Darrick J. Wong
2018-03-26 1:22 ` Eryu Guan
2018-03-28 1:20 ` Eryu Guan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180322024656.GC4810@magnolia \
--to=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=guaneryu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.